Skip to content

Commit 889e4ee

Browse files
authored
Merge pull request #2106 from vvbandeira/ci-dev
ci: use correct tag for docker push
2 parents 7be07b3 + 664c0a1 commit 889e4ee

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

etc/DockerHelper.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ baseDir="$(pwd)"
88
# docker hub organization/user from where to pull/push images
99
org=openroad
1010

11+
DOCKER_CMD="docker"
12+
1113
_help() {
1214
cat <<EOF
1315
usage: $0 [CMD] [OPTIONS]
@@ -77,7 +79,7 @@ _setup() {
7779

7880
_create() {
7981
echo "Create docker image ${imagePath} using ${file}"
80-
docker build \
82+
${DOCKER_CMD} build \
8183
--file "${file}" \
8284
--tag "${imagePath}" \
8385
${buildArgs} \
@@ -99,7 +101,7 @@ _push() {
99101
_help
100102
fi
101103

102-
docker login --username "${username}" --password "${password}"
104+
${DOCKER_CMD} login --username "${username}" --password "${password}"
103105

104106
if [[ "${tag}" == "" ]]; then
105107
tag=$(./etc/DockerTag.sh -dev)
@@ -109,18 +111,16 @@ _push() {
109111
./etc/DockerHelper.sh create -os=${os} -target=dev -tag=${tag} -ci \
110112
2>&1 | tee build/create-${os}-dev-${tag}.log
111113

112-
docker push "${imageName}:${tag}"
114+
${DOCKER_CMD} push "${org}/flow-${os}-dev:${tag}"
113115

114116
if [[ "${target}" == "master" ]]; then
115117
tag=$(./etc/DockerTag.sh -master)
116118
# Create builder image
117-
./etc/DockerHelper.sh create -os=${os} -target=builder -tag=${tag} \
119+
./etc/DockerHelper.sh create -os=${os} -target=builder \
118120
2>&1 | tee build/create-${os}-${target}-${tag}.log
119121

120-
docker tag ${org}/flow-${os}-builder:${tag} ${org}/orfs:${tag}
121-
docker push ${org}/orfs:${tag}
122-
docker tag ${org}/flow-${os}-builder:${tag} ${org}/orfs:${tag}
123-
docker push ${org}/orfs:${tag}
122+
${DOCKER_CMD} tag ${org}/flow-${os}-builder:${imageTag} ${org}/orfs:${tag}
123+
${DOCKER_CMD} push ${org}/orfs:${tag}
124124
fi
125125
}
126126

0 commit comments

Comments
 (0)