Skip to content

Commit a960727

Browse files
committed
variables: use default values, gives error on spelling mistakes
Signed-off-by: Øyvind Harboe <[email protected]>
1 parent 5cefa05 commit a960727

File tree

12 files changed

+18
-18
lines changed

12 files changed

+18
-18
lines changed

flow/scripts/cts.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ detailed_placement
4747

4848
estimate_parasitics -placement
4949

50-
if { [env_var_equals CTS_SNAPSHOTS 1] } {
50+
if { $::env(CTS_SNAPSHOTS) } {
5151
save_progress 4_1_pre_repair_hold_setup
5252
}
5353

54-
if { ![env_var_equals SKIP_CTS_REPAIR_TIMING 1] } {
54+
if { !$::env(SKIP_CTS_REPAIR_TIMING) } {
5555
if { $::env(EQUIVALENCE_CHECK) } {
5656
write_eqy_verilog 4_before_rsz.v
5757
}

flow/scripts/density_fill.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ source $::env(SCRIPTS_DIR)/load.tcl
22
erase_non_stage_variables final
33
load_design 5_route.odb 5_route.sdc
44

5-
if { [env_var_equals USE_FILL 1] } {
5+
if { $::env(USE_FILL) } {
66
set_propagated_clock [all_clocks]
77
density_fill -rules $::env(FILL_CONFIG)
88
# The .v file is just for debugging purposes, not a result of

flow/scripts/detail_place.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source $::env(PLATFORM_DIR)/setRC.tcl
77

88
proc do_dpl { } {
99
# Only for use with hybrid rows
10-
if { [env_var_equals BALANCE_ROWS 1] } {
10+
if { $::env(BALANCE_ROWS) } {
1111
balance_row_usage
1212
}
1313

@@ -16,7 +16,7 @@ proc do_dpl { } {
1616
-right $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT)
1717
detailed_placement
1818

19-
if { [env_var_equals ENABLE_DPO 1] } {
19+
if { $::env(ENABLE_DPO) } {
2020
if { [env_var_exists_and_non_empty DPO_MAX_DISPLACEMENT] } {
2121
improve_placement -max_displacement $::env(DPO_MAX_DISPLACEMENT)
2222
} else {

flow/scripts/detail_route.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ if { ![grt::have_routes] } {
66
in DRC viewer to view congestion"
77
}
88

9-
if { [env_var_equals SKIP_DETAILED_ROUTE 1] } {
9+
if { !$::env(SKIP_DETAILED_ROUTE) } {
1010
write_db $::env(RESULTS_DIR)/5_2_route.odb
1111
exit
1212
}
@@ -53,7 +53,7 @@ set all_args [concat [list \
5353
log_cmd detailed_route {*}$all_args
5454

5555
if {
56-
![env_var_equals SKIP_ANTENNA_REPAIR_POST_DRT 1] &&
56+
!$::env(SKIP_ANTENNA_REPAIR_POST_DRT) &&
5757
[env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_DRT]
5858
} {
5959
set repair_antennas_iters 1

flow/scripts/final_report.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ write_verilog $::env(RESULTS_DIR)/6_final.v \
2121
# Run extraction and STA
2222
if {
2323
[env_var_exists_and_non_empty RCX_RULES]
24-
&& [env_var_equals SKIP_DETAILED_ROUTE 0]
24+
&& !$::env(SKIP_DETAILED_ROUTE)
2525
} {
2626
# RCX section
2727
define_process_corner -ext_model_index 0 X

flow/scripts/floorplan.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ if { [env_var_exists_and_non_empty FASTROUTE_TCL] } {
111111

112112
source_env_var_if_exists FOOTPRINT_TCL
113113

114-
if { ![env_var_equals SKIP_REPAIR_TIE_FANOUT 1] } {
114+
if { !$::env(SKIP_REPAIR_TIE_FANOUT) } {
115115
# This needs to come before any call to remove_buffers. You could have one
116116
# tie driving multiple buffers that drive multiple outputs.
117117
# Repair tie lo fanout
@@ -134,7 +134,7 @@ if { [env_var_exists_and_non_empty SWAP_ARITH_OPERATORS] } {
134134
replace_arith_modules
135135
}
136136

137-
if { [env_var_equals REMOVE_ABC_BUFFERS 1] } {
137+
if { $::env(REMOVE_ABC_BUFFERS) } {
138138
# remove buffers inserted by yosys/abc
139139
remove_buffers
140140
} else {

flow/scripts/global_place.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if { $::env(GPL_TIMING_DRIVEN) } {
1414
# to not buffer IO ports, set environment variable
1515
# DONT_BUFFER_PORT = 1
1616
if { ![env_var_exists_and_non_empty FOOTPRINT] } {
17-
if { ![env_var_equals DONT_BUFFER_PORTS 1] } {
17+
if { !$::env(DONT_BUFFER_PORTS) } {
1818
puts "Perform port buffering..."
1919
buffer_ports
2020
}
@@ -52,7 +52,7 @@ if { $result != 0 } {
5252

5353
estimate_parasitics -placement
5454

55-
if { [env_var_equals CLUSTER_FLOPS 1] } {
55+
if { $::env(CLUSTER_FLOPS) } {
5656
cluster_flops
5757
estimate_parasitics -placement
5858
}

flow/scripts/global_route.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ proc global_route_helper { } {
9191
-congestion_report_file $::env(REPORTS_DIR)/congestion_post_recover_power.rpt
9292

9393
if {
94-
![env_var_equals SKIP_ANTENNA_REPAIR 1] &&
94+
!$::env(SKIP_ANTENNA_REPAIR) &&
9595
[env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_GRT]
9696
} {
9797
puts "Repair antennas..."

flow/scripts/open.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ if { [ord::openroad_gui_compiled] } {
6262
"OpenROAD - $::env(PLATFORM)/$::env(DESIGN_NICKNAME)/$::env(FLOW_VARIANT) - ${db_basename}"
6363
}
6464

65-
if { [env_var_equals GUI_TIMING 1] } {
65+
if { $::env(GUI_TIMING) } {
6666
puts "GUI_TIMING=1 reading timing, takes a little while for large designs..."
6767
read_timing $input_file
6868
if { [gui::enabled] } {

flow/scripts/report_metrics.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ proc report_puts { out } {
77
}
88

99
proc report_metrics { stage when { include_erc true } { include_clock_skew true } } {
10-
if { [env_var_equals SKIP_REPORT_METRICS 1] } {
10+
if { $::env(SKIP_REPORT_METRICS) } {
1111
return
1212
}
1313
puts "Report metrics stage $stage, $when..."

0 commit comments

Comments
 (0)