Merge pull request #3084 from Pinata-Consulting/open-logging

open: better logging

Author: maliberty

flow/scripts/open.tcl

@@ -41,7 +41,7 @@ proc read_timing {input_file} {
   if {$design_stage >= 6 && [file exist $::env(RESULTS_DIR)/6_final.spef]} {
     log_cmd read_spef $::env(RESULTS_DIR)/6_final.spef
   } elseif {$design_stage >= 5} {
-    if { [grt::have_routes] } {
+    if { [log_cmd grt::have_routes] } {
       log_cmd estimate_parasitics -global_routing
     } else {
       puts "No global routing results available, skipping estimate_parasitics"
@@ -51,10 +51,8 @@ proc read_timing {input_file} {
     log_cmd estimate_parasitics -placement
   }
 
-  puts -nonewline "Populating timing paths..."
   # Warm up OpenSTA, so clicking on timing related buttons reacts faster
-  set _tmp [find_timing_paths]
-  puts "OK"
+  set _tmp [log_cmd find_timing_paths]
 }
 
 if {[ord::openroad_gui_compiled]} {

flow/scripts/util.tcl

@@ -3,13 +3,14 @@ proc log_cmd {cmd args} {
   set log_cmd "$cmd[join [lmap arg $args {format " %s" [expr {[string match {* *} $arg] ? "\"$arg\"" : "$arg"}]}] ""]"
   puts $log_cmd
   set start [clock seconds]
-  uplevel 1 [list $cmd {*}$args]
+  set result [uplevel 1 [list $cmd {*}$args]]
   set time [expr {[clock seconds] - $start}]
   if {$time >= 5} {
     # Ideally we'd use a single line, but the command can output text
     # and we don't want to mix it with the log, so output the time it took afterwards.
     puts "Took $time seconds: $log_cmd"
   }
+  return $result
 }
 
 proc fast_route {} {