scripts: use env_var_exists_and_non_empty for consistency and fewer surprises

Signed-off-by: Øyvind Harboe <[email protected]>

Author: oharboe

flow/scripts/cts.tcl

@@ -94,7 +94,7 @@ if {[info exists ::env(SKIP_CTS_REPAIR_TIMING)] == 0 || $::env(SKIP_CTS_REPAIR_T
 
 report_metrics 4 "cts final"
 
-if { [info exists ::env(POST_CTS_TCL)] } {
+if { [env_var_exists_and_non_empty POST_CTS_TCL] } {
   source $::env(POST_CTS_TCL)
 }
 

flow/scripts/detail_route.tcl

@@ -79,7 +79,7 @@ if {![info exist ::env(SKIP_ANTENNA_REPAIR_POST_DRT)]} {
   }
 }
 
-if { [info exists ::env(POST_DETAIL_ROUTE_TCL)] } {
+if { [env_var_exists_and_non_empty POST_DETAIL_ROUTE_TCL] } {
   source $::env(POST_DETAIL_ROUTE_TCL)
 }
 

flow/scripts/global_place_skip_io.tcl

@@ -2,7 +2,7 @@ source $::env(SCRIPTS_DIR)/load.tcl
 load_design 2_floorplan.odb 2_floorplan.sdc
 
 
-if { [info exists ::env(FLOORPLAN_DEF)] } {
+if { [env_var_exists_and_non_empty FLOORPLAN_DEF] } {
   puts "FLOORPLAN_DEF is set. Skipping global placement without IOs"
 } else {
   source $::env(SCRIPTS_DIR)/set_place_density.tcl

flow/scripts/io_placement_util.tcl

@@ -1,7 +1,7 @@
-if {[info exists ::env(FLOORPLAN_DEF)]} {
+if {[env_var_exists_and_non_empty FLOORPLAN_DEF]} {
     puts "Skipping IO placement as DEF file was used to initialize floorplan."
 } else {
-  if {[info exists ::env(IO_CONSTRAINTS)]} {
+  if {[env_var_exists_and_non_empty IO_CONSTRAINTS]} {
     source $::env(IO_CONSTRAINTS)
   }
   set args [list -hor_layer $::env(IO_PLACER_H) \

flow/scripts/macro_place_util.tcl

@@ -17,7 +17,7 @@ proc find_macros {} {
 if {[find_macros] != ""} {
 # If wrappers defined replace macros with their wrapped version
 # # ----------------------------------------------------------------------------
-  if {[info exists ::env(MACRO_WRAPPERS)]} {
+  if {[env_var_exists_and_non_empty MACRO_WRAPPERS]} {
     source $::env(MACRO_WRAPPERS)
 
     set wrapped_macros [dict keys [dict get $wrapper around]]
@@ -40,14 +40,14 @@ if {[find_macros] != ""} {
   set blockage_width [expr max($halo_max, $channel_max/2)]
 
 
-  if {[info exists ::env(MACRO_BLOCKAGE_HALO)]} {
+  if {[env_var_exists_and_non_empty MACRO_BLOCKAGE_HALO]} {
     set blockage_width $::env(MACRO_BLOCKAGE_HALO)
   }
 
-  if {[info exists ::env(MACRO_PLACEMENT_TCL)]} {
+  if {[env_var_exists_and_non_empty MACRO_PLACEMENT_TCL]} {
     source $::env(MACRO_PLACEMENT_TCL)
     puts "Using manual macro placement file $::env(MACRO_PLACEMENT_TCL)"
-  } elseif {[info exists ::env(MACRO_PLACEMENT)]} {
+  } elseif {[env_var_exists_and_non_empty MACRO_PLACEMENT]} {
     source $::env(SCRIPTS_DIR)/read_macro_placement.tcl
     puts "Using manual macro placement file $::env(MACRO_PLACEMENT)"
     read_macro_placement $::env(MACRO_PLACEMENT)

flow/scripts/read_liberty.tcl

@@ -6,7 +6,7 @@ if {[info exists ::env(PLATFORM)] && $::env(PLATFORM) == "asap7"} {
 }
 
 #Read Liberty
-if {[info exists ::env(CORNERS)]} {
+if {[env_var_exists_and_non_empty CORNERS]} {
   # corners
   define_corners {*}$::env(CORNERS)
   foreach corner $::env(CORNERS) {

flow/scripts/report_metrics.tcl

@@ -213,7 +213,7 @@ proc report_metrics { stage when {include_erc true} {include_clock_skew true} }
   report_puts "\n=========================================================================="
   report_puts "$when report_power"
   report_puts "--------------------------------------------------------------------------"
-  if {[info exists ::env(CORNERS)]} {
+  if {[env_var_exists_and_non_empty CORNERS]} {
     foreach corner $::env(CORNERS) {
       report_puts "Corner: $corner"
       report_power -corner $corner >> $filename

flow/scripts/resize.tcl

@@ -13,7 +13,7 @@ set_dont_use $::env(DONT_USE_CELLS)
 # by default, IO ports will be buffered
 # to not buffer IO ports, set environment variable
 # DONT_BUFFER_PORT = 1
-if { ![info exists ::env(FOOTPRINT)] } {
+if { ![env_var_exists_and_non_empty FOOTPRINT] } {
   if { ![info exists ::env(DONT_BUFFER_PORTS)] || $::env(DONT_BUFFER_PORTS) == 0 } {
     puts "Perform port buffering..."
     buffer_ports