Skip to content

Commit bf23475

Browse files
committed
makefile: fix post global route error propagation in bazel-orfs
The Makefile should just handle dependencies, no flow logic. Consistency here reduces surprises when updating and reasoning about the code. Signed-off-by: Øyvind Harboe <[email protected]>
1 parent f050ee4 commit bf23475

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

flow/Makefile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -853,13 +853,7 @@ $(eval $(call do-step,5_1_grt,$(RESULTS_DIR)/4_cts.odb $(FASTROUTE_TCL) $(PRE_GL
853853
#-------------------------------------------------------------------------------
854854
$(eval $(call do-step,5_2_route,$(RESULTS_DIR)/5_1_grt.odb,detail_route))
855855

856-
# SEP 3: Filler cell insertion
857-
# ------------------------------------------------------------------------------
858-
ifeq ($(FILL_CELLS),)
859-
$(eval $(call do-copy,5_3_fillcell,5_2_route.odb))
860-
else
861856
$(eval $(call do-step,5_3_fillcell,$(RESULTS_DIR)/5_2_route.odb,fillcell))
862-
endif
863857

864858
$(eval $(call do-copy,5_route,5_3_fillcell.odb))
865859

flow/scripts/fillcell.tcl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ if {[expr [file exists $::env(REPORTS_DIR)/congestion.rpt] && \
77
source $::env(SCRIPTS_DIR)/load.tcl
88
load_design 5_2_route.odb 4_cts.sdc
99

10-
set_propagated_clock [all_clocks]
10+
if {[env_var_exists_and_non_empty FILL_CELLS]} {
11+
set_propagated_clock [all_clocks]
1112

12-
filler_placement $::env(FILL_CELLS)
13-
check_placement
13+
filler_placement $::env(FILL_CELLS)
14+
check_placement
15+
}
1416

1517
write_db $::env(RESULTS_DIR)/5_3_fillcell.odb

0 commit comments

Comments
 (0)