make: check if binaries are valid before continuing

The current logic in variables.mk results in OPENROAD_EXE and YOSYS_EXE
to always be set to something, either the absolute path to tools/install
or the value from the parent env. With this behavior, when calling make
versions.txt the if statements are always true and the "not available"
is never printed to the versions.txt file. If the bins are not valid it
just prints an empty string.

Before this change, calling make versions.txt would fail silently ($? == 0)
and other make commands would fail when trying to run openroad or yosys.

After this change, calling any make command without having a valid
openroad or yosys binary will fail with an error message, which is the
same behaviour already implemented for klayout.

Signed-off-by: Vitor Bandeira <[email protected]>

Author: vvbandeira

flow/Makefile

@@ -184,9 +184,9 @@ $(foreach block,$(BLOCKS),$(eval $(WORK_HOME)/results/$(PLATFORM)/$(DESIGN_NICKN
 .PHONY: versions.txt
 versions.txt:
 	mkdir -p $(OBJECTS_DIR)
-	@echo "yosys $(if $(YOSYS_EXE),$(shell $(YOSYS_EXE) -V 2>&1),not available)" > $(OBJECTS_DIR)/$@
-	@echo "openroad $(if $(OPENROAD_EXE),$(shell $(OPENROAD_EXE) -version 2>&1),not available)" >> $(OBJECTS_DIR)/$@
-	@echo "klayout $(if $(KLAYOUT_CMD),$(shell $(KLAYOUT_CMD) -zz -v 2>&1),not available)" >> $(OBJECTS_DIR)/$@
+	@echo "yosys $(shell $(YOSYS_EXE) -V 2>&1)" > $(OBJECTS_DIR)/$@
+	@echo "openroad $(shell $(OPENROAD_EXE) -version 2>&1)" >> $(OBJECTS_DIR)/$@
+	@echo "klayout $(shell $(KLAYOUT_CMD) -zz -v 2>&1)" >> $(OBJECTS_DIR)/$@
 
 # Pre-process libraries
 # ==============================================================================

flow/scripts/variables.mk

@@ -97,6 +97,11 @@ else
   export OPENSTA_EXE ?= $(abspath $(FLOW_HOME)/../tools/install/OpenROAD/bin/sta)
 endif
 
+OPENROAD_IS_VALID := $(if $(OPENROAD_EXE),$(shell test -x $(OPENROAD_EXE) && echo "true"),)
+ifneq ($(strip $(OPENROAD_IS_VALID)),true)
+  $(error OPENROAD_EXE is set to '$(OPENROAD_EXE)', but it is either not found or not executable.)
+endif
+
 export OPENROAD_ARGS = -no_init -threads $(NUM_CORES) $(OR_ARGS)
 export OPENROAD_CMD = $(OPENROAD_EXE) -exit $(OPENROAD_ARGS)
 export OPENROAD_NO_EXIT_CMD = $(OPENROAD_EXE) $(OPENROAD_ARGS)
@@ -109,6 +114,11 @@ else
 endif
 export YOSYS_EXE
 
+YOSYS_IS_VALID := $(if $(YOSYS_EXE),$(shell test -x $(YOSYS_EXE) && echo "true"),)
+ifneq ($(strip $(YOSYS_IS_VALID)),true)
+  $(error YOSYS_EXE is set to '$(YOSYS_EXE)', but it is either not found or not executable.)
+endif
+
 # Use locally installed and built klayout if it exists, otherwise use klayout in path
 KLAYOUT_DIR = $(abspath $(FLOW_HOME)/../tools/install/klayout/)
 KLAYOUT_BIN_FROM_DIR = $(KLAYOUT_DIR)/klayout