fix readability-container-size-empty

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/cut/src/blif.cpp

@@ -172,13 +172,13 @@ bool Blif::writeBlif(const char* file_name, bool write_arrival_requireds)
                     && (expr->op() == sta::FuncExpr::op_zero
                         || expr->op() == sta::FuncExpr::op_one)) {
                   if (expr->op() == sta::FuncExpr::op_zero) {
-                    if (!const0.size()) {
+                    if (const0.empty()) {
                       const0_cell_ = port_->libertyCell()->name();
                       const0_cell_port_ = port_->name();
                     }
                     const0.insert(netName);
                   } else {
-                    if (!const1.size()) {
+                    if (const1.empty()) {
                       const1_cell_ = port_->libertyCell()->name();
                       const1_cell_port_ = port_->name();
                     }
@@ -291,7 +291,7 @@ bool Blif::writeBlif(const char* file_name, bool write_arrival_requireds)
   }
   f << "\n";
 
-  if (clocks.size() > 0) {
+  if (!clocks.empty()) {
     f << ".clock";
     for (auto& clock : clocks) {
       f << " " << clock;
@@ -420,7 +420,7 @@ bool Blif::readBlif(const char* file_name, odb::dbBlock* block)
     for (auto iterm : iterms) {
       auto net = iterm->getNet();
       iterm->disconnect();
-      if (net && net->getITerms().size() == 0 && net->getBTerms().size() == 0) {
+      if (net && net->getITerms().empty() && net->getBTerms().empty()) {
         odb::dbNet::destroy(net);
       }
     }
@@ -447,7 +447,7 @@ bool Blif::readBlif(const char* file_name, odb::dbBlock* block)
 
     if (master == nullptr
         && (masterName == "_const0_" || masterName == "_const1_")) {
-      if (connections.size() < 1) {
+      if (connections.empty()) {
         logger_->info(CUT,
                       9,
                       "Const driver {} doesn't have any connected nets.",
@@ -566,7 +566,7 @@ bool Blif::readBlif(const char* file_name, odb::dbBlock* block)
         }
       }
 
-      if (mtermName == "") {
+      if (mtermName.empty()) {
         logger_->info(CUT,
                       13,
                       "Could not connect instance of cell type {} to {} net "

src/dbSta/src/dbNetwork.cc

@@ -4215,7 +4215,7 @@ dbModNet* dbNetwork::findModNetForPin(const Pin* drvr_pin)
 
 bool dbNetwork::hasHierarchicalElements() const
 {
-  if (block()->getModNets().size() != 0) {
+  if (!block()->getModNets().empty()) {
     return true;
   }
   return false;

src/grt/src/fastroute/src/FastRoute.cpp

@@ -2125,7 +2125,7 @@ void FastRouteCore::setSttInputFilename(const char* file_name)
 }
 bool FastRouteCore::hasSaveSttInput()
 {
-  return (debug_->sttInputFileName != "");
+  return !debug_->sttInputFileName.empty();
 }
 std::string FastRouteCore::getSttInputFileName()
 {

src/gui/src/gui.cpp

@@ -569,7 +569,7 @@ bool Gui::filterSelectionProperties(const Descriptor::Properties& properties,
       if (auto props_selected_set
           = std::any_cast<SelectionSet>(&property.value)) {
         if (Descriptor::Property::toString(value) == "CONNECTED"
-            && (*props_selected_set).size() != 0) {
+            && !props_selected_set->empty()) {
           return true;
         }
         for (const auto& selected : *props_selected_set) {

src/mpl/src/clusterEngine.cpp

@@ -1336,7 +1336,7 @@ void ClusteringEngine::breakCluster(Cluster* parent)
     odb::dbModule* module = parent->getDbModules().front();
     // Flat module that will be partitioned with TritonPart when updating
     // the subtree later on.
-    if (module->getChildren().size() == 0) {
+    if (module->getChildren().empty()) {
       if (parent == tree_->root.get()) {
         createFlatCluster(module, parent);
       } else {

src/odb/src/defout/defout_impl.cpp

@@ -358,7 +358,7 @@ void DefOut::Impl::writeVias(dbBlock* block)
 {
   dbSet<dbVia> vias = block->getVias();
 
-  if (vias.size() == 0) {
+  if (vias.empty()) {
     return;
   }
 
@@ -694,7 +694,7 @@ void DefOut::Impl::writeBTerms(dbBlock* block)
 {
   dbSet<dbBTerm> bterms = block->getBTerms();
 
-  if (bterms.size() == 0) {
+  if (bterms.empty()) {
     return;
   }
 
@@ -914,7 +914,7 @@ void DefOut::Impl::writeBTerm(dbBTerm* bterm)
   if (net) {
     dbSet<dbBPin> bpins = bterm->getBPins();
 
-    if (bpins.size() != 0) {
+    if (!bpins.empty()) {
       int cnt = 0;
 
       for (dbBPin* bpin : bpins) {

src/odb/test/cpp/Test3DBloxChecker.cpp

@@ -72,7 +72,7 @@ TEST_F(CheckerFixture, test_overlapping_chips)
   auto markers = overlapping_category->getMarkers();
   EXPECT_EQ(markers.size(), 1);
 
-  if (markers.size() > 0) {
+  if (!markers.empty()) {
     auto marker = *markers.begin();
     auto sources = marker->getSources();
     EXPECT_EQ(sources.size(), 2);
@@ -127,7 +127,7 @@ TEST_F(CheckerFixture, test_floating_chips)
   auto markers = floating_category->getMarkers();
   EXPECT_EQ(markers.size(), 1);
 
-  if (markers.size() > 0) {
+  if (!markers.empty()) {
     auto marker = *markers.begin();
     auto sources = marker->getSources();
     EXPECT_EQ(sources.size(), 1);

src/par/src/ArtNetSpec.cpp

@@ -337,7 +337,7 @@ void PartitionMgr::getRents(float& Rratio, float& p, float& q, float& avgK)
     flag = partitionCluster(triton_part, modMgr, cv);
   }
 
-  if (block->getInsts().size() >= 1 && block->getBTerms().size() >= 1) {
+  if (!block->getInsts().empty() && !block->getBTerms().empty()) {
     auto m = std::make_shared<Module>(modMgr.getNumModules());
     m->setAvgK(avgK);
     m->setAvgInsts(block->getInsts().size());

src/rcx/src/extSolverGen.cpp

@@ -650,7 +650,7 @@ bool extSolverGen::getMultipliers(const char* input, std::vector<double>& table)
     double v = atof(word.c_str());
     table.push_back(v);
   }
-  return table.size() > 0;
+  return !table.empty();
 }
 bool extSolverGen::setWidthSpaceMultipliers(const char* w_list,
                                             const char* s_list)

src/rmp/src/Restructure.cpp

@@ -127,7 +127,7 @@ void Restructure::run(char* liberty_file_name,
 
   getBlob(max_depth);
 
-  if (path_insts_.size()) {
+  if (!path_insts_.empty()) {
     runABC();
 
     postABC(worst_slack);
@@ -143,7 +143,7 @@ void Restructure::getBlob(unsigned max_depth)
   sta::PinSet ends(open_sta_->getDbNetwork());
 
   getEndPoints(ends, is_area_mode_, max_depth);
-  if (ends.size()) {
+  if (!ends.empty()) {
     sta::PinSet boundary_points = !is_area_mode_
                                       ? resizer_->findFanins(ends)
                                       : resizer_->findFaninFanouts(ends);
@@ -216,7 +216,7 @@ void Restructure::runABC()
 
     const std::string abc_script_file
         = prefix + std::to_string(curr_mode_idx) + "ord_abc_script.tcl";
-    if (logfile_ == "") {
+    if (logfile_.empty()) {
       logfile_ = prefix + "abc.log";
     }
 
@@ -395,7 +395,7 @@ int Restructure::countConsts(odb::dbBlock* top_block)
 
 void Restructure::removeConstCells()
 {
-  if (!hicell_.size() || !locell_.size()) {
+  if (hicell_.empty() || locell_.empty()) {
     return;
   }
 
@@ -699,7 +699,7 @@ bool Restructure::readAbcLog(std::string abc_file_name,
   if (level.size() > 1) {
     level_gain = level[0] - level[level.size() - 1];
   }
-  if (delay.size() > 0) {
+  if (!delay.empty()) {
     final_delay = delay[delay.size() - 1];  // last value in file
   }
   return status;