Update clang-tidy to OpenROAD clang-tidy-review and stole hzeller's clang tidy setup

Signed-off-by: Ethan Mahintorabi <[email protected]>

Author: QuantamHD

.clang-tidy

@@ -1,13 +1,59 @@
+
 Checks: >
-  -*,
-  performance-*,
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  -clang-analyzer-optin.performance.Padding,
+  abseil-*,
+  -abseil-no-namespace,
   readability-*,
+  -readability-identifier-naming
+  -readability-braces-around-statements,
+  -readability-convert-member-functions-to-static,
+  -readability-function-cognitive-complexity,
+  -readability-identifier-length,
+  -readability-implicit-bool-conversion,
+  -readability-isolate-declaration,
+  -readability-magic-numbers,
+  -readability-make-member-function-const,
+  -readability-named-parameter,
+  -readability-qualified-auto,
+  -readability-redundant-access-specifiers,
+  -readability-simplify-boolean-expr,
+  -readability-static-definition-in-anonymous-namespace,
+  -readability-uppercase-literal-suffix,
+  -readability-use-anyofallof,
+  google-*,
+  -google-readability-avoid-underscore-in-googletest-name,
+  -google-readability-casting,
+  -google-readability-todo,
+  performance-*,
   bugprone-*,
-  clang-analyzer-*,
-  cppcoreguidelines-*,
-  misc-*,
+  -bugprone-branch-clone,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-exception-escape,
+  -bugprone-macro-parentheses,
+  -bugprone-move-forwarding-reference,
+  -bugprone-narrowing-conversions,
+  -bugprone-suspicious-missing-comma,
   modernize-*,
-  -readability-identifier-naming
+  -modernize-avoid-bind,
+  -modernize-avoid-c-arrays,
+  -modernize-concat-nested-namespaces,
+  -modernize-pass-by-value,
+  -modernize-raw-string-literal,
+  -modernize-return-braced-init-list,
+  -modernize-use-auto,
+  -modernize-use-nodiscard,
+  -modernize-use-trailing-return-type,
+  -modernize-use-transparent-functors,
+  misc-*,
+  -misc-const-correctness,
+  -misc-no-recursion,
+  -misc-non-private-member-variables-in-classes,
+  -misc-redundant-expression,
+  -misc-unused-parameters,
 
 # Not currently handling identifier naming
 # WarningsAsErrors: "*"

.github/workflows/github-actions-clang-tidy.yml

@@ -11,7 +11,7 @@ jobs:
         with:
           submodules: 'recursive'
       - name: ClangTidy Gen
-        uses: QuantamHD/[email protected].2
+        uses: The-OpenROAD-Project/[email protected].3
         with:
           build_dir: './build'
           cmake_command: cmake . -B build