gpl: address clang-tidy suggestions

Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>

Author: gudeh

src/gpl/src/graphics.cpp

@@ -3,6 +3,8 @@
 
 #include "graphics.h"
 
+#include <spdlog/fmt/bundled/format.h>
+
 #include <algorithm>
 #include <cmath>
 #include <cstdint>
@@ -19,6 +21,7 @@
 #include "nesterovPlace.h"
 #include "odb/db.h"
 #include "placerBase.h"
+#include "point.h"
 #include "utl/Logger.h"
 
 namespace gpl {
@@ -391,8 +394,8 @@ void Graphics::drawNesterov(gui::Painter& painter)
     const float densityPenalty = nbVec_[nb_index]->getDensityPenalty();
     const float density_magnitude = std::hypot(densityPenalty * densityGrad.x,
                                                densityPenalty * densityGrad.y);
-    const float overall_x = wlGrad.x + densityPenalty * densityGrad.x;
-    const float overall_y = wlGrad.y + densityPenalty * densityGrad.y;
+    const float overall_x = wlGrad.x + (densityPenalty * densityGrad.x);
+    const float overall_y = wlGrad.y + (densityPenalty * densityGrad.y);
     const float overall_magnitude = std::hypot(overall_x, overall_y);
     const float max_magnitude
         = std::max({wl_magnitude, density_magnitude, overall_magnitude});

src/gpl/src/nesterovBase.cpp

@@ -1981,8 +1981,8 @@ void NesterovBase::initFillerGCells()
 
     // place filler cells on random coordi and
     // set size as avgDx and avgDy
-    GCell filler_gcell(randX % region_dx + region_lx,
-                       randY % region_dy + region_ly,
+    GCell filler_gcell(((randX % region_dx) + region_lx),
+                       ((randY % region_dy) + region_ly),
                        fillerDx_,
                        fillerDy_);
 

src/gpl/src/placerBase.cpp

@@ -1126,7 +1126,7 @@ void PlacerBase::initInstsForUnusableSites()
 
       for (int i = pairX.first; i < pairX.second; i++) {
         for (int j = pairY.first; j < pairY.second; j++) {
-          siteGrid[j * siteCountX + i] = Row;
+          siteGrid[(j * siteCountX) + i] = Row;
         }
       }
     }
@@ -1157,7 +1157,7 @@ void PlacerBase::initInstsForUnusableSites()
     for (int j = pairY.first; j < pairY.second; j++) {
       for (int i = pairX.first; i < pairX.second; i++) {
         if (cells == 0 || filled / (float) cells <= filler_density) {
-          siteGrid[j * siteCountX + i] = Blocked;
+          siteGrid[(j * siteCountX) + i] = Blocked;
           debugPrint(log_,
                      GPL,
                      "dummies",
@@ -1201,7 +1201,7 @@ void PlacerBase::initInstsForUnusableSites()
         inst->ly(), inst->uy(), die_.coreLy(), siteSizeY_, 0, siteCountY);
     for (int i = pairX.first; i < pairX.second; i++) {
       for (int j = pairY.first; j < pairY.second; j++) {
-        siteGrid[j * siteCountX + i] = FixedInst;
+        siteGrid[(j * siteCountX) + i] = FixedInst;
         debugPrint(log_,
                    GPL,
                    "dummies",
@@ -1220,17 +1220,17 @@ void PlacerBase::initInstsForUnusableSites()
   //
   for (int j = 0; j < siteCountY; j++) {
     for (int i = 0; i < siteCountX; i++) {
-      if (siteGrid[j * siteCountX + i] == Blocked) {
+      if (siteGrid[(j * siteCountX) + i] == Blocked) {
         int startX = i;
         // find end points
-        while (i < siteCountX && siteGrid[j * siteCountX + i] == Blocked) {
+        while (i < siteCountX && siteGrid[(j * siteCountX) + i] == Blocked) {
           i++;
         }
         int endX = i;
-        Instance dummy_gcell(die_.coreLx() + siteSizeX_ * startX,
-                             die_.coreLy() + siteSizeY_ * j,
-                             die_.coreLx() + siteSizeX_ * endX,
-                             die_.coreLy() + siteSizeY_ * (j + 1));
+        Instance dummy_gcell(die_.coreLx() + (siteSizeX_ * startX),
+                             die_.coreLy() + (siteSizeY_ * j),
+                             die_.coreLx() + (siteSizeX_ * endX),
+                             die_.coreLy() + (siteSizeY_ * (j + 1)));
         instStor_.push_back(dummy_gcell);
       }
     }