Merge pull request #8179 from Pinata-Consulting/power-per-instance-reporting

Power per instance with .vcd test

Author: maliberty

test/orfs/mock-array/BUILD

@@ -367,46 +367,52 @@ SPEFS_AND_NETLISTS = [
     ]
 ]
 
-orfs_run(
-    name = "MockArray_power",
+POWER_TESTS = [
+    "power",
+    "power_instances",
+]
+
+[orfs_run(
+    name = "MockArray_{name}".format(name = name),
     src = ":MockArray_{stage}".format(stage = POWER_STAGE_NAME),
     outs = [
-        "power.txt",
+        "{name}.txt".format(name = name),
     ],
     arguments = {
-        "OUTPUT": "$(location :power.txt)",
+        "OUTPUT": "$(location :{name}.txt)".format(name = name),
         "VCD_STIMULI": "$(location :vcd)",
         "OPENROAD_EXE": "$(location //src/sta:opensta)",
         "POWER_STAGE_NAME": POWER_STAGE_NAME,
         "POWER_STAGE_STEM": POWER_STAGE_STEM,
+        "LOAD_POWER_TCL": "$(location :load_power.tcl)",
     },
     data = [
                # FIXME this is a workaround to ensure that the OpenSTA runfiles are available
                ":opensta_runfiles",
                ":vcd",
+               ":load_power.tcl",
            ] + ["{macro}_{stage}".format(
                macro = macro,
                stage = POWER_STAGE_NAME,
            ) for macro in MACROS] +
            (["{macro}_parasitics".format(macro = macro) for macro in MACROS] if POWER_STAGE_NAME != "final" else []),
-    script = ":power.tcl",
+    script = ":{name}.tcl".format(name = name),
     tags = ["manual"],
     tools = ["//src/sta:opensta"],
     visibility = ["//visibility:public"],
-)
+) for name in POWER_TESTS]
 
-# FIXME an orfs_run_test() rule would be nicer
-sh_test(
-    name = "MockArray_power_test",
+[sh_test(
+    name = "MockArray_{name}_test".format(name = name),
     srcs = ["ok.sh"],
     args = [
-        "$(location :MockArray_power)",
+        "$(location :MockArray_{name})".format(name = name),
     ],
     data = [
-        ":MockArray_power",
+        ":MockArray_{name}".format(name = name),
     ],
-    tags = ["manual"],
-)
+    tags = ["manual"] if name == "power_instances" else [],
+) for name in POWER_TESTS]
 
 # FIXME why is this needed to ensure that cfg=exec of OpenSTA has runfiles?
 genrule(

test/orfs/mock-array/load_power.tcl

@@ -0,0 +1,25 @@
+source $::env(SCRIPTS_DIR)/util.tcl
+
+foreach libFile $::env(LIB_FILES) {
+  if { [lsearch -exact $::env(ADDITIONAL_LIBS) $libFile] == -1 } {
+    read_liberty $libFile
+  }
+}
+
+log_cmd read_verilog $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).v
+log_cmd read_verilog $::env(RESULTS_DIR)/../../Element/base/$::env(POWER_STAGE_STEM).v
+log_cmd read_verilog $::env(PLATFORM_DIR)/verilog/stdcell/empty.v
+log_cmd link_design MockArray
+
+log_cmd read_sdc $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).sdc
+log_cmd read_spef $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).spef
+puts "read_spef for ces_*_* macros"
+for { set x 0 } { $x < 8 } { incr x } {
+  for { set y 0 } { $y < 8 } { incr y } {
+    log_cmd read_spef -path ces_${x}_${y} \
+      $::env(RESULTS_DIR)/../../Element/base/$::env(POWER_STAGE_STEM).spef
+  }
+}
+
+set vcd_file $::env(VCD_STIMULI)
+log_cmd read_vcd -scope TOP/MockArray $vcd_file

test/orfs/mock-array/power.tcl

@@ -1,25 +1,4 @@
-source $::env(SCRIPTS_DIR)/util.tcl
-
-foreach libFile $::env(LIB_FILES) {
-  if { [lsearch -exact $::env(ADDITIONAL_LIBS) $libFile] == -1 } {
-    read_liberty $libFile
-  }
-}
-
-log_cmd read_verilog $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).v
-log_cmd read_verilog $::env(RESULTS_DIR)/../../Element/base/$::env(POWER_STAGE_STEM).v
-log_cmd read_verilog $::env(PLATFORM_DIR)/verilog/stdcell/empty.v
-log_cmd link_design MockArray
-
-log_cmd read_sdc $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).sdc
-log_cmd read_spef $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).spef
-puts "read_spef for ces_*_* macros"
-for { set x 0 } { $x < 8 } { incr x } {
-  for { set y 0 } { $y < 8 } { incr y } {
-    log_cmd read_spef -path ces_${x}_${y} \
-      $::env(RESULTS_DIR)/../../Element/base/$::env(POWER_STAGE_STEM).spef
-  }
-}
+source $::env(LOAD_POWER_TCL)
 
 # OpenSTA reports reg2reg paths inside macros,
 # whereas these paths are hidden to OpenROAD that
@@ -28,9 +7,6 @@ log_cmd report_checks
 
 log_cmd report_power
 
-set vcd_file $::env(VCD_STIMULI)
-log_cmd read_vcd -scope TOP/MockArray $vcd_file
-
 set fp [open $::env(RESULTS_DIR)/activity.tcl w]
 set pins [get_pins -hierarchical *]
 set clock_period [expr [get_property [get_clocks] period] * 1e-12]

test/orfs/mock-array/power_instances.tcl

@@ -0,0 +1,13 @@
+source $::env(LOAD_POWER_TCL)
+
+set instances [get_cells ces*/Multiplier*]
+if { [llength $instances] != 64 } {
+  puts "Error: Expected to find 64 Multiplier instances, found [llength $instances]"
+  exit 1
+}
+
+report_power -instances $instances
+
+set f [open $::env(OUTPUT) w]
+puts $f OK
+close $f