pdn: only count pin area once and adjust warning msg in okfile

Signed-off-by: Peter Gadfort <[email protected]>

Author: gadfort

src/pdn/src/grid.cpp

@@ -1698,8 +1698,7 @@ void InstanceGrid::checkSetup() const
 
     if (top != nullptr) {
       const int top_idx = top->getNumber();
-      int64_t overlap_area = 0;
-      int64_t pin_area = 0;
+      std::map<odb::Rect, int64_t> overlap_area;
       for (auto* master_obs : inst_->getMaster()->getObstructions()) {
         auto* obs_layer = master_obs->getTechLayer();
         if (obs_layer == nullptr) {
@@ -1726,16 +1725,21 @@ void InstanceGrid::checkSetup() const
                     inst_->getName());
               } else {
                 const odb::Rect overlap = mobs.intersect(pin);
-                overlap_area += overlap.area();
-                pin_area += pin.area();
+                overlap_area[pin] += overlap.area();
               }
             }
           }
         }
       }
 
-      if (pin_area > 0 && overlap_area != 0) {
-        const float pct = 100 * static_cast<float>(overlap_area) / pin_area;
+      if (!overlap_area.empty()) {
+        int64_t pin_area = 0;
+        int64_t total_overlap = 0;
+        for (const auto& [pin, overlap] : overlap_area) {
+          total_overlap += overlap;
+          pin_area += pin.area();
+        }
+        const float pct = 100 * static_cast<float>(total_overlap) / pin_area;
         getLogger()->warn(
             utl::PDN,
             7,

src/pdn/test/asap7_failed_macro_covered.ok

@@ -6,5 +6,5 @@
 [INFO ODB-0131]     Created 12240 components and 59302 component-terminals.
 [INFO ODB-0132]     Created 2 special nets and 6030 connections.
 [INFO ODB-0133]     Created 9695 nets and 790 connections.
-[ERROR PDN-0006] VSS on M4 are blocked by obstructions on M5 for dmem/dmem0
+[ERROR PDN-0006] VSS on M4 is blocked by obstructions on M5 for dmem/dmem0
 PDN-0006

src/pdn/test/asap7_macro_covered_partial.ok

@@ -6,14 +6,14 @@
 [INFO ODB-0131]     Created 12240 components and 59302 component-terminals.
 [INFO ODB-0132]     Created 2 special nets and 6030 connections.
 [INFO ODB-0133]     Created 9695 nets and 790 connections.
-[WARNING PDN-0007] VSS on M4 are partially blocked (9.8%) by obstructions for dmem/dmem0
-[WARNING PDN-0007] VDD on M4 are partially blocked (9.8%) by obstructions for dmem/dmem0
-[WARNING PDN-0007] VSS on M4 are partially blocked (9.8%) by obstructions for dmem/dmem1
-[WARNING PDN-0007] VDD on M4 are partially blocked (9.8%) by obstructions for dmem/dmem1
-[WARNING PDN-0007] VSS on M4 are partially blocked (9.8%) by obstructions for dmem/dmem2
-[WARNING PDN-0007] VDD on M4 are partially blocked (9.8%) by obstructions for dmem/dmem2
-[WARNING PDN-0007] VSS on M4 are partially blocked (9.8%) by obstructions for dmem/dmem3
-[WARNING PDN-0007] VDD on M4 are partially blocked (9.8%) by obstructions for dmem/dmem3
+[WARNING PDN-0007] VSS on M4 is partially blocked (9.8%) by obstructions for dmem/dmem0
+[WARNING PDN-0007] VDD on M4 is partially blocked (9.8%) by obstructions for dmem/dmem0
+[WARNING PDN-0007] VSS on M4 is partially blocked (9.8%) by obstructions for dmem/dmem1
+[WARNING PDN-0007] VDD on M4 is partially blocked (9.8%) by obstructions for dmem/dmem1
+[WARNING PDN-0007] VSS on M4 is partially blocked (9.8%) by obstructions for dmem/dmem2
+[WARNING PDN-0007] VDD on M4 is partially blocked (9.8%) by obstructions for dmem/dmem2
+[WARNING PDN-0007] VSS on M4 is partially blocked (9.8%) by obstructions for dmem/dmem3
+[WARNING PDN-0007] VDD on M4 is partially blocked (9.8%) by obstructions for dmem/dmem3
 [INFO PDN-0001] Inserting grid: top
 [INFO PDN-0001] Inserting grid: CORE_macro_grid_1 - dmem/dmem0
 [INFO PDN-0001] Inserting grid: CORE_macro_grid_1 - dmem/dmem1