Merge pull request #7920 from gadfort/coverity

pdn/gui: fix a few coverity issues

Author: maliberty

src/gui/src/chartsWidget.h

@@ -95,7 +95,7 @@ class HistogramView : public QChartView
   int computeMaxYSnap(int largest_slack_count);
   int computeFirstDigit(int value, int digits);
 
-  utl::Logger* logger_;
+  utl::Logger* logger_{nullptr};
   STAGuiInterface* sta_{nullptr};
 
   QChart* chart_;

src/gui/src/dbDescriptors.cpp

@@ -1042,7 +1042,7 @@ void DbNetDescriptor::findSourcesAndSinks(
             }
 
             if (!term_targets.empty()) {
-              targets.push_back(term_targets);
+              targets.push_back(std::move(term_targets));
             }
           }
         };
@@ -1057,7 +1057,7 @@ void DbNetDescriptor::findSourcesAndSinks(
               term_targets.emplace(rect, box->getTechLayer());
             }
             if (!term_targets.empty()) {
-              targets.push_back(term_targets);
+              targets.push_back(std::move(term_targets));
             }
           }
         };

src/gui/src/renderThread.cpp

@@ -1707,7 +1707,7 @@ void RenderThread::drawIOPins(Painter& painter,
       } else {
         pin_specs.rect = odb::Rect();
       }
-      pin_text_spec.push_back(pin_specs);
+      pin_text_spec.push_back(std::move(pin_specs));
     }
   }
 

src/gui/src/staGuiInterface.cpp

@@ -1138,7 +1138,7 @@ ConeDepthMapPinSet STAGuiInterface::getFaninCone(const sta::Pin* pin) const
                                   true);  // thru_constants
 
   ConeDepthMapPinSet depth_map;
-  for (auto& [level, pin_list] : getCone(pin, pins, true)) {
+  for (auto& [level, pin_list] : getCone(pin, std::move(pins), true)) {
     depth_map[-level].insert(pin_list.begin(), pin_list.end());
   }
 

src/pdn/src/grid.cpp

@@ -1085,12 +1085,12 @@ void Grid::makeInitialObstructions(odb::dbBlock* block,
     if (box->getTechLayer() == nullptr) {
       for (auto* layer : block->getDb()->getTech()->getLayers()) {
         auto shape = std::make_shared<Shape>(layer, obs_rect, Shape::BLOCK_OBS);
-        obs[layer].push_back(shape);
+        obs[layer].push_back(std::move(shape));
       }
     } else {
       auto shape = std::make_shared<Shape>(
           box->getTechLayer(), obs_rect, Shape::BLOCK_OBS);
-      obs[box->getTechLayer()].push_back(shape);
+      obs[box->getTechLayer()].push_back(std::move(shape));
     }
   }
 
@@ -1148,7 +1148,7 @@ void Grid::makeInitialObstructions(odb::dbBlock* block,
             = std::make_shared<Shape>(layer, geom->getBox(), Shape::BLOCK_OBS);
         shape->generateObstruction();
         shape->setRect(shape->getRect());
-        obs[layer].push_back(shape);
+        obs[layer].push_back(std::move(shape));
       }
     }
   }
@@ -1494,7 +1494,7 @@ ShapeVectorMap InstanceGrid::getInstanceObstructions(
     transform.apply(obs_rect);
     auto shape = std::make_shared<Shape>(layer, obs_rect, Shape::BLOCK_OBS);
 
-    obs[layer].push_back(shape);
+    obs[layer].push_back(std::move(shape));
   }
 
   // generate obstructions based on pins
@@ -1567,15 +1567,15 @@ ShapeVectorMap InstanceGrid::getInstancePins(odb::dbInst* inst)
             auto shape = std::make_shared<Shape>(
                 via_box->getTechLayer(), net, box_rect);
             shape->setShapeType(Shape::FIXED);
-            pins.push_back(shape);
+            pins.push_back(std::move(shape));
           }
         } else {
           odb::Rect box_rect = box->getBox();
           transform.apply(box_rect);
           auto shape
               = std::make_shared<Shape>(box->getTechLayer(), net, box_rect);
           shape->setShapeType(Shape::FIXED);
-          pins.push_back(shape);
+          pins.push_back(std::move(shape));
         }
       }
     }

src/pdn/src/renderer.cpp

@@ -98,7 +98,7 @@ void PDNRenderer::update()
                                    channel.target->getName(),
                                    nets);
 
-        repair_.push_back(channel);
+        repair_.push_back(std::move(channel));
       }
     }
   }

src/pdn/src/shape.cpp

@@ -463,7 +463,7 @@ void Shape::populateMapFromDb(odb::dbNet* net, ShapeVectorMap& map)
         shape->setShapeType(Shape::OBS);
       }
       shape->generateObstruction();
-      map[layer].push_back(shape);
+      map[layer].push_back(std::move(shape));
     }
   }
 }

src/pdn/src/straps.cpp

@@ -2183,7 +2183,7 @@ RepairChannelStraps::findRepairChannels(Grid* grid,
       }
       channel.obs_area = channel.obs_area.intersect(grid_core);
 
-      channels.push_back(channel);
+      channels.push_back(std::move(channel));
     }
   }