incorporated code review feedback

Signed-off-by: LucasYuki <[email protected]>

Author: LucasYuki

src/gui/src/staGui.cpp

@@ -1362,9 +1362,11 @@ std::vector<std::set<const sta::Pin*>> TimingControlsDialog::getThruPins() const
   return pins;
 }
 
-const sta::ClockSet* TimingControlsDialog::getClocks(bool return_null_if_all)
+const sta::ClockSet* TimingControlsDialog::getClocks()
 {
-  if (return_null_if_all && clock_box_->isAllSelected()) {
+  if (clock_box_->isAllSelected()) {
+    // returns nullptr if all clocks are selected,
+    // so the STA doesn't need to filter by clock
     return nullptr;
   }
 

src/gui/src/staGui.h

@@ -410,7 +410,7 @@ class TimingControlsDialog : public QDialog
   std::set<const sta::Pin*> getFromPins() const { return from_->getPins(); }
   std::vector<std::set<const sta::Pin*>> getThruPins() const;
   std::set<const sta::Pin*> getToPins() const { return to_->getPins(); }
-  const sta::ClockSet* getClocks(bool return_null_if_all = true);
+  const sta::ClockSet* getClocks();
 
   const sta::Pin* convertTerm(Gui::Term term) const;