gemini + tidy-review fixes

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/dbSta/test/cpp/TestHconn.cpp

@@ -34,13 +34,13 @@
 namespace odb {
 
 static const std::string prefix("_main/src/dbSta/test/");
+static constexpr bool kDebugMsgs = false;
 
 /*
   Extract the hierarchical information in human readable format.
   Shows the dbNet and dbModNet view of the database.
 */
 
-// NOLINTNEXTLINE(clang-diagnostic-unused-function)
 static void DbStrDebugHierarchy(dbBlock* block, std::stringstream& str_db)
 {
   str_db << fmt::format("Debug: Data base tables for block at {}:\n",
@@ -528,9 +528,11 @@ class TestHconn : public ::tst::Fixture
     inv4_3_op_->connect(op2_net_);
     inv4_4_op_->connect(op3_net_);
 
-    // std::stringstream str_str;
-    //    DbStrDebugHierarchy(block_, str_str);
-    //    printf("The Flat design created %s\n", str_str.str().c_str());
+    if (kDebugMsgs) {
+      std::stringstream str_str;
+      DbStrDebugHierarchy(block_, str_str);
+      printf("The Flat design created %s\n", str_str.str().c_str());
+    }
 
     // Now build the hierarchical "overlay"
     // What we are doing here is adding the modnets which hook up
@@ -646,11 +648,12 @@ class TestHconn : public ::tst::Fixture
     inv4_mod_level2_inst_o3_miterm_->connect(inv4_mod_level2_inst_o3_mnet_);
     inv4_mod_level1_master_o3_port_->connect(inv4_mod_level2_inst_o3_mnet_);
 
-    // Uncomment this to see the full design
-    //    std::stringstream full_design;
-    //    DbStrDebugHierarchy(block_, full_design);
-    //    printf("The  design created (flat and hierarchical) %s\n",
-    //	   full_design.str().c_str());
+    if (kDebugMsgs) {
+      std::stringstream full_design;
+      DbStrDebugHierarchy(block_, full_design);
+      printf("The  design created (flat and hierarchical) %s\n",
+             full_design.str().c_str());
+    }
   }
 
   sta::LibertyLibrary* library_;
@@ -789,9 +792,11 @@ class TestHconn : public ::tst::Fixture
 
 TEST_F(TestHconn, ConnectionMade)
 {
-  //  std::stringstream str_str_initial;
-  //  DbStrDebugHierarchy(block_, str_str_initial);
-  //  printf("The initial design: %s\n", str_str_initial.str().c_str());
+  if (kDebugMsgs) {
+    std::stringstream str_str_initial;
+    DbStrDebugHierarchy(block_, str_str_initial);
+    printf("The initial design: %s\n", str_str_initial.str().c_str());
+  }
 
   // ECO test: get initial state before we start modifying
   // the design. Then at end we undo everything and
@@ -897,10 +902,11 @@ TEST_F(TestHconn, ConnectionMade)
   db_network_->hierarchicalConnect(
       inv1_2_inst_op0, inv4_4_ip_, hier_net_name.c_str());
 
-  // Uncomment this to see the final design
-  //  std::stringstream str_str_final;
-  //  DbStrDebugHierarchy(block_, str_str_final);
-  //  printf("The final design: %s\n", str_str_final.str().c_str());
+  if (kDebugMsgs) {
+    std::stringstream str_str_final;
+    DbStrDebugHierarchy(block_, str_str_final);
+    printf("The final design: %s\n", str_str_final.str().c_str());
+  }
 
   // Example of how to turn on the call backs for all the bterms/iterms
   // used by the sta

src/dst/include/dst/BalancerJobDescription.h

@@ -2,13 +2,17 @@
 // Copyright (c) 2021-2025, The OpenROAD Authors
 
 #pragma once
+
+#include <cstdint>
 #include <string>
 
 #include "boost/serialization/base_object.hpp"
 #include "dst/JobMessage.h"
+
 namespace boost::serialization {
 class access;
 }
+
 namespace dst {
 
 class BalancerJobDescription : public JobDescription
@@ -32,4 +36,5 @@ class BalancerJobDescription : public JobDescription
   }
   friend class boost::serialization::access;
 };
+
 }  // namespace dst

src/dst/include/dst/BroadcastJobDescription.h

@@ -2,11 +2,16 @@
 // Copyright (c) 2022-2025, The OpenROAD Authors
 
 #pragma once
+
+#include <cstdint>
+
 #include "boost/serialization/base_object.hpp"
 #include "dst/JobMessage.h"
+
 namespace boost::serialization {
 class access;
 }
+
 namespace dst {
 
 class BroadcastJobDescription : public JobDescription
@@ -26,4 +31,5 @@ class BroadcastJobDescription : public JobDescription
   }
   friend class boost::serialization::access;
 };
+
 }  // namespace dst

src/dst/include/dst/Distributed.h

@@ -3,6 +3,7 @@
 
 #pragma once
 
+#include <cstdint>
 #include <memory>
 #include <string>
 #include <vector>

src/dst/src/BalancerConnection.cc

@@ -6,6 +6,7 @@
 #include <dst/JobMessage.h>
 
 #include <cstddef>
+#include <cstdint>
 #include <exception>
 #include <memory>
 #include <mutex>

src/dst/src/LoadBalancer.cc

@@ -4,6 +4,7 @@
 #include "LoadBalancer.h"
 
 #include <algorithm>
+#include <cstdint>
 #include <cstring>
 #include <exception>
 #include <limits>

src/dst/src/LoadBalancer.h

@@ -13,6 +13,7 @@
 
 #include "BalancerConnection.h"
 #include "boost/asio.hpp"
+#include "boost/asio/ip/address.hpp"
 #include "boost/asio/thread_pool.hpp"
 #include "boost/thread/thread.hpp"
 

src/dst/test/cpp/TestBalancer.cc

@@ -1,3 +1,4 @@
+#include <cstdint>
 #include <string>
 
 #include "HelperCallBack.h"

src/dst/test/cpp/TestDistributed.cc

@@ -1,3 +1,4 @@
+#include <cstdint>
 #include <string>
 #include <vector>
 

src/odb/src/def/cdef/defrReader.h

@@ -33,6 +33,7 @@
 #ifndef CDEFRREADER_H
 #define CDEFRREADER_H
 
+#include <cstdint>
 #include <cstdio>
 
 #include "defiTypedefs.h"