Merge remote-tracking branch 'origin/master' into pad-corner-check-overlaps

Author: gadfort

.bazelrc

@@ -14,6 +14,7 @@ common --incompatible_disallow_empty_glob
 
 build --cxxopt "-std=c++17"        --host_cxxopt "-std=c++17"
 build --cxxopt "-xc++"             --host_cxxopt "-xc++"
+build --cxxopt "-DBAZEL_BUILD"     --host_cxxopt "-DBAZEL_BUILD"
 
 # Needed for floating point stability in FFT (fft_test will check this).
 # See also https://kristerw.github.io/2021/11/09/fp-contract/

.github/workflows/github-actions-clang-tidy.yml

@@ -17,6 +17,7 @@ jobs:
         uses: The-OpenROAD-Project/clang-tidy-review@master
         id: review
         with:
+          clang_tidy_version: 15
           build_dir: "./build"
           cmake_command: cmake . -B build
           config_file: ".clang-tidy"

Jenkinsfile

@@ -223,11 +223,18 @@ def bazelTest = {
                     timeout(time: 120, unit: 'MINUTES') {
                         def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
                         try {
-                            sh label: 'Bazel Build', script: cmd + ' ...';
-                            sh label: 'Bazel Build', script: 'bazelisk analyze-profile build.profile';
+                            try {
+                                sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
+                            } finally {
+                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                            }
                         } catch (e) {
                             currentBuild.result = 'FAILURE';
-                            sh label: 'Bazel Build (keep_going)', script: cmd + ' --keep_going ...';
+                            try {
+                                sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
+                            } finally {
+                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                            }
                         }
                     }
                 }

MODULE.bazel

@@ -79,7 +79,6 @@ bazel_dep(name = "boost.smart_ptr", version = BOOST_VERSION)
 bazel_dep(name = "boost.spirit", version = BOOST_VERSION)
 bazel_dep(name = "boost.stacktrace", version = BOOST_VERSION)
 bazel_dep(name = "boost.system", version = BOOST_VERSION)
-bazel_dep(name = "boost.test", version = BOOST_VERSION + ".bcr.1")
 bazel_dep(name = "boost.thread", version = BOOST_VERSION + ".bcr.2")
 bazel_dep(name = "boost.tokenizer", version = BOOST_VERSION)
 bazel_dep(name = "boost.unordered", version = BOOST_VERSION)
@@ -104,7 +103,7 @@ git_override(
     remote = "https://github.com/The-OpenROAD-Project/qt_bazel_prebuilts",
 )
 
-bazel_dep(name = "googletest", version = "1.16.0", dev_dependency = True)
+bazel_dep(name = "googletest", version = "1.17.0", dev_dependency = True)
 
 # Dependencies needed by one of the rules_hdl repos. Once they are on
 # BCR, they should depend on their own version.
@@ -154,7 +153,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "da01065203fbcc043c82318b544fbe111053b9d0",
+    commit = "2aa6a9dd3c0006c5358e363fcac9e209c4dccc47",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -163,10 +162,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3872-g66e441c6c",
+    image = "docker.io/openroad/orfs:v3.0-3911-g99312fa58",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "f75321f10023a8bf99b1ed5dfe1dab6351f588eda24f186a66e9145fd9b76fd1",
+    sha256 = "36d3ac23732803c9e47181e167a105c69d4d6927a96782c4a4a27ceca40d8ff8",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -1,6 +1,8 @@
 load("@openroad_rules_python//python:pip.bzl", "compile_pip_requirements")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
+package(features = ["layering_check"])
+
 compile_pip_requirements(
     name = "requirements",
     src = "requirements.in",

bazel/BUILD

@@ -14,6 +14,7 @@
 
 package(
     default_visibility = ["//visibility:private"],
+    features = ["layering_check"],
 )
 
 exports_files(

bazel/openmp/BUILD

@@ -86,7 +86,6 @@ cc_library(
         "runtime/src/ompt-general.cpp",
         "runtime/src/ompt-internal.h",
         "runtime/src/ompt-specific.h",
-        "runtime/src/test-touch.c",
         "runtime/src/z_Linux_asm.S",
         "runtime/src/z_Linux_util.cpp",
     ] + [

bazel/openmp/bundled.BUILD.bazel

@@ -38,6 +38,7 @@
   stdenv,
   overrideSDK,
   git,
+  yaml-cpp,
 }: let
   or-tools' =
     (or-tools.override {
@@ -111,6 +112,7 @@
       cbc
       re2
       gtest
+      yaml-cpp
     ];
 
     nativeBuildInputs = [

default.nix

@@ -359,3 +359,13 @@ This will:
 - launch the GUI opening gui_final gcd
 
 `bazelisk run test/orfs/gcd:gcd_final` run alone would create the `/tmp/gcd` folder and the arguments. The arguments after `--` are forwarded to the `/tmp/gcd/make` script that invokes make with the gcd ORFS project set up in `/tmp/gcd/_main/config.mk`.
+
+## Hacking ORFS with `//test/orfs/gcd:gcd_test` test case
+
+First create a local work folder with all dependencies for the step that you want to work on:
+
+    bazelisk run //test/orfs/gcd:gcd_floorplan_deps /tmp/floorplan
+
+Now run make directly with the `/tmp/floorplan/_main` work folder, but be sure to use the `do-` targets that side-step ORFS make dependency checking:
+
+    make --file ~/OpenROAD-flow-scripts/flow/Makefile --dir /tmp/floorplan/_main DESIGN_CONFIG=config.mk do-floorplan