Skip to content

Commit 20c361c

Browse files
committed
gpl: better names for placerBaseCommon constructor variables
Signed-off-by: Augusto Berndt <[email protected]>
1 parent edfef5a commit 20c361c

File tree

1 file changed

+57
-57
lines changed

1 file changed

+57
-57
lines changed

src/gpl/src/placerBase.cpp

Lines changed: 57 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -755,28 +755,28 @@ void PlacerBaseCommon::init()
755755
dbBlock* block = db_->getChip()->getBlock();
756756

757757
// die-core area update
758-
odb::dbSite* site = nullptr;
758+
odb::dbSite* db_site = nullptr;
759759
for (auto* row : block->getRows()) {
760760
if (row->getSite()->getClass() != odb::dbSiteClass::PAD) {
761-
site = row->getSite();
761+
db_site = row->getSite();
762762
break;
763763
}
764764
}
765-
if (site == nullptr) {
765+
if (db_site == nullptr) {
766766
log_->error(GPL, 305, "Unable to find a site");
767767
}
768-
odb::Rect coreRect = block->getCoreArea();
769-
odb::Rect dieRect = block->getDieArea();
768+
odb::Rect core_rect = block->getCoreArea();
769+
odb::Rect die_rect = block->getDieArea();
770770

771-
if (!dieRect.contains(coreRect)) {
771+
if (!die_rect.contains(core_rect)) {
772772
log_->error(GPL, 118, "core area outside of die.");
773773
}
774774

775-
die_ = Die(dieRect, coreRect);
775+
die_ = Die(die_rect, core_rect);
776776

777777
// siteSize update
778-
siteSizeX_ = site->getWidth();
779-
siteSizeY_ = site->getHeight();
778+
siteSizeX_ = db_site->getWidth();
779+
siteSizeY_ = db_site->getHeight();
780780

781781
log_->info(GPL,
782782
3,
@@ -803,7 +803,7 @@ void PlacerBaseCommon::init()
803803
continue;
804804
}
805805

806-
Instance myInst(db_inst, this, log_);
806+
Instance temp_inst(db_inst, this, log_);
807807
odb::dbBox* inst_bbox = db_inst->getBBox();
808808
if (inst_bbox->getDY() > die_.coreDy()) {
809809
log_->error(GPL,
@@ -821,98 +821,98 @@ void PlacerBaseCommon::init()
821821
// Fixed instaces need to be snapped outwards to the nearest site
822822
// boundary. A partially overlapped site is unusable and this
823823
// is the simplest way to ensure it is counted as fully used.
824-
if (myInst.isFixed()) {
825-
myInst.snapOutward(coreRect.ll(), siteSizeX_, siteSizeY_);
824+
if (temp_inst.isFixed()) {
825+
temp_inst.snapOutward(core_rect.ll(), siteSizeX_, siteSizeY_);
826826
}
827827

828-
instStor_.push_back(myInst);
828+
instStor_.push_back(temp_inst);
829829

830-
if (myInst.dy() > siteSizeY_ * 6) {
831-
macroInstsArea_ += myInst.area();
830+
if (temp_inst.dy() > siteSizeY_ * 6) {
831+
macroInstsArea_ += temp_inst.area();
832832
}
833833
}
834834

835-
for (auto& inst : instStor_) {
836-
instMap_[inst.dbInst()] = &inst;
837-
insts_.push_back(&inst);
835+
for (auto& pb_inst : instStor_) {
836+
instMap_[pb_inst.dbInst()] = &pb_inst;
837+
insts_.push_back(&pb_inst);
838838

839-
if (!inst.isFixed()) {
840-
placeInsts_.push_back(&inst);
839+
if (!pb_inst.isFixed()) {
840+
placeInsts_.push_back(&pb_inst);
841841
}
842842
}
843843

844844
// nets fill
845-
dbSet<dbNet> nets = block->getNets();
846-
netStor_.reserve(nets.size());
847-
for (dbNet* net : nets) {
848-
dbSigType netType = net->getSigType();
845+
dbSet<dbNet> db_nets = block->getNets();
846+
netStor_.reserve(db_nets.size());
847+
for (dbNet* db_net : db_nets) {
848+
dbSigType net_type = db_net->getSigType();
849849

850850
// escape nets with VDD/VSS/reset nets
851-
if (netType == dbSigType::SIGNAL || netType == dbSigType::CLOCK) {
852-
Net myNet(net, pbVars_.skipIoMode);
853-
netStor_.push_back(myNet);
851+
if (net_type == dbSigType::SIGNAL || net_type == dbSigType::CLOCK) {
852+
Net temp_net(db_net, pbVars_.skipIoMode);
853+
netStor_.push_back(temp_net);
854854

855855
// this is safe because of "reserve"
856-
Net* myNetPtr = &netStor_[netStor_.size() - 1];
857-
netMap_[net] = myNetPtr;
858-
859-
for (dbITerm* iTerm : net->getITerms()) {
860-
Pin myPin(iTerm);
861-
myPin.setNet(myNetPtr);
862-
myPin.setInstance(dbToPb(iTerm->getInst()));
863-
pinStor_.push_back(myPin);
856+
Net* temp_net_ptr = &netStor_[netStor_.size() - 1];
857+
netMap_[db_net] = temp_net_ptr;
858+
859+
for (dbITerm* iTerm : db_net->getITerms()) {
860+
Pin temp_pin(iTerm);
861+
temp_pin.setNet(temp_net_ptr);
862+
temp_pin.setInstance(dbToPb(iTerm->getInst()));
863+
pinStor_.push_back(temp_pin);
864864
}
865865

866866
if (pbVars_.skipIoMode == false) {
867-
for (dbBTerm* bTerm : net->getBTerms()) {
868-
Pin myPin(bTerm, log_);
869-
myPin.setNet(myNetPtr);
870-
pinStor_.push_back(myPin);
867+
for (dbBTerm* bTerm : db_net->getBTerms()) {
868+
Pin temp_pin(bTerm, log_);
869+
temp_pin.setNet(temp_net_ptr);
870+
pinStor_.push_back(temp_pin);
871871
}
872872
}
873873
}
874874
}
875875

876876
// pinMap_ and pins_ update
877877
pins_.reserve(pinStor_.size());
878-
for (auto& pin : pinStor_) {
879-
if (pin.isITerm()) {
880-
pinMap_[pin.getDbITerm()] = &pin;
881-
} else if (pin.isBTerm()) {
882-
pinMap_[pin.getDbBTerm()] = &pin;
878+
for (auto& pb_pin : pinStor_) {
879+
if (pb_pin.isITerm()) {
880+
pinMap_[pb_pin.getDbITerm()] = &pb_pin;
881+
} else if (pb_pin.isBTerm()) {
882+
pinMap_[pb_pin.getDbBTerm()] = &pb_pin;
883883
}
884-
pins_.push_back(&pin);
884+
pins_.push_back(&pb_pin);
885885
}
886886

887887
// instStor_'s pins_ fill
888-
for (auto& inst : instStor_) {
889-
if (!inst.isInstance()) {
888+
for (auto& pb_inst : instStor_) {
889+
if (!pb_inst.isInstance()) {
890890
continue;
891891
}
892-
for (dbITerm* iTerm : inst.dbInst()->getITerms()) {
892+
for (dbITerm* iTerm : pb_inst.dbInst()->getITerms()) {
893893
// note that, DB's ITerm can have
894894
// VDD/VSS pins.
895895
//
896896
// Escape those pins
897-
Pin* curPin = dbToPb(iTerm);
898-
if (curPin) {
899-
inst.addPin(curPin);
897+
Pin* cur_pin = dbToPb(iTerm);
898+
if (cur_pin) {
899+
pb_inst.addPin(cur_pin);
900900
}
901901
}
902902
}
903903

904904
// nets' pin update
905905
nets_.reserve(netStor_.size());
906-
for (auto& net : netStor_) {
907-
for (dbITerm* iTerm : net.getDbNet()->getITerms()) {
908-
net.addPin(dbToPb(iTerm));
906+
for (auto& pb_net : netStor_) {
907+
for (dbITerm* iTerm : pb_net.getDbNet()->getITerms()) {
908+
pb_net.addPin(dbToPb(iTerm));
909909
}
910910
if (pbVars_.skipIoMode == false) {
911-
for (dbBTerm* bTerm : net.getDbNet()->getBTerms()) {
912-
net.addPin(dbToPb(bTerm));
911+
for (dbBTerm* bTerm : pb_net.getDbNet()->getBTerms()) {
912+
pb_net.addPin(dbToPb(bTerm));
913913
}
914914
}
915-
nets_.push_back(&net);
915+
nets_.push_back(&pb_net);
916916
}
917917
}
918918

0 commit comments

Comments
 (0)