fix readability-avoid-const-params-in-decls

maliberty · maliberty · commit 215c38b46af4 · 2025-12-25T05:46:09.000Z
Signed-off-by: Matt Liberty &lt;mliberty@precisioninno.com&gt;
diff --git a/src/cts/src/HTreeBuilder.h b/src/cts/src/HTreeBuilder.h
@@ -32,7 +32,7 @@ class SegmentBuilder
                  Clock& clock,
                  ClockSubNet& drivingSubNet,
                  const TechChar& techChar,
-                 const unsigned techCharDistUnit,
+                 unsigned techCharDistUnit,
                  TreeBuilder* tree);
 
   void build(const std::string& forceBuffer = "");
diff --git a/src/drt/src/db/infra/KDTree.hpp b/src/drt/src/db/infra/KDTree.hpp
@@ -42,7 +42,7 @@ class KDTree
 
   void radiusSearchHelper(KDTreeNode* node,
                           const Point& target,
-                          const frSquaredDistance radius_square,
+                          frSquaredDistance radius_square,
                           const Orientation2D& orient,
                           std::vector<int>& result) const;
 
diff --git a/src/dst/include/dst/JobMessage.h b/src/dst/include/dst/JobMessage.h
@@ -81,7 +81,7 @@ class JobMessage
       = "\r\nENDOFPACKET\r\n";  // ENDOFPACKET SEQUENCE
 
   template <class Archive>
-  void serialize(Archive& ar, const unsigned int version);
+  void serialize(Archive& ar, unsigned int version);
 
   friend class boost::serialization::access;
 
diff --git a/src/grt/src/RepairAntennas.h b/src/grt/src/RepairAntennas.h
@@ -232,7 +232,7 @@ class RepairAntennas
   odb::dbOrientType getRowOrient(const odb::Point& point);
   RoutePtPinsMap findRoutePtPins(Net* net);
   bool pinOverlapsGSegment(const odb::Point& pin_position,
-                           const int pin_layer,
+                           int pin_layer,
                            const std::vector<odb::Rect>& pin_boxes,
                            const GRoute& route);
 
diff --git a/src/grt/src/heatMap.h b/src/grt/src/heatMap.h
@@ -24,10 +24,10 @@ class RoutingCongestionDataSource : public gui::GlobalRoutingDataSource,
   bool populateMap() override;
   void combineMapData(bool base_has_value,
                       double& base,
-                      const double new_data,
-                      const double data_area,
-                      const double intersection_area,
-                      const double rect_area) override;
+                      double new_data,
+                      double data_area,
+                      double intersection_area,
+                      double rect_area) override;
   void correctMapScale(HeatMapDataSource::Map& map) override;
   std::string formatValue(double value, bool legend) const override;
 
diff --git a/src/grt/src/heatMapRudy.h b/src/grt/src/heatMapRudy.h
@@ -49,10 +49,10 @@ class RUDYDataSource : public gui::GlobalRoutingDataSource,
   bool populateMap() override;
   void combineMapData(bool base_has_value,
                       double& base,
-                      const double new_data,
-                      const double data_area,
-                      const double intersection_area,
-                      const double rect_area) override;
+                      double new_data,
+                      double data_area,
+                      double intersection_area,
+                      double rect_area) override;
 
  private:
   grt::GlobalRouter* grouter_;
diff --git a/src/gui/include/gui/heatMap.h b/src/gui/include/gui/heatMap.h
@@ -181,10 +181,10 @@ class HeatMapDataSource
   void addToMap(const odb::Rect& region, double value);
   virtual void combineMapData(bool base_has_value,
                               double& base,
-                              const double new_data,
-                              const double data_area,
-                              const double intersection_area,
-                              const double rect_area)
+                              double new_data,
+                              double data_area,
+                              double intersection_area,
+                              double rect_area)
       = 0;
   virtual void correctMapScale(Map& map) {}
   void updateMapColors();
diff --git a/src/gui/src/clockWidget.h b/src/gui/src/clockWidget.h
@@ -123,7 +123,7 @@ class ClockNetGraphicsViewItem : public QGraphicsItem
                           bool top_anchor,
                           const QPointF& trunk_junction);
   void addLeafPath(const QPointF& start,
-                   const qreal y_trunk,
+                   qreal y_trunk,
                    const QPointF& end);
 
   void setNetInformation();
@@ -188,7 +188,7 @@ class ClockNodeGraphicsViewItem : public QGraphicsObject
   void updateView();
 
  protected:
-  void addDelayFin(QPainterPath& path, const qreal delay) const;
+  void addDelayFin(QPainterPath& path, qreal delay) const;
   void contextMenuEvent(QGraphicsSceneContextMenuEvent* event) override;
 
  private:
diff --git a/src/gui/src/inspector.h b/src/gui/src/inspector.h
@@ -116,7 +116,7 @@ class SelectedItemModel : public QStandardItemModel
   void makeItemEditor(const std::string& name,
                       QStandardItem* item,
                       const Selected& selected,
-                      const EditorItemDelegate::EditType type,
+                      EditorItemDelegate::EditType type,
                       const Descriptor::Editor& editor);
 
   const QColor selectable_item_;
diff --git a/src/gui/src/tclCmdHighlighter.h b/src/gui/src/tclCmdHighlighter.h
@@ -78,7 +78,7 @@ class TclCmdHighlighter : public QSyntaxHighlighter
   void initOther();
 
   static std::string escape(const std::string& preregex);
-  static CommandRulePtr buildKeywordRule(const int command_id,
+  static CommandRulePtr buildKeywordRule(int command_id,
                                          const std::string& command,
                                          const std::string& start_of_command,
                                          const std::string& end_of_command,
@@ -88,7 +88,7 @@ class TclCmdHighlighter : public QSyntaxHighlighter
                                 const std::string& start_of_command,
                                 const std::string& end_of_command);
   static CommandRulePtr buildRule(const std::string& pattern);
-  static CommandRulePtr buildRule(const int command_id,
+  static CommandRulePtr buildRule(int command_id,
                                   const std::string& pattern);
   static ArgumentRulePtr buildArgumentRule(const std::vector<std::string>& args,
                                            const QTextCharFormat* format);
diff --git a/src/odb/src/def/def/defiComponent.hpp b/src/odb/src/def/def/defiComponent.hpp
@@ -86,11 +86,11 @@ class defiComponent
   void setRegionBounds(int xl, int yl, int xh, int yh);
   void setEEQ(const char* name);
   void addNet(const char* netName);
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
   void reverseNetOrder();
   void setWeight(int w);
   void setMaskShift(const char* color);
diff --git a/src/odb/src/def/def/defiGroup.hpp b/src/odb/src/def/def/defiGroup.hpp
@@ -52,11 +52,11 @@ class defiGroup
   void clear();
 
   void setup(const char* name);
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
   void addRegionRect(int xl, int yl, int xh, int yh);
   void setRegionName(const char* name);
   void setMaxX(int x);
diff --git a/src/odb/src/def/def/defiNet.hpp b/src/odb/src/def/def/defiNet.hpp
@@ -250,11 +250,11 @@ class defiNet
   // WMD -- the following will be removed by the next release
   void setType(const char* typ);  // Either FIXED COVER ROUTED
 
-  void addProp(const char* name, const char* value, const char type);
+  void addProp(const char* name, const char* value, char type);
   void addNumProp(const char* name,
-                  const double d,
+                  double d,
                   const char* value,
-                  const char type);
+                  char type);
   void addSubnet(defiSubnet* subnet);
   // NEW: a net can have more than 1 wire
   void addWire(const char* typ, const char* wireShieldName);
diff --git a/src/odb/src/def/def/defiNonDefault.hpp b/src/odb/src/def/def/defiNonDefault.hpp
@@ -57,11 +57,11 @@ class defiNonDefault
   void addVia(const char* name);
   void addViaRule(const char* name);
   void addMinCuts(const char* name, int numCuts);
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
   void end();
 
   const char* name() const;
diff --git a/src/odb/src/def/def/defiPinProp.hpp b/src/odb/src/def/def/defiPinProp.hpp
@@ -50,11 +50,11 @@ class defiPinProp
   void clear();
 
   void setName(const char* inst, const char* pin);
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
 
   int isPin() const;
   const char* instName() const;
diff --git a/src/odb/src/def/def/defiPropType.hpp b/src/odb/src/def/def/defiPropType.hpp
@@ -47,7 +47,7 @@ class defiPropType
   void Destroy();
   ~defiPropType();
 
-  void setPropType(const char* name, const char type);
+  void setPropType(const char* name, char type);
   void Clear();
 
   char propType(char* name) const;
diff --git a/src/odb/src/def/def/defiRegion.hpp b/src/odb/src/def/def/defiRegion.hpp
@@ -51,11 +51,11 @@ class defiRegion
   void clear();
   void setup(const char* name);
   void addRect(int xl, int yl, int xh, int yh);
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
   void setType(const char* type);  // 5.4.1
 
   const char* name() const;
diff --git a/src/odb/src/def/def/defiRowTrack.hpp b/src/odb/src/def/def/defiRowTrack.hpp
@@ -55,11 +55,11 @@ class defiRow
              int orient);
   void setDo(double x_num, double y_num, double x_step, double y_step);
   void setHasDoStep();
-  void addProperty(const char* name, const char* value, const char type);
+  void addProperty(const char* name, const char* value, char type);
   void addNumProperty(const char* name,
-                      const double d,
+                      double d,
                       const char* value,
-                      const char type);
+                      char type);
 
   const char* name() const;
   const char* macro() const;
diff --git a/src/odb/src/lef/lef/lefiLayer.hpp b/src/odb/src/lef/lef/lefiLayer.hpp
@@ -442,11 +442,11 @@ class lefiLayer
   void setCurrentPoint(double width, double current);
   void setResistancePoint(double width, double res);
   void setCapacitancePoint(double width, double cap);
-  void addProp(const char* name, const char* value, const char type);
+  void addProp(const char* name, const char* value, char type);
   void addNumProp(const char* name,
-                  const double d,
+                  double d,
                   const char* value,
-                  const char type);
+                  char type);
   void addAccurrentDensity(const char* type);
   void setAcOneEntry(double num);
   void addAcFrequency();
diff --git a/src/odb/src/lef/lef/lefiMacro.hpp b/src/odb/src/lef/lef/lefiMacro.hpp
@@ -164,11 +164,11 @@ class lefiPin
   void setFallSatcur(double current);
   void setCurrentSource(const char* name);
   void setTables(const char* highName, const char* lowName);
-  void setProperty(const char* name, const char* value, const char type);
+  void setProperty(const char* name, const char* value, char type);
   void setNumProperty(const char* name,
                       double d,
                       const char* value,
-                      const char type);
+                      char type);
   void addAntennaModel(int oxide);  // 5.5
   void addAntennaSize(double value, const char* layer);
   void addAntennaMetalArea(double value, const char* layer);
@@ -518,11 +518,11 @@ class lefiMacro
   void setEEQ(const char* name);
   void setLEQ(const char* name);
   void setClockType(const char* name);
-  void setProperty(const char* name, const char* value, const char type);
+  void setProperty(const char* name, const char* value, char type);
   void setNumProperty(const char* name,
                       double d,
                       const char* value,
-                      const char type);
+                      char type);
   void bumpProps();
 
   // orient=-1 means no orient was specified.
diff --git a/src/odb/src/lef/lef/lefiNonDefault.hpp b/src/odb/src/lef/lef/lefiNonDefault.hpp
@@ -60,11 +60,11 @@ class lefiNonDefault
   void addDiagWidth(double num);  // 5.6
   void end();
   void clear();
-  void addProp(const char* name, const char* value, const char type);
+  void addProp(const char* name, const char* value, char type);
   void addNumProp(const char* name,
-                  const double d,
+                  double d,
                   const char* value,
-                  const char type);
+                  char type);
   void setHardspacing();                           // 5.6
   void addUseVia(const char* name);                // 5.6
   void addUseViaRule(const char* name);            // 5.6
diff --git a/src/odb/src/lef/lef/lefiPropType.hpp b/src/odb/src/lef/lef/lefiPropType.hpp
@@ -47,7 +47,7 @@ class lefiPropType
   void Destroy();
   ~lefiPropType();
 
-  void setPropType(const char* name, const char type);
+  void setPropType(const char* name, char type);
   void Clear();
 
   char propType(char* name) const;
diff --git a/src/odb/src/lef/lef/lefiVia.hpp b/src/odb/src/lef/lef/lefiVia.hpp
@@ -97,11 +97,11 @@ class lefiVia
   void setName(const char* name, int viaType);
 
   void setResistance(double num);
-  void addProp(const char* name, const char* value, const char type);
+  void addProp(const char* name, const char* value, char type);
   void addNumProp(const char* name,
                   double d,
                   const char* value,
-                  const char type);
+                  char type);
 
   // orient=-1 means no orient was specified.
   void setForeign(const char* name, int hasPnt, double x, double y, int orient);
diff --git a/src/odb/src/lef/lef/lefiViaRule.hpp b/src/odb/src/lef/lef/lefiViaRule.hpp
@@ -142,11 +142,11 @@ class lefiViaRule
   void setVertical();
   void setHorizontal();
   void setEnclosure(double overhang1, double overhang2);
-  void addProp(const char* name, const char* value, const char type);
+  void addProp(const char* name, const char* value, char type);
   void addNumProp(const char* name,
-                  const double d,
+                  double d,
                   const char* value,
-                  const char type);
+                  char type);
 
   // This routine sets and creates the active layer.
   void setLayer(const char* name);
diff --git a/src/odb/src/swig/common/swig_common.h b/src/odb/src/swig/common/swig_common.h
@@ -73,4 +73,4 @@ void createSBoxes(odb::dbSWire* swire,
                   std::vector<odb::Point> points,
                   odb::dbWireShapeType type);
 
-void dumpAPs(odb::dbBlock* block, const std::string file_name);
+void dumpAPs(odb::dbBlock* block, std::string file_name);
diff --git a/src/psm/src/connection.h b/src/psm/src/connection.h
@@ -91,6 +91,8 @@ class Connection
   bool hasNodeOfType() const;
 };
 
+using Connections = std::vector<std::unique_ptr<Connection>>;
+
 class LayerConnection : public Connection
 {
  public:
diff --git a/src/psm/src/debug_gui.cpp b/src/psm/src/debug_gui.cpp
@@ -696,8 +696,7 @@ bool DebugGui::isSelected(const Connection* connection) const
   return selected_connections_.find(connection) != selected_connections_.end();
 }
 
-void DebugGui::setSources(
-    const std::vector<std::unique_ptr<SourceNode>>& sources)
+void DebugGui::setSources(const SourceNodes& sources)
 {
   sources_.clear();
 
diff --git a/src/psm/src/debug_gui.h b/src/psm/src/debug_gui.h
@@ -142,7 +142,7 @@ class DebugGui : public gui::Renderer
     return control_group_.c_str();
   }
 
-  void setSources(const std::vector<std::unique_ptr<SourceNode>>& sources);
+  void setSources(const SourceNodes& sources);
   void setSourceShapes(odb::dbTechLayer* layer,
                        const std::set<odb::Rect>& shapes);
 
diff --git a/src/psm/src/ir_network.cpp b/src/psm/src/ir_network.cpp
@@ -554,7 +554,7 @@ void IRNetwork::generateCutNodesForSBox(
     odb::dbSBox* box,
     bool single_via,
     std::vector<std::unique_ptr<Node>>& new_nodes,
-    std::vector<std::unique_ptr<Connection>>& new_connections)
+    Connections& new_connections)
 {
   // handle as via
   std::vector<odb::dbShape> via_shapes;
@@ -655,7 +655,7 @@ void IRNetwork::generateCutLayerNodes()
   }
 
   std::vector<std::unique_ptr<Node>> loop_via_nodes;
-  std::vector<std::unique_ptr<Connection>> loop_via_connections;
+  Connections loop_via_connections;
   for (odb::dbSBox* box : boxes) {
     generateCutNodesForSBox(
         box, use_single_via, loop_via_nodes, loop_via_connections);
diff --git a/src/psm/src/ir_network.h b/src/psm/src/ir_network.h
diff --git a/src/psm/src/ir_solver.cpp b/src/psm/src/ir_solver.cpp
diff --git a/src/psm/src/ir_solver.h b/src/psm/src/ir_solver.h
diff --git a/src/psm/src/node.h b/src/psm/src/node.h
diff --git a/src/psm/src/shape.cpp b/src/psm/src/shape.cpp
diff --git a/src/psm/src/shape.h b/src/psm/src/shape.h
diff --git a/src/rcx/include/rcx/extRCap.h b/src/rcx/include/rcx/extRCap.h
diff --git a/src/utl/src/LoggerCommon.h b/src/utl/src/LoggerCommon.h
