1- remove child and tech from readDef API

2- move dbTech from dbBlock to dbChip.
3- Update dbChip and dbBlock creation APIs.
4- Update Tcl scripts and tests to reflect these changes.

Signed-off-by: osamahammad21 <[email protected]>

Author: osamahammad21

include/ord/Design.h

@@ -126,8 +126,7 @@ class Design
   void readDef(const std::string& file_name,
                bool continue_on_errors = false,
                bool floorplan_init = false,
-               bool incremental = false,
-               bool child = false);
+               bool incremental = false);
   void link(const std::string& design_name);
 
   void readDb(std::istream& stream);

include/ord/OpenRoad.hh

@@ -186,12 +186,10 @@ class OpenRoad
                bool make_library);
 
   void readDef(const char* filename,
-               odb::dbTech* tech,
                odb::dbChip* chip,
                bool continue_on_errors,
                bool floorplan_init,
-               bool incremental,
-               bool child);
+               bool incremental);
 
   void writeLef(const char* filename);
 

src/Design.cc

@@ -54,8 +54,7 @@ void Design::readVerilog(const std::string& file_name)
 void Design::readDef(const std::string& file_name,
                      bool continue_on_errors,  // = false
                      bool floorplan_init,      // = false
-                     bool incremental,         // = false
-                     bool child                // = false
+                     bool incremental          // = false
 )
 {
   if (floorplan_init && incremental) {
@@ -69,15 +68,10 @@ void Design::readDef(const std::string& file_name,
   }
   auto chip = tech_->getDB()->getChip();
   if (chip == nullptr) {
-    chip = odb::dbChip::create(tech_->getDB());
+    chip = odb::dbChip::create(tech_->getDB(), tech_->getDB()->getTech());
   }
-  getOpenRoad()->readDef(file_name.c_str(),
-                         tech_->getDB()->getTech(),
-                         chip,
-                         continue_on_errors,
-                         floorplan_init,
-                         incremental,
-                         child);
+  getOpenRoad()->readDef(
+      file_name.c_str(), chip, continue_on_errors, floorplan_init, incremental);
 }
 
 void Design::link(const std::string& design_name)

src/OpenRoad.cc

@@ -325,14 +325,12 @@ void OpenRoad::readLef(const char* filename,
 }
 
 void OpenRoad::readDef(const char* filename,
-                       dbTech* tech,
                        dbChip* chip,
                        bool continue_on_errors,
                        bool floorplan_init,
-                       bool incremental,
-                       bool child)
+                       bool incremental)
 {
-  if (!floorplan_init && !incremental && !child && chip && chip->getBlock()) {
+  if (!floorplan_init && !incremental && chip && chip->getBlock()) {
     logger_->info(ORD, 48, "Loading an additional DEF.");
   }
 
@@ -350,12 +348,7 @@ void OpenRoad::readDef(const char* filename,
   if (continue_on_errors) {
     def_reader.continueOnErrors();
   }
-  if (child) {
-    auto parent = db_->getChip()->getBlock();
-    def_reader.createBlock(parent, search_libs, filename, tech);
-  } else {
-    def_reader.readChip(search_libs, filename, tech, chip);
-  }
+  def_reader.readChip(search_libs, filename, chip);
 }
 
 static odb::defout::Version stringToDefVersion(const string& version)

src/OpenRoad.i

@@ -304,27 +304,15 @@ read_lef_cmd(const char *filename,
 
 void
 read_def_cmd(const char *filename,
-             const char* tech_name,
              bool continue_on_errors,
              bool floorplan_init,
              bool incremental,
-             bool child,
              odb::dbChip* chip)
 {
   OpenRoad *ord = getOpenRoad();
   auto* db = ord->getDb();
-  dbTech* tech;
-  if (tech_name[0] != '\0') {
-    tech = db->findTech(tech_name);
-  } else {
-    tech = db->getTech();
-  }
-  if (!tech) {
-    auto logger = getLogger();
-    logger->error(utl::ORD, 52, "Technology {} not found", tech_name);
-  }
-  ord->readDef(filename, tech, chip, continue_on_errors,
-               floorplan_init, incremental, child);
+  ord->readDef(filename, chip, continue_on_errors,
+               floorplan_init, incremental);
 }
 
 void

src/OpenRoad.tcl

@@ -38,7 +38,7 @@ proc read_lef { args } {
   ord::read_lef_cmd $filename $lib_name $tech_name $make_tech $make_lib
 }
 
-sta::define_cmd_args "read_def" {[-floorplan_initialize|-incremental|-child]\
+sta::define_cmd_args "read_def" {[-floorplan_initialize|-incremental]\
                                    [-continue_on_errors]\
                                    [-tech name] \
                                    [-chip chip_name] \
@@ -47,7 +47,7 @@ sta::define_cmd_args "read_def" {[-floorplan_initialize|-incremental|-child]\
 proc read_def { args } {
   sta::parse_key_args "read_def" args keys {-tech -chip} \
     flags {-floorplan_initialize -incremental \
-           -order_wires -continue_on_errors -child}
+           -order_wires -continue_on_errors}
   sta::check_argc_eq1 "read_def" $args
   set filename [file nativename [lindex $args 0]]
   if { ![file exists $filename] } {
@@ -56,22 +56,26 @@ proc read_def { args } {
   if { ![file readable $filename] || ![file isfile $filename] } {
     utl::error "ORD" 4 "$filename is not readable."
   }
-  set tech_name ""
   if { [info exists keys(-tech)] } {
     set tech_name $keys(-tech)
+    set tech [[ord::get_db] findTech $tech_name]
+    if { $tech == "NULL" } {
+      utl::error ORD 52 "Technology $tech_name not found."
+    }
   } elseif { ![ord::db_has_tech] } {
     utl::error "ORD" 5 "No technology has been read."
+  } else {
+    set tech [[ord::get_db] getTech]
   }
   if { [info exists flags(-order_wires)] } {
     utl::warn "ORD" 33 "-order_wires is deprecated."
   }
   set continue_on_errors [info exists flags(-continue_on_errors)]
   set floorplan_init [info exists flags(-floorplan_initialize)]
   set incremental [info exists flags(-incremental)]
-  set child [info exists flags(-child)]
-  if { $floorplan_init + $incremental + $child > 1 } {
-    utl::error ORD 16 "Options -incremental, -floorplan_initialization,\
-      and -child are mutually exclusive."
+  if { $floorplan_init + $incremental > 1 } {
+    utl::error ORD 16 "Options -incremental and -floorplan_initialization\
+      are mutually exclusive."
   }
   if { [info exists keys(-chip)] } {
     set chip [[ord::get_db] findChip $keys(-chip)]
@@ -80,13 +84,13 @@ proc read_def { args } {
     }
   } else {
     if { [[ord::get_db] getChip] == "NULL" } {
-      set chip [odb::dbChip_create [ord::get_db]]
+      set chip [odb::dbChip_create [ord::get_db] $tech]
     } else {
       set chip [[ord::get_db] getChip]
     }
   }
-  ord::read_def_cmd $filename $tech_name $continue_on_errors $floorplan_init \
-    $incremental $child $chip
+  ord::read_def_cmd $filename $continue_on_errors $floorplan_init \
+    $incremental $chip
 }
 
 sta::define_cmd_args "write_def" {[-version version] filename}

src/cts/test/array.tcl

@@ -19,7 +19,7 @@ read_lef array_tile.lef
 
 set db [ord::get_db]
 set tech [ord::get_db_tech]
-set chip [odb::dbChip_create $db]
+set chip [odb::dbChip_create $db $tech]
 set block [odb::dbBlock_create $chip "top"]
 $block setDefUnits 2000
 

src/cts/test/array_dummy.tcl

@@ -19,7 +19,7 @@ read_lef array_tile.lef
 
 set db [ord::get_db]
 set tech [ord::get_db_tech]
-set chip [odb::dbChip_create $db]
+set chip [odb::dbChip_create $db $tech]
 set block [odb::dbBlock_create $chip "top"]
 $block setDefUnits 2000
 

src/cts/test/array_full_flow.tcl

@@ -19,7 +19,7 @@ read_lef array_tile.lef
 
 set db [ord::get_db]
 set tech [ord::get_db_tech]
-set chip [odb::dbChip_create $db]
+set chip [odb::dbChip_create $db $tech]
 set block [odb::dbBlock_create $chip "top"]
 $block setDefUnits 2000
 

src/cts/test/array_ins_delay.tcl

@@ -19,7 +19,7 @@ read_lef array_tile.lef
 
 set db [ord::get_db]
 set tech [ord::get_db_tech]
-set chip [odb::dbChip_create $db]
+set chip [odb::dbChip_create $db $tech]
 set block [odb::dbBlock_create $chip "top"]
 $block setDefUnits 2000