odb: clang-tidy changes

Signed-off-by: Osama <[email protected]>

Author: osamahammad21

src/odb/include/odb/db.h

@@ -7030,7 +7030,7 @@ class dbChipInst : public dbObject
  public:
   std::string getName() const;
 
-  void setLoc(Point3D loc);
+  void setLoc(const Point3D& loc);
 
   Point3D getLoc() const;
 
@@ -7039,7 +7039,7 @@ class dbChipInst : public dbObject
   dbChip* getParentChip() const;
 
   // User Code Begin dbChipInst
-  void setOrient(dbOrientType orient);
+  void setOrient(const dbOrientType& orient);
 
   dbOrientType getOrient() const;
 

src/odb/include/odb/geom.h

@@ -73,8 +73,8 @@ class Point3D : public Point
   Point3D(const Point3D& p) : Point(p.getX(), p.getY()), z_(p.getZ()) {}
   Point3D(const Point& p, int z) : Point(p), z_(z) {}
 
-  bool operator==(const Point3D& pIn) const;
-  bool operator!=(const Point3D& pIn) const { return !(*this == pIn); }
+  bool operator==(const Point3D& rhs) const;
+  bool operator!=(const Point3D& rhs) const { return !(*this == rhs); }
   bool operator<(const Point3D& rhs) const;
   bool operator>=(const Point3D& rhs) const { return !(*this < rhs); }
 

src/odb/src/db/dbChipInst.cpp

@@ -92,7 +92,7 @@ std::string dbChipInst::getName() const
   return obj->name_;
 }
 
-void dbChipInst::setLoc(Point3D loc)
+void dbChipInst::setLoc(const Point3D& loc)
 {
   _dbChipInst* obj = (_dbChipInst*) this;
 
@@ -126,7 +126,7 @@ dbChip* dbChipInst::getParentChip() const
 }
 
 // User Code Begin dbChipInstPublicMethods
-void dbChipInst::setOrient(dbOrientType orient)
+void dbChipInst::setOrient(const dbOrientType& orient)
 {
   _dbChipInst* obj = (_dbChipInst*) this;
   obj->orient_ = orient;