Merge pull request #8178 from Pinata-Consulting/power-mock-array-element

power: hierarchical .odb testing

Author: maliberty

test/orfs/mock-array/BUILD

@@ -25,12 +25,6 @@ MOCK_ARRAY_TABLE = [
     22,
 ]
 
-# Element'd data width
-MOCK_ARRAY_DATAWIDTH = 64
-
-# Must be zero for routing by abutment
-MACRO_BLOCKAGE_HALO = 0
-
 MOCK_ARRAY_SCALE = 45
 
 # Routing pitches for relevant metal layers.
@@ -77,10 +71,6 @@ array_spacing_x = margin_x * 2
 
 array_spacing_y = margin_y * 2
 
-array_offset_x = array_spacing_x + margin_x
-
-array_offset_y = array_spacing_y + margin_y
-
 # top level core and die size
 core_width = (
     2 * array_spacing_x + ((placement_grid_x * pitch_x) * (cols - 1)) + ce_width
@@ -191,7 +181,12 @@ orfs_flow(
             ce_height,
         ),
         "PDN_TCL": "$(PLATFORM_DIR)/openRoad/pdn/BLOCK_grid_strategy.tcl",
+        # We want to report power per module using hierarhical .odb
         "OPENROAD_HIERARCHICAL": "1",
+        # Keep only one module, enough for testing, faster builds. There's
+        # some width in multiply reduction going on here to speed up
+        # builds, so we want to keep this exact module.
+        "SYNTH_KEEP_MODULES": "Multiplier",
     },
     sources = {
         "IO_CONSTRAINTS": [":mock-array-element-io"],
@@ -339,6 +334,8 @@ genrule(
     ],
 )
 
+# If we want to measure power after final, instead of with estimated parasitics,
+# we'll need this.
 SPEFS_AND_NETLISTS = [
     ":results/asap7/{macro}/{stem}.{ext}".format(
         ext = ext,

test/orfs/mock-array/rules-base.json

@@ -1,14 +1,14 @@
 {
     "synth__design__instance__area__stdcell": {
-        "value": 7635.06,
+        "value": 14185.31,
         "compare": "<="
     },
     "constraints__clocks__count": {
         "value": 1,
         "compare": "=="
     },
     "placeopt__design__instance__area": {
-        "value": 138015,
+        "value": 137948,
         "compare": "<="
     },
     "placeopt__design__instance__count__stdcell": {
@@ -32,7 +32,7 @@
         "compare": "<="
     },
     "detailedroute__route__wirelength": {
-        "value": 77761,
+        "value": 73938,
         "compare": "<="
     },
     "detailedroute__route__drc_errors": {
@@ -48,23 +48,23 @@
         "compare": "<="
     },
     "finish__timing__setup__ws": {
-        "value": -351.636,
+        "value": 0.0,
         "compare": ">="
     },
     "finish__design__instance__area": {
-        "value": 138064,
+        "value": 137975,
         "compare": "<="
     },
     "finish__timing__drv__setup_violation_count": {
         "value": 536,
         "compare": "<="
     },
     "finish__timing__drv__hold_violation_count": {
-        "value": 108,
+        "value": 100,
         "compare": "<="
     },
     "finish__timing__wns_percent_delay": {
-        "value": -107.06,
+        "value": -10.0,
         "compare": ">="
     }
 }

test/orfs/mock-array/src/main/scala/MockArray.scala

@@ -49,18 +49,35 @@ class MockArrayBundle(width: Int, height: Int, singleElementWidth: Int) extends
   val lsbs = Output(Vec(width * height, Bool()))
 }
 
+class MultiplierIO extends Bundle {
+  val a = Input(UInt(32.W))
+  val b = Input(UInt(32.W))
+  val o = Output(UInt(32.W))
+  val rst = Input(Bool())
+  val clk = Input(Clock())
+}
+
 // Generated with:
 //
 // vlsi-multiplier --register-input --register-post-ppg --register-post-ppa --register-output --bits=32 --algorithm=brentkung --tech=asap7 --output=multiplier.v
-class Multiplier extends BlackBox with HasBlackBoxResource {
+class MultiplierBlackBox extends BlackBox with HasBlackBoxResource {
   override def desiredName = "multiplier"
-  val io = IO(new Bundle {
-    val a = Input(UInt(32.W))
-    val b = Input(UInt(32.W))
-    val o = Output(UInt(32.W))
-    val rst = Input(Bool())
-    val clk = Input(Clock())
-  })
+  val io = IO(new MultiplierIO())
+}
+
+// This module is kept in synthesis for hierarchical power testing purposes
+class Multiplier extends RawModule {
+  val io = IO(new MultiplierIO())
+
+  val mod = Module(new MultiplierBlackBox())
+  mod.io.a := io.a
+  mod.io.b := io.b
+  mod.io.rst := io.rst
+  mod.io.clk := io.clk
+  // reduce output bit-width until we slight negative slack
+  // and also until we run in a few minutes for fast local
+  // smoke-testing
+  io.o := mod.io.o(3, 0)
 }
 
 class MockArray(width: Int, height: Int, singleElementWidth: Int)
@@ -89,10 +106,7 @@ class MockArray(width: Int, height: Int, singleElementWidth: Int)
         // save some area and complexity by not having reset
         mult.io.rst := false.B
         mult.io.clk := clock
-        // reduce output bit-width until we slight negative slack
-        // and also until we run in a few minutes for fast local
-        // smoke-testing
-        mult.io.o(3, 0)
+        mult.io.o
       })
     }