Skip to content

Commit 2c453d0

Browse files
committed
Minor refactoring and reverting to the original net names.
- New net names do not look better. Signed-off-by: Jaehyun Kim <[email protected]>
1 parent 987aa56 commit 2c453d0

File tree

7 files changed

+38
-52
lines changed

7 files changed

+38
-52
lines changed

src/rsz/src/Resizer.cc

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3413,29 +3413,19 @@ void Resizer::createNewTieCellForLoadPin(const Pin* load_pin,
34133413
odb::dbModITerm* load_mod_iterm = nullptr;
34143414
db_network_->staToDb(load_pin, load_iterm, load_bterm, load_mod_iterm);
34153415

3416+
std::string connection_name = "net";
3417+
34163418
// load_pin is a flat pin
34173419
if (load_iterm) {
34183420
// Connect the tie instance output pin to the load pin.
3419-
// - It automatically disconnects the existing connection of load pin
3420-
std::string connection_name
3421-
= fmt::format("{}_{}",
3422-
db_network_->name(new_tie_inst),
3423-
new_tie_iterm->getMTerm()->getName());
3424-
load_iterm->disconnect();
3421+
load_iterm->disconnect(); // This is required
34253422
db_network_->hierarchicalConnect(
34263423
new_tie_iterm, load_iterm, connection_name.c_str());
34273424
return;
34283425
}
34293426

34303427
// load_pin is a hier pin
34313428
if (load_mod_iterm) {
3432-
// Connect the tie instance output pin to the load pin.
3433-
// - It automatically disconnects the existing connection of load pin
3434-
std::string connection_name
3435-
= fmt::format("{}_{}",
3436-
db_network_->name(new_tie_inst),
3437-
new_tie_iterm->getMTerm()->getName());
3438-
34393429
// Should not disconnect load_mod_iterm first. hierarchicalConnect() will
34403430
// handle it. If load_mod_iterm is disconnected first,
34413431
// hierarchicalConnect() cannot find the matching flat net with the
@@ -3449,10 +3439,6 @@ void Resizer::createNewTieCellForLoadPin(const Pin* load_pin,
34493439
if (load_bterm) {
34503440
// Create a new net and connect both the tie cell output and the top-level
34513441
// port to it.
3452-
std::string connection_name
3453-
= fmt::format("{}_{}",
3454-
db_network_->name(new_tie_inst),
3455-
new_tie_iterm->getMTerm()->getName());
34563442
Net* new_net = db_network_->makeNet(
34573443
connection_name.c_str(), parent, odb::dbNameUniquifyType::IF_NEEDED);
34583444
new_tie_iterm->connect(db_network_->staToDb(new_net));

src/rsz/test/repair_tie10_hier.ok

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Net gcd/ALU_16_0_16_0_16_unused_CO[14:0]_X_HAN_CARLSON/BI
6060
Number of pins: 2
6161

6262
Driver pins
63-
_396__1/H output (TIEHIx1_ASAP7_75t_R) (0, 0)
63+
_395__1/H output (TIEHIx1_ASAP7_75t_R) (0, 0)
6464

6565
Load pins
6666
_395_/_087_/A input (BUFx2_ASAP7_75t_R) 0.44-0.58
@@ -77,7 +77,7 @@ Net gcd/ALU_16_0_16_0_16_unused_CO[14:0]_X_HAN_CARLSON/CI
7777
Number of pins: 2
7878

7979
Driver pins
80-
_396__2/H output (TIEHIx1_ASAP7_75t_R) (0, 0)
80+
_395__2/H output (TIEHIx1_ASAP7_75t_R) (0, 0)
8181

8282
Load pins
8383
_395_/_153_/B input (FAx1_ASAP7_75t_R) 1.80-2.18

src/rsz/test/repair_tie11_hier.defok

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@ UNITS DISTANCE MICRONS 1000 ;
66
COMPONENTS 8 ;
77
- alu0/hier2/load1 BUFx2_ASAP7_75t_R ;
88
- alu0/load2 BUFx2_ASAP7_75t_R ;
9+
- alu0_1 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
910
- alu1/hier2/load1 BUFx2_ASAP7_75t_R ;
1011
- alu1/load2 BUFx2_ASAP7_75t_R ;
12+
- alu1_2 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
1113
- load0 BUFx2_ASAP7_75t_R ;
12-
- tie0 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
13-
- tie0_1 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
14-
- tie0_2 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 36 135 ) N ;
14+
- load0_3 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 36 135 ) N ;
1515
END COMPONENTS
1616
PINS 1 ;
1717
- top_in + NET top_in + DIRECTION INPUT + USE SIGNAL ;
1818
END PINS
1919
NETS 4 ;
20-
- tie0_1_H ( alu1/hier2/load1 A ) ( tie0_1 H ) ( alu1/load2 A ) + USE SIGNAL ;
21-
- tie0_2_H ( load0 A ) ( tie0_2 H ) + USE SIGNAL ;
22-
- tie0_H ( alu0/hier2/load1 A ) ( tie0 H ) ( alu0/load2 A ) + USE SIGNAL ;
20+
- net ( alu0/hier2/load1 A ) ( alu0_1 H ) ( alu0/load2 A ) + USE SIGNAL ;
21+
- net1 ( alu1/hier2/load1 A ) ( alu1_2 H ) ( alu1/load2 A ) + USE SIGNAL ;
22+
- net2 ( load0 A ) ( load0_3 H ) + USE SIGNAL ;
2323
- top_in ( PIN top_in ) + USE SIGNAL ;
2424
END NETS
2525
END DESIGN

src/rsz/test/repair_tie11_hier.vok

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
module top (top_in);
22
input top_in;
33

4-
wire tie0_1_H;
5-
wire tie0_H;
4+
wire net;
5+
wire net;
66
wire main_net;
7-
wire tie0_2_H;
8-
9-
TIEHIx1_ASAP7_75t_R tie0_2 (.H(tie0_2_H));
10-
TIEHIx1_ASAP7_75t_R tie0_1 (.H(tie0_1_H));
11-
TIEHIx1_ASAP7_75t_R tie0 (.H(tie0_H));
12-
BUFx2_ASAP7_75t_R load0 (.A(tie0_2_H));
13-
ALU_module alu0 (.MI1(tie0_H));
14-
ALU_module_alu1 alu1 (.MI1(tie0_1_H));
7+
wire net2;
8+
9+
TIEHIx1_ASAP7_75t_R load0_3 (.H(net2));
10+
TIEHIx1_ASAP7_75t_R alu1_2 (.H(net));
11+
TIEHIx1_ASAP7_75t_R alu0_1 (.H(net));
12+
BUFx2_ASAP7_75t_R load0 (.A(net2));
13+
ALU_module alu0 (.MI1(net));
14+
ALU_module_alu1 alu1 (.MI1(net));
1515
HIER1 hier1 (.in(top_in),
1616
.MI0(main_net));
1717
endmodule

src/rsz/test/repair_tie12_hier.defok

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@ UNITS DISTANCE MICRONS 1000 ;
66
COMPONENTS 8 ;
77
- alu0/hier2/load1 BUFx2_ASAP7_75t_R ;
88
- alu0/load2 BUFx2_ASAP7_75t_R ;
9+
- alu0_1 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
910
- hier3/alu1/hier2/load1 BUFx2_ASAP7_75t_R ;
1011
- hier3/alu1/load2 BUFx2_ASAP7_75t_R ;
11-
- hier3/tie0 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
12+
- hier3/alu1_2 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
1213
- load0 BUFx2_ASAP7_75t_R ;
13-
- tie0 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 0 0 ) N ;
14-
- tie0_1 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 36 135 ) N ;
14+
- load0_3 TIEHIx1_ASAP7_75t_R + SOURCE TIMING + PLACED ( 36 135 ) N ;
1515
END COMPONENTS
1616
PINS 1 ;
1717
- top_in + NET top_in + DIRECTION INPUT + USE SIGNAL ;
1818
END PINS
1919
NETS 4 ;
20-
- tie0_1_H ( load0 A ) ( tie0_1 H ) + USE SIGNAL ;
21-
- tie0_H ( alu0/hier2/load1 A ) ( tie0 H ) ( alu0/load2 A ) + USE SIGNAL ;
22-
- tie0_H1 ( hier3/alu1/hier2/load1 A ) ( hier3/tie0 H ) ( hier3/alu1/load2 A ) + USE SIGNAL ;
20+
- net ( alu0/hier2/load1 A ) ( alu0_1 H ) ( alu0/load2 A ) + USE SIGNAL ;
21+
- net1 ( hier3/alu1/hier2/load1 A ) ( hier3/alu1_2 H ) ( hier3/alu1/load2 A ) + USE SIGNAL ;
22+
- net2 ( load0 A ) ( load0_3 H ) + USE SIGNAL ;
2323
- top_in ( PIN top_in ) + USE SIGNAL ;
2424
END NETS
2525
END DESIGN

src/rsz/test/repair_tie12_hier.vok

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
module top (top_in);
22
input top_in;
33

4-
wire tie0_H;
4+
wire net;
55
wire main_net;
6-
wire tie0_1_H;
6+
wire net2;
77

8-
TIEHIx1_ASAP7_75t_R tie0_1 (.H(tie0_1_H));
9-
TIEHIx1_ASAP7_75t_R tie0 (.H(tie0_H));
10-
BUFx2_ASAP7_75t_R load0 (.A(tie0_1_H));
11-
ALU_module alu0 (.MI1(tie0_H));
8+
TIEHIx1_ASAP7_75t_R load0_3 (.H(net2));
9+
TIEHIx1_ASAP7_75t_R alu0_1 (.H(net));
10+
BUFx2_ASAP7_75t_R load0 (.A(net2));
11+
ALU_module alu0 (.MI1(net));
1212
HIER1 hier1 (.in(top_in),
1313
.MI0(main_net));
1414
HIER3 hier3 ();
@@ -35,10 +35,10 @@ module HIER1 (in,
3535
endmodule
3636
module HIER3 ();
3737

38-
wire tie0_H;
38+
wire net;
3939

40-
TIEHIx1_ASAP7_75t_R tie0 (.H(tie0_H));
41-
ALU_module_alu1 alu1 (.MI1(tie0_H));
40+
TIEHIx1_ASAP7_75t_R alu1_2 (.H(net));
41+
ALU_module_alu1 alu1 (.MI1(net));
4242
endmodule
4343
module ALU_module_alu1 (MI1);
4444
input MI1;

src/rsz/test/repair_tie9.defok

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ UNITS DISTANCE MICRONS 1000 ;
66
DIEAREA ( 0 0 ) ( 40000 40000 ) ;
77
COMPONENTS 4 ;
88
- t1 sky130_fd_sc_hd__conb_1 ;
9-
- t1_1 sky130_fd_sc_hd__conb_1 + SOURCE TIMING + PLACED ( 280 1195 ) N ;
109
- u0 sky130_fd_sc_hd__buf_4 ;
10+
- u0_1 sky130_fd_sc_hd__conb_1 + SOURCE TIMING + PLACED ( 280 1195 ) N ;
1111
- u1 sky130_fd_sc_hd__buf_4 ;
1212
END COMPONENTS
1313
NETS 2 ;
1414
- n1 ( t1 HI ) ( u1 A ) + USE SIGNAL ;
15-
- t1_1_HI ( u0 A ) ( t1_1 HI ) + USE SIGNAL ;
15+
- net ( u0 A ) ( u0_1 HI ) + USE SIGNAL ;
1616
END NETS
1717
END DESIGN

0 commit comments

Comments
 (0)