Merge pull request #8802 from The-OpenROAD-Project-staging/rsz-rmbuf-bug

rsz: Add test for `-hier` buffer removal bug

Author: maliberty

src/rsz/test/BUILD

@@ -39,6 +39,7 @@ TESTS = [
     "rebuffer1",
     "rebuffer1_hier",
     "recover_power_verbose",
+    "remove_buffers_hier1",
     "remove_buffers1",
     "remove_buffers2",
     "remove_buffers3",

src/rsz/test/CMakeLists.txt

@@ -35,6 +35,7 @@ or_integration_tests(
     rebuffer1
     rebuffer1_hier
     recover_power_verbose
+    remove_buffers_hier1
     remove_buffers1
     remove_buffers2
     remove_buffers3

src/rsz/test/remove_buffers_hier1.ok

@@ -0,0 +1,48 @@
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13178, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13211, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13244, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13277, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13310, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13343, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13376, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14772, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14805, timing group from output port.
+[WARNING STA-1212] asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14838, timing group from output port.
+[INFO ODB-0227] LEF file: asap7/asap7_tech_1x_201209.lef, created 30 layers, 9 vias
+[INFO ODB-0227] LEF file: asap7/asap7sc7p5t_28_R_1x_220121a.lef, created 212 library cells
+[WARNING STA-0201] remove_buffers_hier1.v line 9, instance tie1 port HI not found.
+[WARNING ORD-0011] Hierarchical flow (-hier) is currently in development and may cause multiple issues. Do not use in production environments.
+Before removal:
+m1/buf1/Y -> B wire
+  ^ -> ^ 0.00:0.00
+  v -> v 0.00:0.00
+Startpoint: i (input port)
+Endpoint: k (output port)
+Path Group: path delay
+Path Type: max
+
+  Delay    Time   Description
+---------------------------------------------------------
+   0.00    0.00 ^ input external delay
+   0.00    0.00 ^ i (in)
+   3.41    3.41 v inv1/Y (INVx1_ASAP7_75t_R)
+   4.46    7.86 ^ m1/inv1/Y (INVx1_ASAP7_75t_R)
+  12.65   20.51 ^ m1/buf1/Y (BUFx2_ASAP7_75t_R)
+  19.69   40.20 ^ m1/gate1/Y (AND3x1_ASAP7_75t_R)
+   3.90   44.10 v inv3/Y (INVx1_ASAP7_75t_R)
+   0.00   44.10 v k (out)
+          44.10   data arrival time
+
+  10.00   10.00   max_delay
+   0.00   10.00   output external delay
+          10.00   data required time
+---------------------------------------------------------
+          10.00   data required time
+         -44.10   data arrival time
+---------------------------------------------------------
+         -34.10   slack (VIOLATED)
+
+
+[INFO RSZ-0026] Removed 1 buffers.
+After removal:
+No paths found.

src/rsz/test/remove_buffers_hier1.tcl

@@ -0,0 +1,24 @@
+source "helpers.tcl"
+source "resizer_helpers.tcl"
+
+read_liberty asap7/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz
+read_liberty asap7/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz
+read_liberty asap7/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz
+read_liberty asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz
+read_liberty asap7/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib
+read_lef asap7/asap7_tech_1x_201209.lef
+read_lef asap7/asap7sc7p5t_28_R_1x_220121a.lef
+
+read_verilog remove_buffers_hier1.v
+link_design -hier top
+set_max_delay -from i -to k 10
+
+puts "Before removal:"
+report_edges -to m1/gate1/B
+report_checks -from i -to k
+
+remove_buffers m1/buf1
+
+puts "After removal:"
+report_edges -to m1/gate1/B
+report_checks -from i -to k

src/rsz/test/remove_buffers_hier1.v

@@ -0,0 +1,21 @@
+module sm(a, b, c);
+ input a;
+ output b;
+ output c;
+ wire n1, n2;
+ INVx1_ASAP7_75t_R inv1(.A(a), .Y(n1));
+ BUFx2_ASAP7_75t_R buf1(.A(n1), .Y(b));
+ AND3x1_ASAP7_75t_R gate1(.A(n2), .B(b), .C(n2), .Y(c));
+ TIEHIx1_ASAP7_75t_R tie1(.HI(n2));
+endmodule
+
+module top(i, j, k);
+ input i;
+ output j;
+ output k;
+ wire n1, n2, n3;
+ sm m1(.a(n1), .b(n2), .c(n3));
+ INVx1_ASAP7_75t_R inv1(.A(i), .Y(n1));
+ INVx1_ASAP7_75t_R inv2(.A(n2), .Y(j));
+ INVx1_ASAP7_75t_R inv3(.A(n3), .Y(k));
+endmodule