Merge pull request #8852 from gadfort/pdn-correct-min-width

pdn: correct min width estimate during via generation

Author: maliberty

src/pdn/src/connect.cpp

@@ -321,15 +321,23 @@ int Connect::getMaxEnclosureFromCutLayer(odb::dbTechLayer* layer,
   for (auto* rule : tech_vias_) {
     bool use = false;
     int max_size = 0;
+    int max_via_size = 0;
+    int cnt_vias = 0;
     for (auto* box : rule->getBoxes()) {
-      use |= box->getTechLayer() == layer;
-
       odb::Rect rect = box->getBox();
-      max_size = std::max(max_size, static_cast<int>(rect.maxDXDY()));
+
+      if (box->getTechLayer() == layer) {
+        use = true;
+        cnt_vias += 1;
+        max_via_size = std::max(max_via_size, rect.maxDXDY());
+      }
+
+      max_size = std::max(max_size, rect.maxDXDY());
     }
 
-    if (use) {
-      max_enclosure = std::max(max_enclosure, (max_size - min_width) / 2);
+    if (use && cnt_vias == 1) {
+      max_enclosure
+          = std::max(max_enclosure, (max_size - max_via_size - min_width) / 2);
     }
   }
 

src/pdn/src/grid.cpp

@@ -1679,10 +1679,13 @@ void InstanceGrid::report() const
 bool InstanceGrid::isValid() const
 {
   if (getNets(startsWithPower()).empty()) {
-    getLogger()->warn(utl::PDN,
-                      231,
-                      "{} is not connected to any power/ground nets.",
-                      inst_->getName());
+    if (!inst_->getITerms().empty()) {
+      // only warn when instance has something that could be connected to
+      getLogger()->warn(utl::PDN,
+                        231,
+                        "{} is not connected to any power/ground nets.",
+                        inst_->getName());
+    }
     return false;
   }
   return true;