Merge pull request #8045 from The-OpenROAD-Project-staging/secure-jhkim-trivial

Fixed coverity CID 1620019 issue.

Author: maliberty

src/rsz/src/Rebuffer.cc

@@ -3,6 +3,7 @@
 
 #include "Rebuffer.hh"
 
+#include <limits>
 #include <memory>
 
 #include "BufferMove.hh"
@@ -2009,10 +2010,14 @@ void Rebuffer::printProgress(int iteration,
   if (iteration % print_interval_ == 0 || force || end) {
     const double design_area = resizer_->computeDesignArea();
     const double area_growth = design_area - initial_design_area_;
+    double area_growth_percent = std::numeric_limits<double>::infinity();
+    if (std::abs(initial_design_area_) > 0.0) {
+      area_growth_percent = area_growth / initial_design_area_ * 100.0;
+    }
 
     logger_->report("{: >9s} | {: >+8.1f}% | {: >7d} | {: >8d} | {: >9d}",
                     end ? "final" : std::to_string(iteration),
-                    area_growth / initial_design_area_ * 1e2,
+                    area_growth_percent,
                     removed_count_,
                     inserted_count_,
                     remaining);

src/rsz/src/Rebuffer.hh

@@ -139,27 +139,27 @@ class Rebuffer : public sta::dbStaState
 
   Logger* logger_ = nullptr;
   dbNetwork* db_network_ = nullptr;
-  Resizer* resizer_;
-  est::EstimateParasitics* estimate_parasitics_;
+  Resizer* resizer_ = nullptr;
+  est::EstimateParasitics* estimate_parasitics_ = nullptr;
 
   std::vector<BufferSize> buffer_sizes_;
   std::map<LibertyCell*, BufferSize*> buffer_sizes_index_;
 
-  Pin* pin_;
-  float fanout_limit_;
-  float drvr_pin_max_slew_;
-  float drvr_load_high_water_mark_;
+  Pin* pin_ = nullptr;
+  float fanout_limit_ = 0.0f;
+  float drvr_pin_max_slew_ = 0.0f;
+  float drvr_load_high_water_mark_ = 0.0f;
   const Corner* corner_ = nullptr;
   LibertyPort* drvr_port_ = nullptr;
-  Path* arrival_paths_[RiseFall::index_count];
+  Path* arrival_paths_[RiseFall::index_count] = {nullptr};
 
-  int resizer_max_wire_length_;
-  int wire_length_step_;
+  int resizer_max_wire_length_ = 0;
+  int wire_length_step_ = 0;
 
-  double initial_design_area_;
-  int print_interval_;
-  int removed_count_;
-  int inserted_count_;
+  double initial_design_area_ = 0.0;
+  int print_interval_ = 0;
+  int removed_count_ = 0;
+  int inserted_count_ = 0;
 
   // margins in percent
   float slew_margin_ = 20.0f;

src/rsz/src/RecoverPower.cc

@@ -4,6 +4,7 @@
 #include "RecoverPower.hh"
 
 #include <algorithm>
+#include <limits>
 #include <string>
 
 #include "db_sta/dbNetwork.hh"
@@ -470,11 +471,15 @@ void RecoverPower::printProgress(int iteration, bool force, bool end) const
 
     const double design_area = resizer_->computeDesignArea();
     const double area_growth = design_area - initial_design_area_;
+    double area_growth_percent = std::numeric_limits<double>::infinity();
+    if (std::abs(initial_design_area_) > 0.0) {
+      area_growth_percent = area_growth / initial_design_area_ * 100.0;
+    }
 
     logger_->report(
         "{: >9s} | {: >+8.1f}% | {: >8d} | {: >8s} | {}",
         itr_field,
-        area_growth / initial_design_area_ * 1e2,
+        area_growth_percent,
         resize_count_,
         delayAsString(wns, sta_, 3),
         worst_vertex != nullptr ? worst_vertex->name(network_) : "");

src/rsz/src/RepairSetup.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <cmath>
 #include <cstddef>
+#include <limits>
 #include <memory>
 #include <optional>
 #include <sstream>
@@ -740,6 +741,10 @@ void RepairSetup::printProgress(const int iteration,
 
     const double design_area = resizer_->computeDesignArea();
     const double area_growth = design_area - initial_design_area_;
+    double area_growth_percent = std::numeric_limits<double>::infinity();
+    if (std::abs(initial_design_area_) > 0.0) {
+      area_growth_percent = area_growth / initial_design_area_ * 100.0;
+    }
 
     // This actually prints both committed and pending moves, so the moves could
     // could go down if a pass is rejected and restored by the ECO.
@@ -754,7 +759,7 @@ void RepairSetup::printProgress(const int iteration,
             + resizer_->split_load_move_->numMoves(),
         resizer_->clone_move_->numMoves(),
         resizer_->swap_pins_move_->numMoves(),
-        area_growth / initial_design_area_ * 1e2,
+        area_growth_percent,
         delayAsString(wns, sta_, 3),
         delayAsString(tns, sta_, 1),
         max(0, num_viols),

src/rsz/src/UnbufferMove.cc

@@ -342,7 +342,8 @@ bool UnbufferMove::canRemoveBuffer(Instance* buffer, bool honorDontTouchFixed)
   if (!sdc_->isConstrained(in_pin) && !sdc_->isConstrained(out_pin)
       && (!removed || !sdc_->isConstrained(removed))
       && !sdc_->isConstrained(buffer)) {
-    return !db_net_removed || db_net_survivor->canMergeNet(db_net_removed);
+    return db_net_removed == nullptr
+           || (db_net_survivor && db_net_survivor->canMergeNet(db_net_removed));
   }
   return false;
 }