Merge pull request #8456 from The-OpenROAD-Project-staging/secure-coverity-fix

Fixed coverity issue.

Author: maliberty

src/dbSta/src/dbEditHierarchy.cc

@@ -593,24 +593,22 @@ void dbEditHierarchy::cleanUnusedHierPins(
 }
 
 std::string dbEditHierarchy::makeUniqueName(dbModule* module,
-                                            std::string name,
+                                            std::string_view name,
                                             const char* io_type_str) const
 {
-  std::string base_name = name;
+  std::string base_name;
   if (io_type_str) {
     base_name = fmt::format("{}_{}", name, io_type_str);
+  } else {
+    base_name = name;
   }
 
   std::string unique_name = base_name;
   int id = 0;
   while (module->findModBTerm(unique_name.c_str())
          || module->getModNet(unique_name.c_str())) {
     id++;
-    if (io_type_str) {
-      unique_name = fmt::format("{}_{}_{}", name, io_type_str, id);
-    } else {
-      unique_name = fmt::format("{}_{}", base_name, id);
-    }
+    unique_name = fmt::format("{}_{}", base_name, id);
   }
   return unique_name;
 }

src/dbSta/src/dbEditHierarchy.hh

@@ -63,7 +63,7 @@ class dbEditHierarchy
                                dbModITerm*& top_mod_iterm) const;
   void reassociatePinConnection(Pin* pin);
   std::string makeUniqueName(dbModule* module,
-                             std::string name,
+                             std::string_view name,
                              const char* io_type_str = nullptr) const;
 
   // During the addition of new ports and new wiring we may