Merge branch 'The-OpenROAD-Project:master' into gui_timing_widget_bugfix

Author: LucasYuki

.github/workflows/github-actions-lint-tcl.yml

@@ -19,13 +19,13 @@ jobs:
       - name: Install Dependencies
         run: |
           python3 -m venv venv
-          venv/bin/pip install tclint==0.4.2
+          venv/bin/pip install tclint==0.6.1
 
       - name: Lint
         run: |
           source venv/bin/activate
           tclfmt --version
           tclfmt --in-place .
           git diff --exit-code
-          tclint --no-check-style .
+          tclint .
 

BUILD.bazel

@@ -138,11 +138,13 @@ cc_binary(
     name = "openroad",
     srcs = [
         "src/Main.cc",
-        "//bazel:runfiles",
     ],
     copts = OPENROAD_COPTS,
     features = ["-use_header_modules"],
-    malloc = "@tcmalloc//tcmalloc",
+    malloc = select({
+        "@platforms//os:linux": "@tcmalloc//tcmalloc",
+        "@platforms//os:macos": "@bazel_tools//tools/cpp:malloc",
+    }),
     visibility = ["//visibility:public"],
     deps = [
         ":openroad_lib",
@@ -155,6 +157,7 @@ cc_binary(
         "@boost.stacktrace",
         "@rules_cc//cc/runfiles",
         "@tk_tcl//:tcl",
+        "//bazel:runfiles",
     ],
 )
 

bazel/BUILD

@@ -16,4 +16,5 @@ cc_library(
     deps = [
         "@rules_cc//cc/runfiles",
     ],
+    alwayslink = True,
 )

bazel/InitRunFiles.cpp

@@ -6,6 +6,11 @@
 #include <optional>
 #include <string>
 
+#if defined(__APPLE__)
+#include <mach-o/dyld.h>
+#include <sys/param.h>
+#endif
+
 #include "rules_cc/cc/runfiles/runfiles.h"
 
 // Avoid adding any dependencies like boost.filesystem
@@ -19,7 +24,7 @@ static std::optional<std::string> getProgramLocation()
   char result[MAXPATHLEN + 1] = {'\0'};
   uint32_t path_len = MAXPATHLEN;
   if (_NSGetExecutablePath(result, &path_len) != 0) {
-    path_len = readlink("/proc/self/exe", result, MAXPATHLEN);
+    path_len = readlink(result, result, MAXPATHLEN);
   }
 #else
   char result[PATH_MAX + 1] = {'\0'};

etc/DependencyInstaller.sh

@@ -75,8 +75,8 @@ _installCommonDev() {
     spdlogVersion=1.15.0
     gtestVersion=1.13.0
     gtestChecksum="a1279c6fb5bf7d4a5e0d0b2a4adb39ac"
-    abslVersion=20250814.0
-    abslChecksum="016feacd6a6b3b9a47ab844e61f4f7bd"
+    abslVersion=20240722.0
+    abslChecksum="740fb8f35ebdf82740c294bde408b9c0"
     bisonVersion=3.8.2
     bisonChecksum="1e541a097cda9eca675d29dd2832921f"
     flexVersion=2.6.4

src/cts/BUILD

@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2025, The OpenROAD Authors
 
+load("//bazel:python_wrap_cc.bzl", "python_wrap_cc")
 load("//bazel:tcl_encode_or.bzl", "tcl_encode")
 load("//bazel:tcl_wrap_cc.bzl", "tcl_wrap_cc")
-load("//bazel:python_wrap_cc.bzl", "python_wrap_cc")
 
 package(
     default_visibility = ["//:__subpackages__"],
@@ -16,11 +16,9 @@ cc_library(
         "src/Clock.h",
         "src/Clustering.h",
         "src/CtsObserver.h",
-        "src/CtsOptions.h",
         "src/HTreeBuilder.h",
         "src/LevelBalancer.h",
         "src/SinkClustering.h",
-        "src/TechChar.h",
         "src/TreeBuilder.h",
         "src/Util.h",
     ],
@@ -51,7 +49,10 @@ cc_library(
         "src/CtsOptions.h",
         "src/TechChar.h",
     ],
-    includes = ["include", "src"],
+    includes = [
+        "include",
+        "src",
+    ],
     deps = [
         ":private_hdrs",
         "//src/dbSta",
@@ -136,4 +137,4 @@ python_wrap_cc(
     swig_includes = [
         "include",
     ],
-)
+)

src/cts/src/TritonCTS.cpp

@@ -12,6 +12,7 @@
 #include <fstream>
 #include <functional>
 #include <iostream>
+#include <iterator>
 #include <limits>
 #include <map>
 #include <memory>

src/cut/src/blif.cpp

@@ -3,6 +3,7 @@
 
 #include "cut/blif.h"
 
+#include <algorithm>
 #include <fstream>
 #include <iostream>
 #include <iterator>

src/dbSta/src/dbSdcNetwork.cc

@@ -3,14 +3,13 @@
 
 #include "dbSdcNetwork.hh"
 
-#include <spdlog/fmt/fmt.h>
-
 #include <cstddef>
 #include <functional>
 #include <memory>
 #include <string>
 #include <string_view>
 
+#include "spdlog/fmt/fmt.h"
 #include "sta/ParseBus.hh"
 #include "sta/PatternMatch.hh"
 

src/dft/src/utils/BUILD

@@ -29,5 +29,6 @@ cc_library(
         "//src/odb",
         "//src/sta:opensta_lib",
         "//src/utl",
+        "@spdlog",
     ],
 )