Merge pull request #8932 from shinkuan/fix-writespef-coordinates

rcx: fix coordinates option in write_spef

Author: maliberty

src/rcx/src/ext.i

@@ -91,6 +91,9 @@ write_spef(const char* file,
   opts.nets = nets;
   opts.net_id = net_id;
   opts.coordinates= coordinates;
+  if (coordinates) {  
+    opts.N = "Y";
+  }
 
   ext->write_spef(opts);
 }

src/rcx/test/BUILD

@@ -14,6 +14,7 @@ COMPULSORY_TESTS = [
     "generate_pattern",
     "names",
     "net_name_consistency",
+    "coordinates",
 ]
 
 # Disabled in CMakeLists.txt

src/rcx/test/CMakeLists.txt

@@ -7,6 +7,7 @@ or_integration_tests(
     generate_pattern
     names
     net_name_consistency
+    coordinates
   PASSFAIL_TESTS
     rcx_unit_test
 )

src/rcx/test/coordinates.def

@@ -0,0 +1,18 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[INFO ODB-0128] Design: gcd
+[INFO ODB-0130]     Created 54 pins.
+[INFO ODB-0131]     Created 1820 components and 4618 component-terminals.
+[INFO ODB-0132]     Created 2 special nets and 3640 connections.
+[INFO ODB-0133]     Created 350 nets and 978 connections.
+[INFO RCX-0431] Defined process_corner X with ext_model_index 0
+[INFO RCX-0029] Defined extraction corner X
+[INFO RCX-0435] Reading extraction model file 45_patterns.rules ...
+[INFO RCX-0436] RC segment generation gcd (max_merge_res 0.0) ...
+[INFO RCX-0040] Final 2656 rc segments
+[INFO RCX-0439] Coupling Cap extraction gcd ...
+[INFO RCX-0440] Coupling threshhold is 0.1000 fF, coupling capacitance less than 0.1000 fF will be grounded.
+[INFO RCX-0442] 48% of 1954 wires extracted
+[INFO RCX-0442] 100% of 1954 wires extracted
+[INFO RCX-0045] Extract 350 nets, 2972 rsegs, 2972 caps, 2876 ccs
+[INFO RCX-0443] 350 nets finished
+No differences found.

src/rcx/test/coordinates.ok

@@ -0,0 +1,27 @@
+from openroad import Design, Tech
+import rcx_aux
+import helpers
+import via_45_resistance as via_45
+
+test_nets = ""
+
+tech = Tech()
+tech.readLef("Nangate45/Nangate45.lef")
+tech.readLiberty("Nangate45/Nangate45_typ.lib")
+
+design = helpers.make_design(tech)
+design.readDef("coordinates.def")
+
+# Load via resistance info
+via_45.set_resistance(tech)
+
+rcx_aux.define_process_corner(design, ext_model_index=0, filename="X")
+
+rcx_aux.extract_parasitics(
+    design, ext_model_file="45_patterns.rules", max_res=0, coupling_threshold=0.1
+)
+
+spef_file = helpers.make_result_file("coordinates.spef")
+rcx_aux.write_spef(design, filename=spef_file, nets=test_nets, coordinates=True)
+
+helpers.diff_files("coordinates.spefok", spef_file, "^\\*(DATE|VERSION)")