Merge branch 'The-OpenROAD-Project:master' into gui_ruler

Author: LucasYuki

.bazelrc

@@ -16,6 +16,14 @@ build --cxxopt "-std=c++20"        --host_cxxopt "-std=c++20"
 build --cxxopt "-xc++"             --host_cxxopt "-xc++"
 build --cxxopt "-DBAZEL_BUILD"     --host_cxxopt "-DBAZEL_BUILD"
 
+# Default to optimized build (-c opt), O3
+build -c opt
+build:opt --copt=-O3
+
+# Enable Full-LTO (Link Time Optimization)
+build:opt --copt=-flto
+build:opt --linkopt=-flto
+
 # Needed for floating point stability in FFT (fft_test will check this).
 # See also https://kristerw.github.io/2021/11/09/fp-contract/
 build --cxxopt "-ffp-contract=off" --host_cxxopt "-ffp-contract=off"

CMakeLists.txt

@@ -108,6 +108,51 @@ message(STATUS "C++ Standard: ${CMAKE_CXX_STANDARD}")
 message(STATUS "C++ Standard Required: ${CMAKE_CXX_STANDARD_REQUIRED}")
 message(STATUS "C++ Extensions: ${CMAKE_CXX_EXTENSIONS}")
 
+# Detect OS distribution and version from /etc/os-release
+# LTO is known to cause build errors on Debian 11 and Rocky Linux 8
+set(LTO_UNSUPPORTED_OS FALSE)
+if(EXISTS "/etc/os-release")
+  file(STRINGS "/etc/os-release" OS_RELEASE_CONTENTS)
+  set(OS_ID "")
+  set(OS_VERSION_ID "")
+  foreach(line ${OS_RELEASE_CONTENTS})
+    if(line MATCHES "^ID=(.*)$")
+      string(REGEX REPLACE "^ID=\"?([^\"]*)\"?$" "\\1" OS_ID "${line}")
+    endif()
+    if(line MATCHES "^VERSION_ID=(.*)$")
+      string(REGEX REPLACE "^VERSION_ID=\"?([^\"]*)\"?$" "\\1" OS_VERSION_ID "${line}")
+    endif()
+  endforeach()
+
+  # Check for unsupported OS for LTO
+  if((OS_ID STREQUAL "debian" AND OS_VERSION_ID STREQUAL "11") OR
+     (OS_ID STREQUAL "rocky" AND OS_VERSION_ID MATCHES "^8"))
+    set(LTO_UNSUPPORTED_OS TRUE)
+    message(STATUS "Detected unsupported OS (${OS_ID} ${OS_VERSION_ID}): LTO will be disabled due to known build issues")
+  endif()
+endif()
+
+option(LINK_TIME_OPTIMIZATION "Flag to control link time optimization: on by default" ON)
+set(LTO_STATUS "disabled")
+if (LINK_TIME_OPTIMIZATION AND NOT LTO_UNSUPPORTED_OS)
+  include(CheckIPOSupported)
+  check_ipo_supported(RESULT lto_supported OUTPUT lto_error)
+  if(lto_supported)
+    # LTO is enabled globally for Release build
+    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASE TRUE)
+    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELWITHDEBINFO FALSE)
+    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_DEBUG FALSE)
+
+    string(TOUPPER "${CMAKE_BUILD_TYPE}" UPPER_BUILD_TYPE)
+    if(UPPER_BUILD_TYPE STREQUAL "RELEASE")
+      set(LTO_STATUS "enabled")
+    endif()
+  else()
+    set(LTO_STATUS "not supported: ${lto_error}")
+  endif()
+endif()
+message(STATUS "LTO/IPO is ${LTO_STATUS}")
+
 # configure a header file to pass some of the CMake settings
 configure_file(
   ${OPENROAD_HOME}/include/ord/Version.hh.cmake

MODULE.bazel

@@ -146,7 +146,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "1e862b169d97dc0fec5db106559640886e7fd7d0",
+    commit = "0d60cb111de10491753102112223fb3799a98369",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -155,10 +155,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-4367-g79b6a48ab",
+    image = "docker.io/openroad/orfs:v3.0-4512-g528ad3d8a",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "0d0dd3d8d346360a71f6325ce776a984c5a6296fc6e51956b53f136e1dd13462",
+    sha256 = "087122e12c90edcb3ebfc452a3238417fbc78e1135f5b43feaf7162d885cada1",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -819,7 +819,7 @@ _install_ubuntu_packages() {
     _execute "Installing base packages..." apt-get -y install --no-install-recommends \
         automake autotools-dev binutils bison build-essential ccache clang \
         debhelper devscripts flex g++ gcc git groff lcov libffi-dev libfl-dev \
-        libgomp1 libomp-dev libpcre2-dev libpcre3-dev libreadline-dev pandoc \
+        libgomp1 libomp-dev libpcre2-dev libreadline-dev pandoc \
         pkg-config python3-dev python3-click qt5-image-formats-plugins tcl tcl-dev tcl-tclreadline \
         tcllib unzip wget libyaml-cpp-dev zlib1g-dev tzdata
 
@@ -858,7 +858,7 @@ _install_rhel_packages() {
     _execute "Installing EPEL release..." yum -y install "https://dl.fedoraproject.org/pub/epel/epel-release-latest-${rhel_version}.noarch.rpm"
     _execute "Installing base packages..." yum -y install \
         autoconf automake clang clang-devel gcc gcc-c++ gdb git glibc-devel \
-        libffi-devel libtool llvm llvm-devel llvm-libs make pcre-devel \
+        libffi-devel libtool llvm llvm-devel llvm-libs make \
         pcre2-devel pkg-config pkgconf pkgconf-m4 pkgconf-pkg-config python3 \
         python3-devel python3-pip python3-click qt5-qtbase-devel qt5-qtcharts-devel \
         qt5-qtimageformats readline tcl-devel tcl-tclreadline \
@@ -898,7 +898,7 @@ _install_opensuse_packages() {
     _execute "Installing base packages..." zypper -n install \
         binutils clang gcc gcc11-c++ git groff gzip lcov libffi-devel \
         libgomp1 libomp11-devel libpython3_6m1_0 libqt5-creator libqt5-qtbase \
-        libqt5-qtstyleplugins libstdc++6-devel-gcc8 llvm pandoc pcre-devel \
+        libqt5-qtstyleplugins libstdc++6-devel-gcc8 llvm pandoc \
         pcre2-devel pkg-config python3-devel python3-pip python3-click qimgv readline-devel tcl \
         tcl-devel tcllib wget yaml-cpp-devel zlib-devel
 
@@ -946,7 +946,7 @@ _install_debian_packages() {
     _execute "Installing base packages..." apt-get -y install --no-install-recommends \
         automake autotools-dev binutils bison build-essential clang debhelper \
         devscripts flex g++ gcc git groff lcov libffi-dev libfl-dev libgomp1 \
-        libomp-dev libpcre2-dev libpcre3-dev libreadline-dev "libtcl${tcl_ver}" \
+        libomp-dev libpcre2-dev libreadline-dev "libtcl${tcl_ver}" \
         pandoc pkg-config python3-dev python3-click qt5-image-formats-plugins tcl-dev tcl-tclreadline \
         tcllib unzip wget libyaml-cpp-dev zlib1g-dev tzdata
 

etc/DependencyInstaller.sh

@@ -23,7 +23,7 @@
 #endif
 
 %exception {
-  try { $function }
+  try { $action }
   catch (std::bad_alloc &) {
     fprintf(stderr, "Error: out of memory.");
     abort();

src/Exception-py.i

@@ -25,7 +25,7 @@
 %}
 
 %exception {
-  try { $function }
+  try { $action }
   catch (std::bad_alloc &) {
     fprintf(stderr, "Error: out of memory.");
     abort();

src/Exception.i

@@ -25,21 +25,7 @@ filegroup(
     # but at least it is not a glob of everything and there are
     # per test glob patterns below.
     srcs = [
-        "gcd_sky130.def",
         "helpers.tcl",
-        "merged_spacing.lef",
-        "sky130hs/sky130_fd_sc_hs__tt_025C_1v80.lib",
-        "sky130hs/sky130_fd_sc_hs_merged.lef",
-        "sky130hs/sky130hs.pdn.tcl",
-        "sky130hs/sky130hs.rc",
-        "sky130hs/sky130hs.rcx_rules",
-        "sky130hs/sky130hs.tlef",
-        "sky130hs/sky130hs.tracks",
-        "sky130hs/sky130hs.vars",
-        "sky130hs/sky130hs_ip_global.cfg",
-        "sky130hs/sky130hs_std_cell.lef",
-        "sky130hs/sky130hs_tt.lib",
-        "sw130_random.def",
     ],
 )
 
@@ -55,6 +41,25 @@ filegroup(
                 "ant_check.lef",
                 "ant_check.def",
             ],
+            "check_api1": [
+                "merged_spacing.lef",
+                "sw130_random.def",
+            ],
+            "check_drt1": [
+                "merged_spacing.lef",
+                "sw130_random.def",
+            ],
+            "check_grt1": [
+                "gcd_sky130.def",
+                "sky130hs/sky130hs_tt.lib",
+                "sky130hs/sky130hs_std_cell.lef",
+                "sky130hs/sky130hs.tlef",
+            ],
+            "no-check_grt1": [
+                "gcd_sky130.def",
+                "sky130hs/sky130hs_tt.lib",
+                "sky130hs/sky130hs_std_cell.lef",
+            ],
         }.get(test_name, []),
     )
     for test_name in ALL_TESTS

src/ant/test/BUILD

@@ -16,52 +16,7 @@ filegroup(
     # but at least it is not a glob of everything and there are
     # per test glob patterns below.
     srcs = [
-        "Nangate45/Nangate45.lef",
-        "Nangate45/Nangate45.pdn.tcl",
-        "Nangate45/Nangate45.rc",
-        "Nangate45/Nangate45.rcx_rules",
-        "Nangate45/Nangate45.tracks",
-        "Nangate45/Nangate45.vars",
-        "Nangate45/Nangate45_fast.lib",
-        "Nangate45/Nangate45_lvt.lef",
-        "Nangate45/Nangate45_lvt.lib",
-        "Nangate45/Nangate45_slow.lib",
-        "Nangate45/Nangate45_stdcell.lef",
-        "Nangate45/Nangate45_tech.lef",
-        "Nangate45/Nangate45_typ.lib",
-        "Nangate45/fake_macros.lef",
-        "Nangate45/fake_macros.lib",
-        "Nangate45/fakeram45.cfg",
-        "Nangate45/fakeram45_1024x32.lef",
-        "Nangate45/fakeram45_1024x32.lib",
-        "Nangate45/fakeram45_256x16.lef",
-        "Nangate45/fakeram45_256x16.lib",
-        "Nangate45/fakeram45_512x64.lef",
-        "Nangate45/fakeram45_512x64.lib",
-        "Nangate45/fakeram45_64x32.lef",
-        "Nangate45/fakeram45_64x32.lib",
-        "Nangate45/fakeram45_64x7.lef",
-        "Nangate45/fakeram45_64x7.lib",
-        "Nangate45/fakeram45_64x96.lef",
-        "Nangate45/fakeram45_64x96.lib",
-        "Nangate45/work_around_yosys/cells.v",
-        "asap7/asap7_tech_1x_201209.lef",
-        "asap7/asap7sc7p5t_28_R_1x_220121a.lef",
-        "asap7/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz",
-        "asap7/asap7sc7p5t_AO_RVT_SS_nldm_211120.lib.gz",
-        "asap7/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz",
-        "asap7/asap7sc7p5t_INVBUF_RVT_SS_nldm_220122.lib.gz",
-        "asap7/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz",
-        "asap7/asap7sc7p5t_OA_RVT_SS_nldm_211120.lib.gz",
-        "asap7/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib",
-        "asap7/asap7sc7p5t_SEQ_RVT_SS_nldm_220123.lib",
-        "asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz",
-        "asap7/asap7sc7p5t_SIMPLE_RVT_SS_nldm_211120.lib.gz",
-        "asap7/setRC.tcl",
         "helpers.tcl",
-        "sky130hd/sky130_fd_sc_hd__ss_n40C_1v40.lib",
-        "sky130hd/sky130hd.tlef",
-        "sky130hd/sky130hd_std_cell.lef",
     ],
 )
 
@@ -71,7 +26,27 @@ filegroup(
         srcs = [":regression_resources"] + glob(
             [
                 test_name + "*",
-            ],
+            ] + {
+                "aes_nangate45": [
+                    "Nangate45/Nangate45.lef",
+                    "Nangate45/Nangate45_stdcell.lef",
+                    "Nangate45/Nangate45_typ.lib",
+                ],
+                "countdown_asap7": [
+                    "asap7/asap7_tech_1x_201209.lef",
+                    "asap7/asap7sc7p5t_28_R_1x_220121a.lef",
+                    "asap7/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz",
+                    "asap7/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz",
+                    "asap7/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz",
+                    "asap7/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib",
+                    "asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz",
+                ],
+                "ibex_sky130hd": [
+                    "sky130hd/sky130_fd_sc_hd__ss_n40C_1v40.lib",
+                    "sky130hd/sky130hd.tlef",
+                    "sky130hd/sky130hd_std_cell.lef",
+                ],
+            }.get(test_name, []),
         ),
     )
     for test_name in TESTS

src/cgt/test/BUILD

@@ -109,7 +109,7 @@ function(swig_lib)
       set_property(TARGET ${ARG_NAME} PROPERTY SWIG_COMPILE_OPTIONS -flatstaticmethod)
     endif()
 
-    swig_link_libraries(${ARG_NAME}
+    target_link_libraries(${ARG_NAME}
       PUBLIC
         Python3::Python
     )