Skip to content

Commit 51466fa

Browse files
committed
pdn: remove ordering information
Signed-off-by: Peter Gadfort <[email protected]>
1 parent da4185a commit 51466fa

File tree

8 files changed

+29
-36
lines changed

8 files changed

+29
-36
lines changed

src/pdn/src/connect.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include <cmath>
88
#include <map>
99
#include <memory>
10-
#include <optional>
1110
#include <regex>
1211
#include <set>
1312
#include <tuple>
@@ -399,16 +398,14 @@ bool Connect::startsBelow(const Connect* other) const
399398
return layer0_->getNumber() < other->getLowerLayer()->getNumber();
400399
}
401400

402-
void Connect::report(const std::optional<int>& order) const
401+
void Connect::report() const
403402
{
404403
auto* logger = grid_->getLogger();
405404
auto* block = grid_->getBlock();
406405
const double dbu_per_micron = block->getDbUnitsPerMicron();
407406

408-
logger->report(" Connect layers {} -> {}{}",
409-
layer0_->getName(),
410-
layer1_->getName(),
411-
order.has_value() ? fmt::format(" ({})", *order) : "");
407+
logger->report(
408+
" Connect layers {} -> {}", layer0_->getName(), layer1_->getName());
412409
if (!fixed_generate_vias_.empty() || !fixed_tech_vias_.empty()) {
413410
std::string vias;
414411
for (auto* via : fixed_generate_vias_) {

src/pdn/src/connect.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
#include <map>
77
#include <memory>
8-
#include <optional>
98
#include <set>
109
#include <string>
1110
#include <tuple>
@@ -50,7 +49,7 @@ class Connect
5049
int getSplitCutPitch(odb::dbTechLayer* layer) const;
5150
bool getSplitCutStagger(odb::dbTechLayer* layer) const;
5251

53-
void report(const std::optional<int>& order = {}) const;
52+
void report() const;
5453

5554
odb::dbTechLayer* getLowerLayer() const { return layer0_; }
5655
odb::dbTechLayer* getUpperLayer() const { return layer1_; }

src/pdn/src/grid.cpp

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -453,24 +453,21 @@ void Grid::report() const
453453
}
454454
}
455455
if (!connect_.empty()) {
456-
std::vector<std::pair<Connect*, int>> connect;
456+
std::vector<Connect*> connect;
457457
connect.reserve(connect_.size());
458458
for (const auto& conn : connect_) {
459-
connect.emplace_back(conn.get(), connect.size() + 1);
460-
}
461-
std::ranges::sort(
462-
connect,
463-
[](const std::pair<Connect*, int>& l,
464-
const std::pair<Connect*, int>& r) {
465-
int l_lower = l.first->getLowerLayer()->getRoutingLevel();
466-
int l_upper = l.first->getUpperLayer()->getRoutingLevel();
467-
int r_lower = r.first->getLowerLayer()->getRoutingLevel();
468-
int r_upper = r.first->getUpperLayer()->getRoutingLevel();
469-
return std::tie(l_lower, l_upper) < std::tie(r_lower, r_upper);
470-
});
459+
connect.push_back(conn.get());
460+
}
461+
std::ranges::sort(connect, [](const Connect* l, const Connect* r) {
462+
int l_lower = l->getLowerLayer()->getRoutingLevel();
463+
int l_upper = l->getUpperLayer()->getRoutingLevel();
464+
int r_lower = r->getLowerLayer()->getRoutingLevel();
465+
int r_upper = r->getUpperLayer()->getRoutingLevel();
466+
return std::tie(l_lower, l_upper) < std::tie(r_lower, r_upper);
467+
});
471468
logger->report("Connect:");
472-
for (const auto& [connect, order] : connect) {
473-
connect->report(order);
469+
for (Connect* conn : connect) {
470+
conn->report();
474471
}
475472
}
476473
if (!pin_layers_.empty()) {

src/pdn/test/asap7_M1_M3_followpins_staggered.ok

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Straps:
2525
Offset: 0.0000
2626
Snap to grid: false
2727
Connect:
28-
Connect layers M1 -> M3 (1)
28+
Connect layers M1 -> M3
2929
Split cuts:
3030
Layer: M2 with pitch 1.0000 staggered
3131
[INFO PDN-0001] Inserting grid: Core

src/pdn/test/macros_grid_check.ok

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ Straps:
3535
Offset: 2.5000
3636
Snap to grid: false
3737
Connect:
38-
Connect layers metal1 -> metal4 (1)
39-
Connect layers metal4 -> metal7 (2)
38+
Connect layers metal1 -> metal4
39+
Connect layers metal4 -> metal7
4040
Grid name: sram - dcache.data.data_arrays_0.data_arrays_0_ext.mem
4141
Type: Instance
4242
Halo:

src/pdn/test/power_switch.ok

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ Straps:
4040
Offset: 13.6000
4141
Snap to grid: false
4242
Connect:
43-
Connect layers met1 -> met4 (1)
44-
Connect layers met4 -> met5 (2)
43+
Connect layers met1 -> met4
44+
Connect layers met4 -> met5
4545
Switched power cell: POWER_SWITCH
4646
Control net: nPWRUP
4747
Network type: DAISY

src/pdn/test/region_temp_sensor_different_region_name.ok

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ Straps:
4646
Offset: 13.6000
4747
Snap to grid: false
4848
Connect:
49-
Connect layers met1 -> met4 (1)
50-
Connect layers met4 -> met5 (2)
49+
Connect layers met1 -> met4
50+
Connect layers met4 -> met5
5151
Voltage domain: TemperatureAnalog
5252
Floorplan region: TEMP_ANALOG
5353
Power net: VIN
@@ -89,5 +89,5 @@ Straps:
8989
Offset: 13.6000
9090
Snap to grid: false
9191
Connect:
92-
Connect layers met1 -> met4 (1)
93-
Connect layers met4 -> met5 (2)
92+
Connect layers met1 -> met4
93+
Connect layers met4 -> met5

src/pdn/test/report.ok

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ Straps:
331331
Offset: 2.0000
332332
Snap to grid: false
333333
Connect:
334-
Connect layers metal1 -> metal4 (2)
335-
Connect layers metal4 -> metal7 (1)
336-
Connect layers metal7 -> metal8 (4)
337-
Connect layers metal8 -> metal9 (3)
334+
Connect layers metal1 -> metal4
335+
Connect layers metal4 -> metal7
336+
Connect layers metal7 -> metal8
337+
Connect layers metal8 -> metal9

0 commit comments

Comments
 (0)