Merge pull request #9182 from The-OpenROAD-Project-staging/secure-refactor-insert-buffer

odb: Refactored insert buffer code

Author: maliberty

src/odb/include/odb/db.h

@@ -2239,7 +2239,7 @@ class dbNet : public dbObject
   ///
   /// Get the gdn cap of this net to *gndcap, total cap to *totalcap
   ///
-  void getGndTotalCap(double* gndcap, double* totalcap, double MillerMult);
+  void getGndTotalCap(double* gndcap, double* totalcap, double miller_mult);
 
   ///
   /// merge rsegs before doing exttree
@@ -2314,7 +2314,8 @@ class dbNet : public dbObject
   ///
   /// compact internal capnode number'
   ///
-  void collapseInternalCapNum(FILE* capNodeMap);
+  void collapseInternalCapNum(FILE* cap_node_map);
+
   ///
   /// find max number of cap nodes that are internal
   ///
@@ -2615,7 +2616,7 @@ class dbNet : public dbObject
   ///   contain an irrelevant load.
   ///
   dbInst* insertBufferBeforeLoads(
-      std::set<dbObject*>& load_pins,
+      const std::set<dbObject*>& load_pins,
       const dbMaster* buffer_master,
       const Point* loc = nullptr,
       const char* new_buf_base_name = kDefaultBufBaseName,
@@ -2627,7 +2628,7 @@ class dbNet : public dbObject
   /// Partial-loads buffering with vector load_pins support.
   ///
   dbInst* insertBufferBeforeLoads(
-      std::vector<dbObject*>& load_pins,
+      const std::vector<dbObject*>& load_pins,
       const dbMaster* buffer_master,
       const Point* loc = nullptr,
       const char* new_buf_base_name = kDefaultBufBaseName,
@@ -4200,7 +4201,7 @@ class dbCapNode : public dbObject
 
   /// Add the gndCap to *gndcap and *totalcap, ccCap to *totalcap
   ///
-  void addGndTotalCap(double* gndcap, double* totalcap, double MillerMult);
+  void addGndTotalCap(double* gndcap, double* totalcap, double miller_mult);
 
   ///
   /// Get the gndCap of this capnode to *gndcap and *totalcap
@@ -4210,12 +4211,12 @@ class dbCapNode : public dbObject
   ///
   /// Get the gndCap to *gndcap and *totalcap, ccCap to *totalcap
   ///
-  void getGndTotalCap(double* gndcap, double* totalcap, double MillerMult);
+  void getGndTotalCap(double* gndcap, double* totalcap, double miller_mult);
 
   ///
   /// Add the caps of all corners of CC's from this capnode to *totalcap
   ///
-  void accAllCcCap(double* totalcap, double MillerMult);
+  void accAllCcCap(double* totalcap, double miller_mult);
 
   ///
   /// Set the capacitance of this CapNode segment for this process corner. Value
@@ -4488,12 +4489,12 @@ class dbRSeg : public dbObject
   ///
   /// Get the gdn cap of this RC segment to *gndcap, total cap to *totalcap
   ///
-  void getGndTotalCap(double* gndcap, double* totalcap, double MillerMult);
+  void getGndTotalCap(double* gndcap, double* totalcap, double miller_mult);
 
   ///
   /// Add the gdn cap of this RC segment to *gndcap, total cap to *totalcap
   ///
-  void addGndTotalCap(double* gndcap, double* totalcap, double MillerMult);
+  void addGndTotalCap(double* gndcap, double* totalcap, double miller_mult);
 
   ///
   /// do merge rsegs
@@ -4545,7 +4546,7 @@ class dbRSeg : public dbObject
   /// for this process corner, if foreign,
   /// plus coupling capacitance. Returns value in FF.
   ///
-  double getCapacitance(int corner, double MillerMult);
+  double getCapacitance(int corner, double miller_mult);
 
   ///
   /// Get the CC segs of this RC segment,
@@ -4736,7 +4737,7 @@ class dbCCSeg : public dbObject
   ///
   /// Add the capacitance of all corners of this CC segment to *ttcap
   ///
-  void accAllCcCap(double* ttcap, double MillerMult);
+  void accAllCcCap(double* ttcap, double miller_mult);
 
   ///
   /// Get the capacitance of all corners of this CC segment to *ttcap
@@ -8653,7 +8654,7 @@ class dbModule : public dbObject
   // module.
   void addInst(dbInst* inst);
 
-  dbBlock* getOwner();
+  dbBlock* getOwner() const;
 
   dbSet<dbModInst> getChildren() const;
   dbSet<dbModInst> getModInsts() const;
@@ -8665,9 +8666,9 @@ class dbModule : public dbObject
   dbModBTerm* getModBTerm(uint32_t id);
   dbSet<dbInst> getInsts() const;
 
-  dbModInst* findModInst(const char* name);
-  dbInst* findDbInst(const char* name);
-  dbModBTerm* findModBTerm(const char* name);
+  dbModInst* findModInst(const char* name) const;
+  dbInst* findDbInst(const char* name) const;
+  dbModBTerm* findModBTerm(const char* name) const;
 
   std::vector<dbInst*> getLeafInsts();
 

src/odb/src/db/dbCCSeg.cpp

@@ -113,15 +113,15 @@ double dbCCSeg::getCapacitance(int corner)
   return (*block->cc_val_tbl_)[((seg->getOID() - 1) * cornerCnt) + 1 + corner];
 }
 
-void dbCCSeg::accAllCcCap(double* ttcap, double MillerMult)
+void dbCCSeg::accAllCcCap(double* ttcap, double miller_mult)
 {
   _dbCCSeg* seg = (_dbCCSeg*) this;
   _dbBlock* block = (_dbBlock*) seg->getOwner();
   uint32_t cornerCnt = block->corners_per_block_;
   for (uint32_t ii = 0; ii < cornerCnt; ii++) {
     ttcap[ii]
         += ((*block->cc_val_tbl_)[((seg->getOID() - 1) * cornerCnt) + 1 + ii])
-           * MillerMult;
+           * miller_mult;
   }
 }
 

src/odb/src/db/dbCapNode.cpp

@@ -261,30 +261,30 @@ void dbCapNode::addGndCap(double* gndcap, double* totalcap)
   }
 }
 
-void dbCapNode::accAllCcCap(double* totalcap, double MillerMult)
+void dbCapNode::accAllCcCap(double* totalcap, double miller_mult)
 {
-  if (totalcap == nullptr || MillerMult == 0) {
+  if (totalcap == nullptr || miller_mult == 0) {
     return;
   }
   for (dbCCSeg* cc : getCCSegs()) {
-    cc->accAllCcCap(totalcap, MillerMult);
+    cc->accAllCcCap(totalcap, miller_mult);
   }
 }
 
 void dbCapNode::getGndTotalCap(double* gndcap,
                                double* totalcap,
-                               double MillerMult)
+                               double miller_mult)
 {
   getGndCap(gndcap, totalcap);
-  accAllCcCap(totalcap, MillerMult);
+  accAllCcCap(totalcap, miller_mult);
 }
 
 void dbCapNode::addGndTotalCap(double* gndcap,
                                double* totalcap,
-                               double MillerMult)
+                               double miller_mult)
 {
   addGndCap(gndcap, totalcap);
-  accAllCcCap(totalcap, MillerMult);
+  accAllCcCap(totalcap, miller_mult);
 }
 
 void dbCapNode::getCapTable(double* cap)