Merge pull request #8404 from gadfort/pdn-macro-check

pdn: add check for macro pin access before running power grid generation

Author: maliberty

src/pdn/src/grid.cpp

@@ -1666,6 +1666,63 @@ bool InstanceGrid::isValid() const
   return true;
 }
 
+void InstanceGrid::checkSetup() const
+{
+  Grid::checkSetup();
+
+  // check blockages above pins
+  const auto nets = getNets(startsWithPower());
+  for (auto* iterm : inst_->getITerms()) {
+    if (std::find(nets.begin(), nets.end(), iterm->getNet()) == nets.end()) {
+      continue;
+    }
+    odb::dbTechLayer* top = nullptr;
+    std::set<odb::Rect> boxes;
+    for (auto* mpin : iterm->getMTerm()->getMPins()) {
+      for (auto* box : mpin->getGeometry()) {
+        auto* layer = box->getTechLayer();
+        if (layer == nullptr) {
+          continue;
+        }
+        if (top == nullptr
+            || top->getRoutingLevel() < layer->getRoutingLevel()) {
+          top = layer;
+          boxes.clear();
+        }
+        if (layer == top) {
+          boxes.insert(box->getBox());
+        }
+      }
+    }
+
+    if (top != nullptr) {
+      const int top_idx = top->getNumber();
+      for (auto* master_obs : inst_->getMaster()->getObstructions()) {
+        auto* obs_layer = master_obs->getTechLayer();
+        if (obs_layer == nullptr) {
+          continue;
+        }
+        if (obs_layer->getType() != odb::dbTechLayerType::ROUTING) {
+          continue;
+        }
+        if (obs_layer->getNumber() > top_idx) {
+          for (const auto& pin : boxes) {
+            if (pin.intersects(master_obs->getBox())) {
+              getLogger()->error(
+                  utl::PDN,
+                  6,
+                  "Pins on {} are blocked by obstructions on {} for {}",
+                  top->getName(),
+                  obs_layer->getName(),
+                  inst_->getName());
+            }
+          }
+        }
+      }
+    }
+  }
+}
+
 ////////
 
 BumpGrid::BumpGrid(VoltageDomain* domain,

src/pdn/src/grid.h

@@ -153,7 +153,7 @@ class Grid
 
   virtual bool isReplaceable() const { return false; }
 
-  void checkSetup() const;
+  virtual void checkSetup() const;
 
   void setSwitchedPower(GridSwitchedPower* cell);
 
@@ -251,6 +251,7 @@ class InstanceGrid : public Grid
   bool isReplaceable() const override { return replaceable_; }
 
   virtual bool isValid() const;
+  void checkSetup() const override;
 
   static ShapeVectorMap getInstanceObstructions(odb::dbInst* inst,
                                                 const Halo& halo

src/pdn/test/BUILD

@@ -3,6 +3,7 @@ load("//test:regression.bzl", "regression_test")
 # From CMakeLists.txt or_integration_tests(TESTS
 COMPULSORY_TESTS = [
     "add_double_global_connection",
+    "asap7_failed_macro_covered",
     "asap7_failed_macro_grid",
     "asap7_no_via_generate",
     "asap7_no_via_generate_v1_snapped",
@@ -19,6 +20,7 @@ COMPULSORY_TESTS = [
     "asap7_vias_max_rows_columns",
     "asap7_M1_M3_followpins",
     "asap7_M1_M3_followpins_staggered",
+    "asap7_macro_notcovered",
     "bpin_removal",
     "core_grid",
     "core_grid_adjacentcuts",
@@ -168,6 +170,8 @@ filegroup(
         "Nangate45/work_around_yosys/cells.v",
         "Nangate45_vias/Nangate45_adjacentcuts.lef",
         "asap7_data/fakeram7_256x32.lef",
+        "asap7_data/fakeram7_256x32_covered.lef",
+        "asap7_data/fakeram7_256x32_notcovered.lef",
         "asap7_vias/asap7_tech_1x.lef",
         "asap7_vias/asap7_tech_1x_arrayspacing.lef",
         "asap7_vias/asap7_tech_1x_arrayspacing_tightspacing.lef",
@@ -269,6 +273,8 @@ filegroup(
                 "ihp_ethmac/RM_IHPSG13_1P_256x48_c2_bm_bist.lef",
                 "ihp_ethmac/floorplan.def",
             ],
+            "asap7_failed_macro_covered": ["asap7_failed_macro_grid.def"],
+            "asap7_macro_notcovered": ["asap7_failed_macro_grid.def"],
         }.get(test_name, []),
     )
     for test_name in ALL_TESTS

src/pdn/test/CMakeLists.txt

@@ -2,6 +2,7 @@ or_integration_tests(
   "pdn"
   TESTS
     add_double_global_connection
+    asap7_failed_macro_covered
     asap7_failed_macro_grid
     asap7_no_via_generate
     asap7_no_via_generate_v1_snapped
@@ -18,6 +19,7 @@ or_integration_tests(
     asap7_vias_max_rows_columns
     asap7_M1_M3_followpins
     asap7_M1_M3_followpins_staggered
+    asap7_macro_notcovered
     bpin_removal
     core_grid
     core_grid_adjacentcuts