Skip to content

Commit 58e0a3e

Browse files
committed
gpl: clang-tidy
Signed-off-by: Augusto Berndt <[email protected]>
1 parent 0fbef1a commit 58e0a3e

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

src/gpl/src/nesterovBase.cpp

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2461,16 +2461,11 @@ void NesterovBase::updateGradients(std::vector<FloatPoint>& sumGrads,
24612461
FloatPoint densityPrecondi = getDensityPreconditioner(gCell);
24622462

24632463
FloatPoint sumPrecondi(
2464-
wireLengthPreCondi.x + densityPenalty_ * densityPrecondi.x,
2465-
wireLengthPreCondi.y + densityPenalty_ * densityPrecondi.y);
2464+
wireLengthPreCondi.x + (densityPenalty_ * densityPrecondi.x),
2465+
wireLengthPreCondi.y + (densityPenalty_ * densityPrecondi.y));
24662466

2467-
if (sumPrecondi.x <= npVars_->minPreconditioner) {
2468-
sumPrecondi.x = npVars_->minPreconditioner;
2469-
}
2470-
2471-
if (sumPrecondi.y <= npVars_->minPreconditioner) {
2472-
sumPrecondi.y = npVars_->minPreconditioner;
2473-
}
2467+
sumPrecondi.x = std::max(sumPrecondi.x, npVars_->minPreconditioner);
2468+
sumPrecondi.y = std::max(sumPrecondi.y, npVars_->minPreconditioner);
24742469

24752470
sumGrads[i].x /= sumPrecondi.x;
24762471
sumGrads[i].y /= sumPrecondi.y;
@@ -2573,16 +2568,11 @@ void NesterovBase::updateSingleGradient(
25732568
FloatPoint densityPrecondi = getDensityPreconditioner(gCell);
25742569

25752570
FloatPoint sumPrecondi(
2576-
wireLengthPreCondi.x + densityPenalty_ * densityPrecondi.x,
2577-
wireLengthPreCondi.y + densityPenalty_ * densityPrecondi.y);
2571+
wireLengthPreCondi.x + (densityPenalty_ * densityPrecondi.x),
2572+
wireLengthPreCondi.y + (densityPenalty_ * densityPrecondi.y));
25782573

2579-
if (sumPrecondi.x <= npVars_->minPreconditioner) {
2580-
sumPrecondi.x = npVars_->minPreconditioner;
2581-
}
2582-
2583-
if (sumPrecondi.y <= npVars_->minPreconditioner) {
2584-
sumPrecondi.y = npVars_->minPreconditioner;
2585-
}
2574+
sumPrecondi.x = std::max(sumPrecondi.x, npVars_->minPreconditioner);
2575+
sumPrecondi.y = std::max(sumPrecondi.y, npVars_->minPreconditioner);
25862576

25872577
sumGrads[gCellIndex].x /= sumPrecondi.x;
25882578
sumGrads[gCellIndex].y /= sumPrecondi.y;
@@ -2597,11 +2587,11 @@ void NesterovBase::updateInitialPrevSLPCoordi()
25972587

25982588
float prevCoordiX
25992589
= curSLPCoordi_[i].x
2600-
- npVars_->initialPrevCoordiUpdateCoef * curSLPSumGrads_[i].x;
2590+
- (npVars_->initialPrevCoordiUpdateCoef * curSLPSumGrads_[i].x);
26012591

26022592
float prevCoordiY
26032593
= curSLPCoordi_[i].y
2604-
- npVars_->initialPrevCoordiUpdateCoef * curSLPSumGrads_[i].y;
2594+
- (npVars_->initialPrevCoordiUpdateCoef * curSLPSumGrads_[i].y);
26052595

26062596
FloatPoint newCoordi(getDensityCoordiLayoutInsideX(curGCell, prevCoordiX),
26072597
getDensityCoordiLayoutInsideY(curGCell, prevCoordiY));

0 commit comments

Comments
 (0)