Applied review feedback.

Signed-off-by: Jaehyun Kim <[email protected]>

Author: jhkim-pii

src/rsz/src/Resizer.cc

@@ -777,10 +777,6 @@ void Resizer::bufferInputs(LibertyCell* buffer_cell, bool verbose)
 
   // Use buffer_cell. If it is null, find the buffer w/ lowest drive resistance.
   LibertyCell* selected_buffer_cell = selectBufferCell(buffer_cell);
-  if (selected_buffer_cell == nullptr) {
-    return;
-  }
-
   if (verbose) {
     logger_->info(RSZ,
                   29,
@@ -1026,10 +1022,6 @@ void Resizer::bufferOutputs(LibertyCell* buffer_cell, bool verbose)
 
   // Use buffer_cell. If it is null, find the buffer w/ lowest drive resistance.
   LibertyCell* selected_buffer_cell = selectBufferCell(buffer_cell);
-  if (selected_buffer_cell == nullptr) {
-    return;
-  }
-
   if (verbose) {
     logger_->info(RSZ,
                   31,

src/rsz/src/Resizer.tcl

@@ -10,7 +10,7 @@ proc get_db_tech_checked { } {
   return $tech
 }
 
-proc parse_buffer_cell { keys_var required } {
+proc parse_buffer_cell { keys_var } {
   upvar 1 $keys_var keys
   set buffer_cell "NULL"
 
@@ -25,12 +25,6 @@ proc parse_buffer_cell { keys_var required } {
       }
     }
   }
-
-  # required argument is missing?
-  if { $buffer_cell == "NULL" && $required } {
-    utl::error RSZ 212 "-buffer_cell is required for buffer insertion."
-  }
-
   return $buffer_cell
 }
 
@@ -489,7 +483,7 @@ proc buffer_ports { args } {
   sta::check_argc_eq0 "buffer_ports" $args
 
   rsz::set_max_utilization [rsz::parse_max_util keys]
-  set buffer_cell [rsz::parse_buffer_cell keys 0] ;# 0: optional argument
+  set buffer_cell [rsz::parse_buffer_cell keys]
 
   if { $buffer_inputs } {
     rsz::buffer_inputs $buffer_cell $verbose

src/rsz/test/buffer_ports10.tcl

@@ -1,4 +1,4 @@
-# buffer output with assign between output ports
+# buffer input/output ports with detailed messages
 source "helpers.tcl"
 source Nangate45/Nangate45.vars
 read_liberty Nangate45/Nangate45_typ.lib

src/rsz/test/buffer_ports9.tcl

@@ -1,4 +1,4 @@
-# buffer output with assign between output ports
+# buffer input/output ports with the specified buffer cell
 source "helpers.tcl"
 source Nangate45/Nangate45.vars
 read_liberty Nangate45/Nangate45_typ.lib