Merge pull request #8446 from gadfort/pdn-check-macros

maliberty · web-flow · commit 5e4e7f0147e6 · 2025-09-28T04:03:22.000Z
pdn: add check in macro grid setup
diff --git a/src/pdn/src/pdn.tcl b/src/pdn/src/pdn.tcl
@@ -1024,6 +1024,11 @@ proc define_pdn_grid_macro { args } {
         utl::error PDN 1030 "Unable to find instance: $inst_pattern"
       }
       foreach inst $sub_insts {
+        if { ![$inst isFixed] } {
+          utl::warn PDN 1050 \
+            "Ignoring non-fixed instance for grid (${keys(-name)}): [$inst getName]"
+          continue
+        }
         lappend insts $inst
       }
     }
@@ -1049,9 +1054,16 @@ proc define_pdn_grid_macro { args } {
   } else {
     set cells {}
     foreach cell_pattern $keys(-cells) {
-      foreach cell [get_masters $cell_pattern] {
+      set sub_cells [get_masters $cell_pattern]
+      if { [llength $sub_cells] == 0 } {
+        utl::warn PDN 1031 "Unable to find cells: $cell_pattern"
+      }
+      foreach cell $sub_cells {
         # only add blocks
         if { ![$cell isBlock] } {
+          if { !$default_grid } {
+            utl::warn PDN 1041 "Ignoring non-block cell for grid (${keys(-name)}): [$cell getName]"
+          }
           continue
         }
         lappend cells $cell
diff --git a/src/pdn/test/BUILD b/src/pdn/test/BUILD
@@ -79,6 +79,7 @@ COMPULSORY_TESTS = [
     "macros_cells_overlapping_ports",
     "macros_cells_via_failure",
     "macros_different_nets",
+    "macros_grid_check",
     "macros_grid_through",
     "macros_grid_through_without_middle",
     "macros_narrow_channel",
diff --git a/src/pdn/test/CMakeLists.txt b/src/pdn/test/CMakeLists.txt
@@ -78,6 +78,7 @@ or_integration_tests(
     macros_cells_overlapping_ports
     macros_cells_via_failure
     macros_different_nets
+    macros_grid_check
     macros_grid_through
     macros_grid_through_without_middle
     macros_narrow_channel
diff --git a/src/pdn/test/asap7_failed_macro_covered.tcl b/src/pdn/test/asap7_failed_macro_covered.tcl
@@ -18,7 +18,7 @@ add_pdn_connect -grid {top} -layers {M2 M5}
 add_pdn_connect -grid {top} -layers {M5 M6}
 
 define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
-  -orient {R0 R180 MX MY} -cells {.*}
+  -orient {R0 R180 MX MY} -cells {fake.*}
 add_pdn_connect -grid {CORE_macro_grid_1} -layers {M4 M5}
 
 catch { pdngen } err
diff --git a/src/pdn/test/asap7_failed_macro_grid.tcl b/src/pdn/test/asap7_failed_macro_grid.tcl
@@ -18,7 +18,7 @@ add_pdn_connect -grid {top} -layers {M2 M5}
 add_pdn_connect -grid {top} -layers {M5 M6}
 
 define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
-  -orient {R0 R180 MX MY} -cells {.*}
+  -orient {R0 R180 MX MY} -cells {fake.*}
 add_pdn_connect -grid {CORE_macro_grid_1} -layers {M4 M5}
 
 catch { pdngen } err
diff --git a/src/pdn/test/asap7_macro_notcovered.tcl b/src/pdn/test/asap7_macro_notcovered.tcl
@@ -18,7 +18,7 @@ add_pdn_connect -grid {top} -layers {M2 M5}
 add_pdn_connect -grid {top} -layers {M5 M6}
 
 define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
-  -orient {R0 R180 MX MY} -cells {.*}
+  -orient {R0 R180 MX MY} -cells {fake.*}
 add_pdn_stripe -grid {CORE_macro_grid_1} -layer {M5} -width {0.12} -spacing {0.072} -pitch {11.88} \
   -offset {0.300}
 add_pdn_connect -grid {CORE_macro_grid_1} -layers {M4 M5}
diff --git a/src/pdn/test/macros_cells_via_failure.tcl b/src/pdn/test/macros_cells_via_failure.tcl
@@ -34,7 +34,7 @@ add_pdn_connect -grid {grid} -layers {metal4 metal7}
 # grid for: CORE_macro_grid_1
 ####################################
 define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
-  -orient {R0 R180 MX MY} -halo {2.0 2.0 2.0 2.0} -cells {.*}
+  -orient {R0 R180 MX MY} -halo {2.0 2.0 2.0 2.0} -cells {fake.*}
 add_pdn_stripe -grid {CORE_macro_grid_1} -layer {metal5} -width {0.93} -pitch {10.0} -offset {2}
 add_pdn_stripe -grid {CORE_macro_grid_1} -layer {metal6} -width {0.93} -pitch {10.0} -offset {2}
 add_pdn_connect -grid {CORE_macro_grid_1} -layers {metal4 metal5}
@@ -44,7 +44,7 @@ add_pdn_connect -grid {CORE_macro_grid_1} -layers {metal6 metal7}
 # grid for: CORE_macro_grid_2
 ####################################
 define_pdn_grid -name {CORE_macro_grid_2} -voltage_domains {CORE} -macro \
-  -orient {R90 R270 MXR90 MYR90} -halo {2.0 2.0 2.0 2.0} -cells {.*}
+  -orient {R90 R270 MXR90 MYR90} -halo {2.0 2.0 2.0 2.0} -cells {fake.*}
 add_pdn_stripe -grid {CORE_macro_grid_2} -layer {metal6} -width {0.93} -pitch {40.0} -offset {2}
 add_pdn_connect -grid {CORE_macro_grid_2} -layers {metal4 metal6}
 add_pdn_connect -grid {CORE_macro_grid_2} -layers {metal6 metal7}
diff --git a/src/pdn/test/macros_grid_check.ok b/src/pdn/test/macros_grid_check.ok
@@ -0,0 +1,46 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[INFO ODB-0227] LEF file: nangate_macros/fakeram45_64x32.lef, created 1 library cells
+[INFO ODB-0128] Design: RocketTile
+[INFO ODB-0130]     Created 269 pins.
+[INFO ODB-0131]     Created 547 components and 1304 component-terminals.
+[INFO ODB-0132]     Created 2 special nets and 1094 connections.
+[INFO ODB-0133]     Created 269 nets and 0 connections.
+[WARNING PDN-1031] Unable to find cells: fakeram45_64x55
+[WARNING PDN-1050] Ignoring non-fixed instance for grid (sram): dcache.data.data_arrays_0.data_arrays_0_ext.mem_10
+Voltage domain: Core
+  Power net: VDD
+  Ground net: VSS
+Grid name: Core
+Type: Core
+Straps:
+  Type: Followpin
+    Layer: metal1
+    Width: 0.1700
+    Spacing: 0.0000
+    Pitch: 2.8000
+    Offset: 0.0000
+    Snap to grid: false
+  Type: Strap
+    Layer: metal4
+    Width: 0.4800
+    Spacing: 4.0000
+    Pitch: 49.0000
+    Offset: 2.5000
+    Snap to grid: false
+  Type: Strap
+    Layer: metal7
+    Width: 1.4000
+    Spacing: 18.6000
+    Pitch: 40.0000
+    Offset: 2.5000
+    Snap to grid: false
+Connect:
+  Connect layers metal1 -> metal4
+  Connect layers metal4 -> metal7
+Grid name: sram - dcache.data.data_arrays_0.data_arrays_0_ext.mem
+Type: Instance
+Halo:
+  Left: 0.0000
+  Bottom: 0.0000
+  Right: 0.0000
+  Top: 0.0000
diff --git a/src/pdn/test/macros_grid_check.tcl b/src/pdn/test/macros_grid_check.tcl
@@ -0,0 +1,36 @@
+# test for define_pdn_grid -cells
+source "helpers.tcl"
+
+read_lef Nangate45/Nangate45.lef
+read_lef nangate_macros/fakeram45_64x32.lef
+
+read_def nangate_macros/floorplan.def
+
+# Create an instance with the same prefix as the macro
+odb::dbInst_create \
+  [ord::get_db_block] \
+  [[ord::get_db] findMaster FILLCELL_X1] \
+  {dcache.data.data_arrays_0.data_arrays_0_ext.mem_10}
+
+add_global_connection -net VDD -pin_pattern {^VDD$} -power
+add_global_connection -net VDD -pin_pattern {^VDDPE$}
+add_global_connection -net VDD -pin_pattern {^VDDCE$}
+add_global_connection -net VSS -pin_pattern {^VSS$} -ground
+add_global_connection -net VSS -pin_pattern {^VSSE$}
+
+set_voltage_domain -power VDD -ground VSS
+
+define_pdn_grid -name "Core"
+add_pdn_stripe -followpins -layer metal1
+
+add_pdn_stripe -layer metal4 -width 0.48 -spacing 4.0 -pitch 49.0 -offset 2.5
+add_pdn_stripe -layer metal7 -width 1.4 -pitch 40.0 -offset 2.5
+
+add_pdn_connect -layers {metal1 metal4}
+add_pdn_connect -layers {metal4 metal7}
+
+define_pdn_grid -macro -name "sram" -cells "fakeram45_64x55"
+
+define_pdn_grid -macro -name "sram" -instances "dcache.data.data_arrays_0.data_arrays_0_ext.mem"
+
+pdngen -report_only
diff --git a/src/pdn/test/names.ok b/src/pdn/test/names.ok
@@ -14,6 +14,6 @@
 PDN-0184
 [ERROR PDN-1043] Grid named "Core" already defined.
 PDN-1043
-[WARNING PDN-0231] cmp1 is not connected to any power/ground nets.
-[WARNING PDN-0231] cmp1 is not connected to any power/ground nets.
+[WARNING PDN-1050] Ignoring non-fixed instance for grid (Inst): cmp1
+[WARNING PDN-1050] Ignoring non-fixed instance for grid (Inst): cmp1
 PDN-1043
