incorporated code review feedback from Martin

1) removed new doMove from BaseMove class
2) removed extra slack check from traverseFaninCone

Signed-off-by: Cho Moon <[email protected]>

Author: precisionmoon

src/rsz/src/BaseMove.hh

@@ -115,12 +115,6 @@ class BaseMove : public sta::dbStaState
     return false;
   }
 
-  virtual bool doMove(Instance* drvr,
-                      std::unordered_set<Instance*>& unSwappable)
-  {
-    return false;
-  }
-
   virtual const char* name() = 0;
 
   void init();

src/rsz/src/RepairSetup.cc

@@ -1067,7 +1067,7 @@ bool RepairSetup::swapVTCritCells(const OptoParams& params, int& num_viols)
 
   // Do VT swap on critical instances for now
   // Other transforms can follow later
-  BaseMove* move = resizer_->vt_swap_speed_move_.get();
+  VTSwapSpeedMove* move = resizer_->vt_swap_speed_move_.get();
   for (auto crit_inst_slack : crit_insts) {
     if (move->doMove(crit_inst_slack.first, notSwappable)) {
       changed = true;
@@ -1139,7 +1139,7 @@ void RepairSetup::traverseFaninCone(
         if (inst_slack < params.setup_slack_margin) {
           // Update worst slack for this instance
           auto it = crit_insts.find(inst);
-          if (it == crit_insts.end() || inst_slack < it->second) {
+          if (it == crit_insts.end()) {
             crit_insts[inst] = inst_slack;
             endpoint_insts++;
             debugPrint(logger_,

src/rsz/src/VTSwapMove.hh

@@ -18,8 +18,7 @@ class VTSwapSpeedMove : public BaseMove
               PathExpanded* expanded,
               float setup_slack_margin) override;
 
-  bool doMove(Instance* drvr,
-              std::unordered_set<Instance*>& notSwappable) override;
+  bool doMove(Instance* drvr, std::unordered_set<Instance*>& notSwappable);
 
   const char* name() override { return "VTSwapSpeed"; }