Merge pull request #2691 from The-OpenROAD-Project-staging/rcx-coverity

maliberty · web-flow · commit 6371989b2554 · 2023-01-02T10:40:42.000-08:00
rcx: fix coverity warnings
diff --git a/src/rcx/src/extFlow.cpp b/src/rcx/src/extFlow.cpp
@@ -1613,6 +1613,10 @@ uint extMain::couplingFlow(Rect& extRect,
     _geomSeq = NULL;
   }
 
+  for (uint jj = 0; jj < layerCnt; jj++)
+    delete[] limitArray[jj];
+  delete[] limitArray;
+
   return 0;
 }
 
diff --git a/src/rcx/src/extRCap.cpp b/src/rcx/src/extRCap.cpp
@@ -335,7 +335,6 @@ uint extMain::printNetStats(FILE* fp,
     if ((type == dbSigType::POWER) || (type == dbSigType::GROUND)) {
       if (skipPower)
         continue;
-      continue;
     }
     if (!net->isEnclosed(&bbox))
       continue;
diff --git a/src/rcx/src/extSpef.cpp b/src/rcx/src/extSpef.cpp
@@ -1398,7 +1398,7 @@ bool extSpef::closeOutFile()
     return false;
 
   if (_gzipFlag)
-    fclose(_outFP);
+    pclose(_outFP);
   else
     fclose(_outFP);
 
diff --git a/src/rcx/src/extSpefIn.cpp b/src/rcx/src/extSpefIn.cpp
@@ -1598,7 +1598,6 @@ uint extSpef::sortRSegs()
     rc = _nrseg->get(tridx);
     tgtCapn = rc->getTargetNode();
     tgtCapNode = dbCapNode::getCapNode(_cornerBlock, tgtCapn);
-    zcfound = false;
     srcCapn = rc->getSourceNode();
     int srcCapidx
         = dbCapNode::getCapNode(_cornerBlock, srcCapn)->getSortIndex() - 1;
@@ -1627,7 +1626,6 @@ uint extSpef::sortRSegs()
         x1 = Ath__double2int(_nodeCoordFactor * _xCoordTable->get(ncidx));
         y1 = Ath__double2int(_nodeCoordFactor * _yCoordTable->get(ncidx));
         rc->setCoords(x1, y1);
-        zcfound = true;
       } else {
         logger_->warn(
             RCX,
diff --git a/src/rcx/src/extmeasure.cpp b/src/rcx/src/extmeasure.cpp
@@ -3033,8 +3033,6 @@ void extMeasure::getDgOverlap(SEQ* sseq,
     return;
   }
 
-  if (_rsegSrcId > 0)
-    dbRSeg::getRSeg(_block, _rsegSrcId);
   for (; idx < (int) dgContext->getCnt(); idx++) {
     tseq = dgContext->get(idx);
     if (tseq->_ur[lp] <= covered)
diff --git a/src/rcx/src/extmeasure_res.cpp b/src/rcx/src/extmeasure_res.cpp
@@ -450,8 +450,6 @@ void extMeasure::getDgOverlap_res(SEQ* sseq,
     return;
   }
 
-  if (_rsegSrcId > 0)
-    dbRSeg::getRSeg(_block, _rsegSrcId);
   for (; idx < (int) dgContext->getCnt(); idx++) {
     tseq = dgContext->get(idx);
     if (tseq->_ur[lp] <= covered)

Original file line number	Diff line number	Diff line change
`@@ -1613,6 +1613,10 @@ uint extMain::couplingFlow(Rect& extRect,`
`1613`	`1613`	`_geomSeq = NULL;`
`1614`	`1614`	`}`
`1615`	`1615`
	`1616`	`+ for (uint jj = 0; jj < layerCnt; jj++)`
	`1617`	`+ delete[] limitArray[jj];`
	`1618`	`+ delete[] limitArray;`
	`1619`	`+`
`1616`	`1620`	`return 0;`
`1617`	`1621`	`}`
`1618`	`1622`
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,6 @@ uint extMain::printNetStats(FILE* fp,`
`335`	`335`	`if ((type == dbSigType::POWER) \|\| (type == dbSigType::GROUND)) {`
`336`	`336`	`if (skipPower)`
`337`	`337`	`continue;`
`338`		`- continue;`
`339`	`338`	`}`
`340`	`339`	`if (!net->isEnclosed(&bbox))`
`341`	`340`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -3033,8 +3033,6 @@ void extMeasure::getDgOverlap(SEQ* sseq,`
`3033`	`3033`	`return;`
`3034`	`3034`	`}`
`3035`	`3035`
`3036`		`- if (_rsegSrcId > 0)`
`3037`		`- dbRSeg::getRSeg(_block, _rsegSrcId);`
`3038`	`3036`	`for (; idx < (int) dgContext->getCnt(); idx++) {`
`3039`	`3037`	`tseq = dgContext->get(idx);`
`3040`	`3038`	`if (tseq->_ur[lp] <= covered)`
Original file line number	Diff line number	Diff line change
`@@ -450,8 +450,6 @@ void extMeasure::getDgOverlap_res(SEQ* sseq,`
`450`	`450`	`return;`
`451`	`451`	`}`
`452`	`452`
`453`		`- if (_rsegSrcId > 0)`
`454`		`- dbRSeg::getRSeg(_block, _rsegSrcId);`
`455`	`453`	`for (; idx < (int) dgContext->getCnt(); idx++) {`
`456`	`454`	`tseq = dgContext->get(idx);`
`457`	`455`	`if (tseq->_ur[lp] <= covered)`