Fixed coverity issues

Signed-off-by: Jaehyun Kim <[email protected]>

Author: jhkim-pii

src/rsz/test/cpp/TestBufferRemoval3.cc

@@ -100,7 +100,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase5)
@@ -167,7 +167,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase4)
@@ -295,7 +295,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase3)
@@ -383,7 +383,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase2)
@@ -460,7 +460,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase1)
@@ -541,7 +541,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 TEST_F(BufRemTest3, RemoveBufferCase0)
@@ -629,7 +629,7 @@ endmodule
   }
 
   // Clean up
-  std::remove(after_vlog_path.c_str());
+  removeFile(after_vlog_path);
 }
 
 }  // namespace rsz

src/tst/include/tst/IntegratedFixture.h

@@ -32,6 +32,7 @@ class IntegratedFixture : public tst::Fixture
  protected:
   void readVerilogAndSetup(const std::string& verilog_file);
   void dumpVerilogAndOdb(const std::string& name) const;
+  void removeFile(const std::string& path);
 
  protected:
   odb::dbLib* lib_;

src/tst/src/IntegratedFixture.cpp

@@ -89,11 +89,15 @@ void IntegratedFixture::readVerilogAndSetup(const std::string& verilog_file)
   sta::Pin* clk_pin
       = db_network_->findPin(db_network_->topInstance(), clk_port);
 
+  // STA frees the 'clk_pins' after use.
+  // coverity[RESOURCE_LEAK: FALSE_POSITIVE]
   sta::PinSet* clk_pins = new sta::PinSet(db_network_);
   clk_pins->insert(clk_pin);
 
   // Clock period = 0.5ns
   double period = sta_->units()->timeUnit()->userToSta(0.5);
+  // STA takes the ownership of 'waveform'.
+  // coverity[RESOURCE_LEAK: FALSE_POSITIVE]
   sta::FloatSeq* waveform = new sta::FloatSeq;
   waveform->push_back(0);
   waveform->push_back(period / 2.0);
@@ -164,4 +168,11 @@ void IntegratedFixture::dumpVerilogAndOdb(const std::string& name) const
   orig_odb_file.close();
 }
 
+void IntegratedFixture::removeFile(const std::string& path)
+{
+  if (std::remove(path.c_str()) != 0) {
+    logger_.warn(utl::RSZ, 0, "Could not remove '{}'.", path);
+  }
+}
+
 }  // namespace tst