clang-tidy requested changes

osamahammad21 · osamahammad21 · commit 6cebb8baea39 · 2025-08-25T21:51:55.000+03:00
Signed-off-by: osamahammad21 &lt;osama21@aucegypt.edu&gt;
diff --git a/src/odb/include/odb/db.h b/src/odb/include/odb/db.h
@@ -7145,7 +7145,8 @@ class dbChipNet : public dbObject
 
   dbChipBumpInst* getBumpInst(uint index, std::vector<dbChipInst*>& path) const;
 
-  void addBumpInst(dbChipBumpInst* bump_inst, std::vector<dbChipInst*> path);
+  void addBumpInst(dbChipBumpInst* bump_inst,
+                   const std::vector<dbChipInst*>& path);
 
   static dbChipNet* create(dbChip* chip, const std::string& name);
 
diff --git a/src/odb/src/db/dbChipNet.cpp b/src/odb/src/db/dbChipNet.cpp
@@ -134,13 +134,14 @@ dbChipBumpInst* dbChipNet::getBumpInst(uint index,
 }
 
 void dbChipNet::addBumpInst(dbChipBumpInst* bump_inst,
-                            std::vector<dbChipInst*> path)
+                            const std::vector<dbChipInst*>& path)
 {
   _dbChipNet* obj = (_dbChipNet*) this;
 
   std::vector<dbId<_dbChipInst>> path_ids;
-  for (dbChipInst* inst : path) {
-    path_ids.push_back(inst->getImpl()->getOID());
+  path_ids.reserve(path.size());
+  for (const auto& inst : path) {
+    path_ids.emplace_back(inst->getImpl()->getOID());
   }
 
   obj->bump_insts_paths_.emplace_back(std::move(path_ids),

Original file line number	Diff line number	Diff line change
`@@ -134,13 +134,14 @@ dbChipBumpInst* dbChipNet::getBumpInst(uint index,`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`void dbChipNet::addBumpInst(dbChipBumpInst* bump_inst,`
`137`		`- std::vector<dbChipInst*> path)`
	`137`	`+ const std::vector<dbChipInst*>& path)`
`138`	`138`	`{`
`139`	`139`	`_dbChipNet* obj = (_dbChipNet*) this;`
`140`	`140`
`141`	`141`	`std::vector<dbId<_dbChipInst>> path_ids;`
`142`		`- for (dbChipInst* inst : path) {`
`143`		`- path_ids.push_back(inst->getImpl()->getOID());`
	`142`	`+ path_ids.reserve(path.size());`
	`143`	`+ for (const auto& inst : path) {`
	`144`	`+ path_ids.emplace_back(inst->getImpl()->getOID());`
`144`	`145`	`}`
`145`	`146`
`146`	`147`	`obj->bump_insts_paths_.emplace_back(std::move(path_ids),`