Merge remote-tracking branch 'private/master' into gpl-fix-code-scan-defects

Author: gudeh

.bazelrc

@@ -70,9 +70,31 @@ build --incompatible_strict_action_env
 
 test --build_tests_only
 
-# TODO: setup a new cache for OpenROAD
-# Read only remote cache, updated by OpenROAD team members and CI.
-#build --remote_cache=https://storage.googleapis.com/megaboom-bazel-artifacts
-#build --remote_cache_compression=true
+# --- Performance Optimizations ---
+# Use a high number of jobs and let the scheduler manage concurrency
+build --jobs=200
+
+# Enable local disk caching to supplement the remote cache.
+build --disk_cache=~/.cache/bazel-disk-cache
+build --repository_cache=~/.cache/bazel-repository-cache
+
+# --- CI Settings (write access) ---
+build:ci --remote_cache=https://storage.googleapis.com/openroad-bazel-cache
+build:ci --remote_cache_compression=true
+build:ci --remote_upload_local_results=true
+# CI only needs to know if the build succeeded, not the artifacts themselves.
+build:ci --remote_download_minimal
+# Disable disk cache for CI builds
+build:ci --disk_cache=
+
+# --- OpenROAD Developer Settings (read-only access) ---
+build:openroad-dev --remote_cache=https://storage.googleapis.com/openroad-bazel-cache
+build:openroad-dev --remote_cache_compression=true
+build:openroad-dev --remote_upload_local_results=false
+# Developers need the actual output files to run and use them.
+build:openroad-dev --remote_download_toplevel
+build:openroad-dev --google_default_credentials=true
+build:openroad-dev --disk_cache=/workspace/.cache/bazel-disk-cache
+build:openroad-dev --repository_cache=/workspace/.cache/bazel-repository-cache
 
 try-import %workspace%/user.bazelrc

.bazelversion

@@ -1 +1 @@
-8.2.1
+8.3.1

.github/workflows/github-actions-are-odb-files-generated.yml

@@ -12,15 +12,17 @@ jobs:
   format:
     runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
     steps:
-      - name: setup
-        run: |
-          python3 -m pip install -U --user jinja2==3.1.6
       - name: Check out repository code
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
+      - name: setup
+        run: |
+          python3 -m venv venv
+          venv/bin/pip install jinja2==3.1.6
       - name: Check that ODB Generated Files Are Up To Date
         run: |
+          source venv/bin/activate
           cd src/odb/src/codeGenerator/
           ./generate
           if [ -z "$(git status --porcelain)" ]; then

.github/workflows/github-actions-lint-tcl.yml

@@ -14,14 +14,16 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-
       - name: Install Dependencies
         run: |
-          python3 -m pip install -U --user tclint==0.4.2
+          python3 -m venv venv
+          venv/bin/pip install tclint==0.4.2
 
       - name: Lint
         run: |
+          source venv/bin/activate
           tclfmt --version
           tclfmt --in-place .
           git diff --exit-code
           tclint --no-check-style .
+

Jenkinsfile

@@ -162,31 +162,6 @@ def getParallelTests(String image) {
             }
         },
 
-        'Build with Bazel': {
-            node {
-                withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: image) {
-                    stage('Setup Bazel Build') {
-                        echo "Build with Bazel";
-                        sh label: 'Configure git', script: "git config --system --add safe.directory '*'";
-                        checkout scm;
-                    }
-                    stage('Bazel Build') {
-                        timeout(time: 120, unit: 'MINUTES') {
-                            sh label: 'Bazel Build', script: '''
-                                bazel test \
-                                --keep_going \
-                                --show_timestamps \
-                                --test_output=errors \
-                                --curses=no \
-                                --force_pic \
-                                ...
-                                ''';
-                        }
-                    }
-                }
-            }
-        },
-
         'Check message IDs': {
             dir('src') {
                 sh label: 'Find duplicated message IDs', script: '../etc/find_messages.py > messages.txt';
@@ -274,21 +249,35 @@ def getParallelTests(String image) {
     return ret;
 }
 
-node {
-
-    def isDefaultBranch = (env.BRANCH_NAME == 'master') 
-    def daysToKeep = '20';
-    def numToKeep = (isDefaultBranch ? '-1' : '10');
-
-    properties([
-        buildDiscarder(logRotator(
-            daysToKeepStr:         daysToKeep,
-            artifactDaysToKeepStr: daysToKeep,
+def bazelTest = {
+    node {
+        stage('Setup') {
+            checkout scm;
+            sh label: 'Setup Docker Image', script: 'docker build -f docker/Dockerfile.bazel -t openroad/bazel-ci .';
+        }
+        withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
+            stage('bazelisk test ...') {
+                withCredentials([file(credentialsId: 'bazel-cache-sa', variable: 'GCS_SA_KEY')]) {
+                    timeout(time: 120, unit: 'MINUTES') {
+                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic';
+                        if (env.BRANCH_NAME != 'master') {
+                            cmd += ' --remote_upload_local_results=false';
+                        }
+                        cmd += ' --google_credentials=$GCS_SA_KEY';
+                        try {
+                            sh label: 'Bazel Build', script: cmd + ' ...';
+                        } catch (e) {
+                            currentBuild.result = 'FAILURE';
+                            sh label: 'Bazel Build (keep_going)', script: cmd + ' --keep_going ...';
+                        }
+                    }
+                }
+            }
+        }
+    }
+}
 
-            numToKeepStr:          numToKeep,
-            artifactNumToKeepStr:  numToKeep
-        ))
-    ]);
+def dockerTests = {
     stage('Checkout') {
         checkout scm;
     }
@@ -317,6 +306,24 @@ node {
         echo "Docker image is ${DOCKER_IMAGE}";
     }
     parallel(getParallelTests(DOCKER_IMAGE));
+}
+
+node {
+    def isDefaultBranch = (env.BRANCH_NAME == 'master')
+    def daysToKeep = '20';
+    def numToKeep = (isDefaultBranch ? '-1' : '10');
+    properties([
+        buildDiscarder(logRotator(
+            daysToKeepStr:         daysToKeep,
+            artifactDaysToKeepStr: daysToKeep,
+            numToKeepStr:          numToKeep,
+            artifactNumToKeepStr:  numToKeep
+        ))
+    ]);
+    parallel(
+            "Bazel": bazelTest,
+            "Docker Tests": dockerTests
+    );
     stage('Send Email Report') {
         sendEmail();
     }

MODULE.bazel

@@ -7,6 +7,7 @@ module(
 
 bazel_dep(name = "platforms", version = "0.0.11")
 bazel_dep(name = "bazel_skylib", version = "1.7.1")
+bazel_dep(name = "rules_cc", version = "0.1.2")
 bazel_dep(name = "rules_flex", version = "0.3.1")
 bazel_dep(name = "rules_bison", version = "0.3.1")
 bazel_dep(name = "rules_jvm_external", version = "6.4")
@@ -17,17 +18,6 @@ git_override(
     remote = "https://github.com/bazelbuild/rules_scala",
 )
 
-# The current rules_cc 0.1.1 hardcodes script locations to `#!/bin/bash`
-# instead of using `#!/usr/bin/env bash`.
-# This is fixed by https://github.com/bazelbuild/rules_cc/pull/306 but
-# is not released yet. Use rules_cc from that commit.
-bazel_dep(name = "rules_cc", version = "0.1.1")
-git_override(
-    module_name = "rules_cc",
-    commit = "d74915024017250e46d95e91a3defc34174effe0",
-    remote = "https://github.com/bazelbuild/rules_cc",
-)
-
 bazel_dep(name = "rules_verilator", version = "5.034")
 single_version_override(
     module_name = "rules_verilator",
@@ -149,7 +139,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "5c8f9e30a993848c90ce5250d43e4c2d5206380e",
+    commit = "eaf22cee8fe62d5326f0486e2742a63bbe3d987f",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -158,10 +148,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3299-gb81e0302",
+    image = "docker.io/openroad/orfs:v3.0-3393-g0ae5fce9",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "67535ca2091d7f760b765c0e85a74ca5fd5868aa415f042bbb9fd86bc0a7dc53",
+    sha256 = "3e8134fc509e189ee3762cec4345ba1c690255abee4bba9966d4b0605b2079f7",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -85,7 +85,6 @@ cc_library(
         "runtime/src/ompt-event-specific.h",
         "runtime/src/ompt-general.cpp",
         "runtime/src/ompt-internal.h",
-        "runtime/src/ompt-specific.cpp",
         "runtime/src/ompt-specific.h",
         "runtime/src/test-touch.c",
         "runtime/src/z_Linux_asm.S",