Merge remote-tracking branch 'origin/master' into gpl_fix_max_filler_removal

Author: LucasYuki

.bazelrc

@@ -97,4 +97,7 @@ build:openroad-dev --google_default_credentials=true
 build:openroad-dev --disk_cache=/workspace/.cache/bazel-disk-cache
 build:openroad-dev --repository_cache=/workspace/.cache/bazel-repository-cache
 
+# Without this, bazelisk build ... builds the bazel-orfs tests
+build --build_tag_filters=-orfs
+
 try-import %workspace%/user.bazelrc

.github/workflows/github-actions-lint-tcl.yml

@@ -19,13 +19,13 @@ jobs:
       - name: Install Dependencies
         run: |
           python3 -m venv venv
-          venv/bin/pip install tclint==0.4.2
+          venv/bin/pip install tclint==0.6.1
 
       - name: Lint
         run: |
           source venv/bin/activate
           tclfmt --version
           tclfmt --in-place .
           git diff --exit-code
-          tclint --no-check-style .
+          tclint .
 

BUILD.bazel

@@ -2,6 +2,7 @@
 # Copyright (c) 2025-2025, The OpenROAD Authors
 
 load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
+load("//bazel:python_wrap_cc.bzl", "PYTHON_STABLE_API_DEFINE", "python_wrap_cc")
 load("//bazel:tcl_encode_or.bzl", "tcl_encode")
 load("//bazel:tcl_wrap_cc.bzl", "tcl_wrap_cc")
 
@@ -43,8 +44,6 @@ config_setting(
     },
 )
 
-# TODO: once project is properly decomposed, we don't
-# need these blanked dependencies in multiple places anymore.
 OPENROAD_LIBRARY_DEPS = [
     ":openroad_version",
     ":ord",
@@ -55,6 +54,10 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/cts:ui",
     "//src/cut",
     "//src/dbSta",
+    "//src/dbSta:dbNetwork",
+    "//src/dbSta:dbReadVerilog",
+    "//src/dbSta:dbSdcNetwork",
+    "//src/dbSta:SpefWriter",
     "//src/dbSta:ui",
     "//src/dft",
     "//src/dft:ui",
@@ -133,16 +136,20 @@ cc_binary(
     name = "openroad",
     srcs = [
         "src/Main.cc",
-        "//bazel:runfiles",
     ],
     copts = OPENROAD_COPTS,
     features = ["-use_header_modules"],
-    malloc = "@tcmalloc//tcmalloc",
+    malloc = select({
+        "@platforms//os:linux": "@tcmalloc//tcmalloc",
+        "@platforms//os:macos": "@bazel_tools//tools/cpp:malloc",
+    }),
     visibility = ["//visibility:public"],
     deps = [
         ":openroad_lib",
         ":openroad_version",
-        "//:ord",
+        ":ord",
+        "//bazel:runfiles",
+        "//src/cut",
         "//src/gui",
         "//src/sta:opensta_lib",
         "//src/utl",
@@ -159,25 +166,6 @@ GUI_BUILD_FLAGS = select(
     },
 )
 
-cc_library(
-    name = "openroad_lib_private",
-    srcs = [
-        "src/Design.cc",
-        "src/Tech.cc",
-        "src/Timing.cc",
-    ],
-    copts = OPENROAD_COPTS,
-    defines = OPENROAD_DEFINES + GUI_BUILD_FLAGS,
-    features = ["-use_header_modules"],
-    includes = [
-        "include",
-    ],
-    deps = OPENROAD_LIBRARY_DEPS + [
-        "//src/sta:opensta_lib",
-        "@tk_tcl//:tcl",
-    ],
-)
-
 cc_library(
     name = "openroad_lib",
     srcs = [
@@ -261,6 +249,93 @@ tcl_wrap_cc(
     ],
 )
 
+# This target compiles the SWIG C++ wrapper into a shared library (.so)
+# that Python can load dynamically.
+cc_binary(
+    name = "_openroadpy.so",
+    srcs = [":openroad_swig-py"],
+    defines = [PYTHON_STABLE_API_DEFINE],
+    linkshared = True,
+    deps = [
+        ":openroad_lib",  # Depends on the core odb C++ library
+        ":ord",
+        "//src/ant",
+        "//src/cts",
+        "//src/dpl",
+        "//src/drt",
+        "//src/exa",
+        "//src/fin",
+        "//src/gpl",
+        "//src/grt",
+        "//src/gui",
+        "//src/ifp",
+        "//src/odb",
+        "//src/par",
+        "//src/pdn",
+        "//src/ppl",
+        "//src/psm",
+        "//src/rcx",
+        "//src/stt",
+        "//src/tap",
+        "//src/utl",
+        "@boost.stacktrace",
+        "@openroad_rules_python//python/cc:current_py_cc_headers",
+    ],
+)
+
+# This packages the SWIG-generated Python wrapper (odb.py) and the
+# compiled C++ extension (_odb.so) together.
+py_library(
+    name = "ord_py",
+    srcs = [":openroad_swig-py"],  # Use the .py output from the swig-py rule
+    # The data attribute makes the .so file available at runtime.
+    data = [":_openroadpy.so"],
+    # This allows imports relative to the workspace root.
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [
+        "//src/odb:odb_py",
+        "//src/utl:utl_py",
+    ],
+)
+
+python_wrap_cc(
+    name = "openroad_swig-py",
+    srcs = [
+        "include/ord/Design.h",
+        "include/ord/Tech.h",
+        "include/ord/Timing.h",
+        "src/OpenRoad-py.i",
+        ":error_swig-py",
+    ],
+    module = "openroadpy",
+    root_swig_src = "src/OpenRoad-py.i",
+    swig_includes = [
+        "include",
+        "src",
+    ],
+    deps = [
+        "//src/ant:swig-py",
+        "//src/cts:swig-py",
+        "//src/dpl:swig-py",
+        "//src/drt:swig-py",
+        "//src/exa:swig-py",
+        "//src/fin:swig-py",
+        "//src/gpl:swig-py",
+        "//src/grt:swig-py",
+        "//src/ifp:swig-py",
+        "//src/odb:swig-py",
+        "//src/par:swig-py",
+        "//src/pdn:swig-py",
+        "//src/ppl:swig-py",
+        "//src/psm:swig-py",
+        "//src/rcx:swig-py",
+        "//src/stt:swig-py",
+        "//src/tap:swig-py",
+        "//src/utl:swig-py",
+    ],
+)
+
 filegroup(
     name = "error_swig",
     srcs = [
@@ -269,6 +344,14 @@ filegroup(
     visibility = ["@//:__subpackages__"],
 )
 
+filegroup(
+    name = "error_swig-py",
+    srcs = [
+        "src/Exception-py.i",
+    ],
+    visibility = ["@//:__subpackages__"],
+)
+
 filegroup(
     name = "design_swig",
     srcs = [

MODULE.bazel

@@ -110,12 +110,12 @@ bazel_dep(name = "googletest", version = "1.16.0", dev_dependency = True)
 bazel_dep(name = "glpk", version = "5.0.bcr.3", repo_name = "org_gnu_glpk")
 
 ## Fix the compiler version and avoid any local compiler
-bazel_dep(name = "toolchains_llvm", version = "1.4.0")
+bazel_dep(name = "toolchains_llvm", version = "1.5.0")
 
 # Configure and register the toolchain.
 llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm")
 llvm.toolchain(
-    llvm_version = "20.1.2",
+    llvm_version = "20.1.8",
 )
 use_repo(llvm, "llvm_toolchain")
 # use_repo(llvm, "llvm_toolchain_llvm") # if you depend on specific tools in scripts
@@ -138,6 +138,7 @@ python.toolchain(
     ignore_root_user_error = True,
     python_version = "3.13",
 )
+use_repo(python, "python_3_13")
 
 pip = use_extension("@openroad_rules_python//python/extensions:pip.bzl", "pip")
 pip.parse(
@@ -152,7 +153,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "25aa6f643146394f201eac5ef4df69887c83859f",
+    commit = "2cf0198a49a220cfcabae35bba64b0034bbdbffc",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -161,10 +162,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3749-g8443d760",
+    image = "docker.io/openroad/orfs:v3.0-3845-gbefd38218",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "f84c76855e854e89e54eb87fac2b65038567205ced5f8051e34e2e842047d78a",
+    sha256 = "4982a5b87588e4699f11deaed3286cba8b65d144e439c6f5845656abebfc0971",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -16,4 +16,5 @@ cc_library(
     deps = [
         "@rules_cc//cc/runfiles",
     ],
+    alwayslink = True,
 )

bazel/BUILD

@@ -6,6 +6,11 @@
 #include <optional>
 #include <string>
 
+#if defined(__APPLE__)
+#include <mach-o/dyld.h>
+#include <sys/param.h>
+#endif
+
 #include "rules_cc/cc/runfiles/runfiles.h"
 
 // Avoid adding any dependencies like boost.filesystem
@@ -19,7 +24,7 @@ static std::optional<std::string> getProgramLocation()
   char result[MAXPATHLEN + 1] = {'\0'};
   uint32_t path_len = MAXPATHLEN;
   if (_NSGetExecutablePath(result, &path_len) != 0) {
-    path_len = readlink("/proc/self/exe", result, MAXPATHLEN);
+    path_len = readlink(result, result, MAXPATHLEN);
   }
 #else
   char result[PATH_MAX + 1] = {'\0'};
@@ -50,9 +55,9 @@ class BazelInitializer
     }
 
     // Set the TCL_LIBRARY environment variable
-    std::string path = runfiles->Rlocation("tk_tcl/library/");
-    if (!path.empty()) {
-      setenv("TCL_LIBRARY", path.c_str(), 0);
+    const std::string tcl_path = runfiles->Rlocation("tk_tcl/library/");
+    if (!tcl_path.empty()) {
+      setenv("TCL_LIBRARY", tcl_path.c_str(), 0);
     } else {
       std::cerr << "Error: Could not locate 'tk_tcl/library/' in runfiles."
                 << std::endl;