gui: speed up the select command

- Only contruct the regex once
- Identify "simple" patterns that don't need a regex match
  and simple string comparison is enough
- Replace Descriptor::getAllObjects with visitAllObjects to save
  allocation/deallocation cost.

Future work could include a direct find of a simple name rather than a full
iteration of all objects.

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/drt/src/dr/FlexDR_graphics.cpp

@@ -38,7 +38,8 @@ class GridGraphDescriptor : public gui::Descriptor
   gui::Selected makeSelected(std::any object) const override;
   bool lessThan(std::any l, std::any r) const override;
 
-  bool getAllObjects(gui::SelectionSet& objects) const override;
+  void visitAllObjects(
+      const std::function<void(const gui::Selected&)>& func) const override;
 };
 
 std::string GridGraphDescriptor::getName(std::any object) const
@@ -187,9 +188,9 @@ bool GridGraphDescriptor::lessThan(std::any l, std::any r) const
          < std::tie(r_grid.x, r_grid.y, r_grid.z);
 }
 
-bool GridGraphDescriptor::getAllObjects(gui::SelectionSet& objects) const
+void GridGraphDescriptor::visitAllObjects(
+    const std::function<void(const gui::Selected&)>& func) const
 {
-  return false;
 }
 
 //////////////////////////////////////////////////

src/gui/include/gui/gui.h

@@ -312,7 +312,9 @@ class Descriptor
   virtual bool isInst(std::any /* object */) const { return false; }
   virtual bool isNet(std::any /* object */) const { return false; }
 
-  virtual bool getAllObjects(SelectionSet& /* objects */) const = 0;
+  virtual void visitAllObjects(
+      const std::function<void(const Selected&)>& func) const
+      = 0;
 
   // A property is a name and a value.
   struct Property

src/gui/src/bufferTreeDescriptor.cpp

@@ -199,24 +199,23 @@ bool BufferTreeDescriptor::lessThan(std::any l, std::any r) const
   return l_bnet->getName() < r_bnet->getName();
 }
 
-bool BufferTreeDescriptor::getAllObjects(SelectionSet& objects) const
+void BufferTreeDescriptor::visitAllObjects(
+    const std::function<void(const Selected&)>& func) const
 {
   auto* chip = db_->getChip();
   if (chip == nullptr) {
-    return false;
+    return;
   }
   auto* block = chip->getBlock();
   if (block == nullptr) {
-    return false;
+    return;
   }
 
   for (auto* net : block->getNets()) {
     if (BufferTree::isAggregate(net)) {
-      objects.insert(makeSelected(BufferTree(net)));
+      func({BufferTree(net), this});
     }
   }
-
-  return true;
 }
 
 Descriptor::Actions BufferTreeDescriptor::getActions(std::any object) const

src/gui/src/bufferTreeDescriptor.h

@@ -68,7 +68,8 @@ class BufferTreeDescriptor : public Descriptor
   Selected makeSelected(std::any object) const override;
   bool lessThan(std::any l, std::any r) const override;
 
-  bool getAllObjects(SelectionSet& objects) const override;
+  void visitAllObjects(
+      const std::function<void(const Selected&)>& func) const override;
 
  private:
   odb::dbDatabase* db_;