Merge remote-tracking branch 'upstream/master' into dft_save_clock_domain

Author: donn

.clang-tidy

@@ -65,7 +65,7 @@ CheckOptions:
 
 # All modules but sta
 # Exclude build as there is too much noise from swig generated code
-HeaderFilterRegex: "(?!build/.*)/(ant|cts|dbSta|dft|dpl|drt|dst|exa|fin|gpl|grt|gui|ifp|mpl|odb|ord|pad|par|pdn|ppl|psm|rcx|rmp|rsz|stt|tap|upf|utl)/.*"
+HeaderFilterRegex: "(?!build/.*)/(ant|cts|dbSta|dft|dpl|drt|dst|est|exa|fin|gpl|grt|gui|ifp|mpl|odb|ord|pad|par|pdn|ppl|psm|rcx|rmp|rsz|stt|tap|upf|utl)/.*"
 
 # Not currently handling identifier naming
 # WarningsAsErrors: "*"

.github/workflows/github-actions-are-odb-files-generated.yml

@@ -16,6 +16,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
+          submodules: 'recursive'
       - name: setup
         run: |
           python3 -m venv venv

.github/workflows/github-actions-lint-tcl.yml

@@ -14,6 +14,8 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          submodules: 'recursive'
       - name: Install Dependencies
         run: |
           python3 -m venv venv

BUILD.bazel

@@ -8,7 +8,7 @@ load("//bazel:tcl_wrap_cc.bzl", "tcl_wrap_cc")
 package(
     features = [
         "-parse_headers",
-        "-layering_check",
+        "layering_check",
         # TODO(b/299593765): Fix strict ordering.
         "-libcxx_assertions",
     ],
@@ -62,6 +62,8 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/drt:ui",
     "//src/dst",
     "//src/dst:ui",
+    "//src/est",
+    "//src/est:ui",
     "//src/exa",
     "//src/exa:ui",
     "//src/fin",
@@ -82,6 +84,8 @@ OPENROAD_LIBRARY_DEPS = [
     "//src/psm",
     "//src/rcx",
     "//src/rcx:ui",
+    "//src/rmp",
+    "//src/rmp:ui",
     "//src/rsz",
     "//src/rsz:ui",
     "//src/stt",
@@ -127,24 +131,20 @@ cc_binary(
     name = "openroad",
     srcs = [
         "src/Main.cc",
-        "src/OpenRoad.cc",
-        ":openroad_swig",
-        ":openroad_tcl",
-        ":rmp_swig",
-        ":rmp_tcl",
         "//bazel:runfiles",
     ],
     copts = OPENROAD_COPTS,
     features = ["-use_header_modules"],
     malloc = "@tcmalloc//tcmalloc",
     visibility = ["//visibility:public"],
     deps = [
-        ":openroad_lib_private",
+        ":openroad_lib",
         ":openroad_version",
-        "//src/odb",
-        "//src/rsz",
+        "//:ord",
+        "//src/gui",
         "//src/sta:opensta_lib",
         "//src/utl",
+        "@boost.stacktrace",
         "@rules_cc//cc/runfiles",
         "@tk_tcl//:tcl",
     ],
@@ -163,21 +163,17 @@ cc_library(
         "src/Design.cc",
         "src/Tech.cc",
         "src/Timing.cc",
-    ] + glob([
-        "src/rmp/src/*.h",
-        "src/rmp/src/*.cpp",
-    ]),
-    hdrs = glob([
-        "src/rmp/include/rmp/*.h",
-    ]),
+    ],
     copts = OPENROAD_COPTS,
     defines = OPENROAD_DEFINES + GUI_BUILD_FLAGS,
     features = ["-use_header_modules"],
     includes = [
         "include",
-        "src/rmp/include",
     ],
-    deps = OPENROAD_LIBRARY_DEPS,
+    deps = OPENROAD_LIBRARY_DEPS + [
+        "//src/sta:opensta_lib",
+        "@tk_tcl//:tcl",
+    ]
 )
 
 cc_library(
@@ -189,22 +185,19 @@ cc_library(
         "src/Timing.cc",
         ":openroad_swig",
         ":openroad_tcl",
-        ":rmp_swig",
-        ":rmp_tcl",
-    ] + glob([
-        "src/rmp/src/*.cpp",
-        "src/rmp/src/*.h",
-    ]),
-    hdrs = glob(["src/rmp/include/rmp/*.h"]),
+    ],
     copts = OPENROAD_COPTS,
     defines = OPENROAD_DEFINES + GUI_BUILD_FLAGS,
     features = ["-use_header_modules"],
     includes = [
         "include",
-        "src/rmp/include",
     ],
     visibility = ["//visibility:public"],
-    deps = OPENROAD_LIBRARY_DEPS,
+    deps = OPENROAD_LIBRARY_DEPS + [
+        "//src/sta:opensta_lib",
+        "@boost.stacktrace",
+        "@tk_tcl//:tcl",
+    ]
 )
 
 cc_library(
@@ -252,15 +245,6 @@ tcl_encode(
     namespace = "ord",
 )
 
-tcl_encode(
-    name = "rmp_tcl",
-    srcs = [
-        "src/rmp/src/rmp.tcl",
-    ],
-    char_array_name = "rmp_tcl_inits",
-    namespace = "rmp",
-)
-
 tcl_wrap_cc(
     name = "openroad_swig",
     srcs = [
@@ -275,22 +259,6 @@ tcl_wrap_cc(
     ],
 )
 
-tcl_wrap_cc(
-    name = "rmp_swig",
-    srcs = [
-        "src/rmp/src/rmp.i",
-        ":error_swig",
-        "//src/sta:sta_swig_files",
-    ],
-    module = "rmp",
-    namespace_prefix = "rmp",
-    root_swig_src = "src/rmp/src/rmp.i",
-    swig_includes = [
-        "src/rmp/src",
-        "src/sta",
-    ],
-)
-
 filegroup(
     name = "error_swig",
     srcs = [

CMakeLists.txt

@@ -176,3 +176,8 @@ if(BUILD_MAN)
   install(DIRECTORY ${OPENROAD_HOME}/docs/cat DESTINATION ${OPENROAD_SHARE}/man)
   install(DIRECTORY ${OPENROAD_HOME}/docs/html DESTINATION ${OPENROAD_SHARE}/man)
 endif()
+
+####################################################################
+# Add a configuration for ReleaseWithAsserts
+set(CMAKE_CXX_FLAGS_RELEASEWITHASSERTS "${CMAKE_CXX_FLAGS_RELEASE} -UNDEBUG" CACHE STRING "" FORCE)
+set(CMAKE_C_FLAGS_RELEASEWITHASSERTS "${CMAKE_C_FLAGS_RELEASE} -UNDEBUG" CACHE STRING "" FORCE)

MODULE.bazel

@@ -79,6 +79,7 @@ bazel_dep(name = "boost.smart_ptr", version = BOOST_VERSION)
 bazel_dep(name = "boost.spirit", version = BOOST_VERSION)
 bazel_dep(name = "boost.stacktrace", version = BOOST_VERSION)
 bazel_dep(name = "boost.system", version = BOOST_VERSION)
+bazel_dep(name = "boost.test", version = BOOST_VERSION + ".bcr.1")
 bazel_dep(name = "boost.thread", version = BOOST_VERSION + ".bcr.2")
 bazel_dep(name = "boost.tokenizer", version = BOOST_VERSION)
 bazel_dep(name = "boost.unordered", version = BOOST_VERSION)

MODULE.bazel.lock

@@ -8,9 +8,9 @@ workspace(name = "openroad")
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-rules_hdl_git_hash = "80266603b55778dd30531c9b286152a7b664fbb7"
+rules_hdl_git_hash = "cf2bd95334741db74b39b47fa1d4622b0d45ce6c"
 
-rules_hdl_git_sha256 = "38f04d38cfbf46c52643325b496673d607ce5ea6fda99dc1dfa3997a520bb0c2"
+rules_hdl_git_sha256 = "137e1fbde970a41f295ca348f9105bc7eedd6640374ec7f4a8abaee9a2cfc2d0"
 
 http_archive(
     name = "rules_hdl",

WORKSPACE

@@ -240,6 +240,7 @@ Tool namespaces are usually three-lettered lowercase letters.
 - Macro Placer ([mpl](../main/src/mpl/README.md))
 - RePlAce Global Placer ([gpl](../main/src/gpl/README.md))
 - Gate resizing and buffering ([rsz](../main/src/rsz/README.md))
+- Parasitics estimation ([est](../main/src/est/README.md))
 - Detailed placement ([dpl](../main/src/dpl/README.md))
 - Clock tree synthesis ([cts](../main/src/cts/README.md))
 - FastRoute Global routing ([grt](../main/src/grt/README.md))

docs/contrib/DeveloperGuide.md

@@ -101,7 +101,8 @@ class ICeWall;
 
 namespace utl {
 class Logger;
-}
+class CallBackHandler;
+}  // namespace utl
 
 namespace dst {
 class Distributed;
@@ -114,6 +115,10 @@ namespace dft {
 class Dft;
 }
 
+namespace est {
+class EstimateParasitics;
+}
+
 namespace ord {
 
 using std::string;
@@ -137,6 +142,7 @@ class OpenRoad
 
   Tcl_Interp* tclInterp() { return tcl_interp_; }
   utl::Logger* getLogger() { return logger_; }
+  utl::CallBackHandler* getCallBackHandler() { return callback_handler_; }
   odb::dbDatabase* getDb() { return db_; }
   sta::dbSta* getSta() { return sta_; }
   sta::dbNetwork* getDbNetwork();
@@ -162,6 +168,10 @@ class OpenRoad
   dst::Distributed* getDistributed() { return distributer_; }
   stt::SteinerTreeBuilder* getSteinerTreeBuilder() { return stt_builder_; }
   dft::Dft* getDft() { return dft_; }
+  est::EstimateParasitics* getEstimateParasitics()
+  {
+    return estimate_parasitics_;
+  }
 
   // Return the bounding box of the db rows.
   odb::Rect getCore();
@@ -256,6 +266,8 @@ class OpenRoad
   dst::Distributed* distributer_ = nullptr;
   stt::SteinerTreeBuilder* stt_builder_ = nullptr;
   dft::Dft* dft_ = nullptr;
+  est::EstimateParasitics* estimate_parasitics_ = nullptr;
+  utl::CallBackHandler* callback_handler_ = nullptr;
 
   int threads_ = 1;