fix readability-non-const-parameter (supress 1 false)

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/drt/src/pa/FlexPA.h

@@ -845,7 +845,7 @@ class FlexPA
   bool genPatternsGC(
       const std::set<frBlockObject*>& target_objs,
       const std::vector<std::pair<frConnFig*, frBlockObject*>>& objs,
-      PatternType pattern_type,
+      const PatternType pattern_type,
       std::set<frBlockObject*>* owners = nullptr);
 
   /**

src/drt/src/pa/FlexPA_acc_pattern.cpp

@@ -321,6 +321,7 @@ bool FlexPA::genPatternsGC(
     const std::set<frBlockObject*>& target_objs,
     const std::vector<std::pair<frConnFig*, frBlockObject*>>& objs,
     const PatternType pattern_type,
+    // NOLINTNEXTLINE(readability-non-const-parameter)
     std::set<frBlockObject*>* owners)
 {
   if (objs.empty()) {

src/gpl/src/fftsg.cpp

@@ -313,8 +313,8 @@ void rdft(int n, int isgn, float* a, int* ip, float* w)
   void makect(int nc, int* ip, float* c);
   void cftfsub(int n, float* a, int* ip, int nw, float* w);
   void cftbsub(int n, float* a, int* ip, int nw, float* w);
-  void rftfsub(int n, float* a, int nc, float* c);
-  void rftbsub(int n, float* a, int nc, float* c);
+  void rftfsub(int n, float* a, int nc, const float* c);
+  void rftbsub(int n, float* a, int nc, const float* c);
   int nw, nc;
   float xi;
 
@@ -356,9 +356,9 @@ void ddct(int n, int isgn, float* a, int* ip, float* w)
   void makect(int nc, int* ip, float* c);
   void cftfsub(int n, float* a, int* ip, int nw, float* w);
   void cftbsub(int n, float* a, int* ip, int nw, float* w);
-  void rftfsub(int n, float* a, int nc, float* c);
-  void rftbsub(int n, float* a, int nc, float* c);
-  void dctsub(int n, float* a, int nc, float* c);
+  void rftfsub(int n, float* a, int nc, const float* c);
+  void rftbsub(int n, float* a, int nc, const float* c);
+  void dctsub(int n, float* a, int nc, const float* c);
   int j, nw, nc;
   float xr;
 
@@ -412,9 +412,9 @@ void ddst(int n, int isgn, float* a, int* ip, float* w)
   void makect(int nc, int* ip, float* c);
   void cftfsub(int n, float* a, int* ip, int nw, float* w);
   void cftbsub(int n, float* a, int* ip, int nw, float* w);
-  void rftfsub(int n, float* a, int nc, float* c);
-  void rftbsub(int n, float* a, int nc, float* c);
-  void dstsub(int n, float* a, int nc, float* c);
+  void rftfsub(int n, float* a, int nc, const float* c);
+  void rftbsub(int n, float* a, int nc, const float* c);
+  void dstsub(int n, float* a, int nc, const float* c);
   int j, nw, nc;
   float xr;
 
@@ -466,8 +466,8 @@ void dfct(int n, float* a, float* t, int* ip, float* w)
   void makewt(int nw, int* ip, float* w);
   void makect(int nc, int* ip, float* c);
   void cftfsub(int n, float* a, int* ip, int nw, float* w);
-  void rftfsub(int n, float* a, int nc, float* c);
-  void dctsub(int n, float* a, int nc, float* c);
+  void rftfsub(int n, float* a, int nc, const float* c);
+  void dctsub(int n, float* a, int nc, const float* c);
   int j, k, l, m, mh, nw, nc;
   float xr, xi, yr, yi;
 
@@ -558,8 +558,8 @@ void dfst(int n, float* a, float* t, int* ip, float* w)
   void makewt(int nw, int* ip, float* w);
   void makect(int nc, int* ip, float* c);
   void cftfsub(int n, float* a, int* ip, int nw, float* w);
-  void rftfsub(int n, float* a, int nc, float* c);
-  void dstsub(int n, float* a, int nc, float* c);
+  void rftfsub(int n, float* a, int nc, const float* c);
+  void dstsub(int n, float* a, int nc, const float* c);
   int j, k, l, m, mh, nw, nc;
   float xr, xi, yr, yi;
 
@@ -798,15 +798,15 @@ void makect(int nc, int* ip, float* c)
 
 void cftfsub(int n, float* a, int* ip, int nw, float* w)
 {
-  void bitrv2(int n, int* ip, float* a);
+  void bitrv2(int n, const int* ip, float* a);
   void bitrv216(float* a);
   void bitrv208(float* a);
-  void cftf1st(int n, float* a, float* w);
+  void cftf1st(int n, float* a, const float* w);
   void cftrec4(int n, float* a, int nw, float* w);
   void cftleaf(int n, int isplt, float* a, int nw, float* w);
   void cftfx41(int n, float* a, int nw, float* w);
-  void cftf161(float* a, float* w);
-  void cftf081(float* a, float* w);
+  void cftf161(float* a, const float* w);
+  void cftf081(float* a, const float* w);
   void cftf040(float* a);
   void cftx020(float* a);
 #ifdef USE_CDFT_THREADS
@@ -845,15 +845,15 @@ void cftfsub(int n, float* a, int* ip, int nw, float* w)
 
 void cftbsub(int n, float* a, int* ip, int nw, float* w)
 {
-  void bitrv2conj(int n, int* ip, float* a);
+  void bitrv2conj(int n, const int* ip, float* a);
   void bitrv216neg(float* a);
   void bitrv208neg(float* a);
-  void cftb1st(int n, float* a, float* w);
+  void cftb1st(int n, float* a, const float* w);
   void cftrec4(int n, float* a, int nw, float* w);
   void cftleaf(int n, int isplt, float* a, int nw, float* w);
   void cftfx41(int n, float* a, int nw, float* w);
-  void cftf161(float* a, float* w);
-  void cftf081(float* a, float* w);
+  void cftf161(float* a, const float* w);
+  void cftf081(float* a, const float* w);
   void cftb040(float* a);
   void cftx020(float* a);
 #ifdef USE_CDFT_THREADS
@@ -890,7 +890,7 @@ void cftbsub(int n, float* a, int* ip, int nw, float* w)
   }
 }
 
-void bitrv2(int n, int* ip, float* a)
+void bitrv2(int n, const int* ip, float* a)
 {
   int j, j1, k, k1, l, m, nh, nm;
   float xr, xi, yr, yi;
@@ -1236,7 +1236,7 @@ void bitrv2(int n, int* ip, float* a)
   }
 }
 
-void bitrv2conj(int n, int* ip, float* a)
+void bitrv2conj(int n, const int* ip, float* a)
 {
   int j, j1, k, k1, l, m, nh, nm;
   float xr, xi, yr, yi;
@@ -1769,7 +1769,7 @@ void bitrv208neg(float* a)
   a[15] = x4i;
 }
 
-void cftf1st(int n, float* a, float* w)
+void cftf1st(int n, float* a, const float* w)
 {
   int j, j0, j1, j2, j3, k, m, mh;
   float wn4r, csc1, csc3, wk1r, wk1i, wk3r, wk3i, wd1r, wd1i, wd3r, wd3i;
@@ -1973,7 +1973,7 @@ void cftf1st(int n, float* a, float* w)
   a[j3 + 3] = wk3i * x0i - wk3r * x0r;
 }
 
-void cftb1st(int n, float* a, float* w)
+void cftb1st(int n, float* a, const float* w)
 {
   int j, j0, j1, j2, j3, k, m, mh;
   float wn4r, csc1, csc3, wk1r, wk1i, wk3r, wk3i, wd1r, wd1i, wd3r, wd3i;
@@ -2225,7 +2225,7 @@ void* cftrec1_th(void* p)
 {
   int cfttree(int n, int j, int k, float* a, int nw, float* w);
   void cftleaf(int n, int isplt, float* a, int nw, float* w);
-  void cftmdl1(int n, float* a, float* w);
+  void cftmdl1(int n, float* a, const float* w);
   int isplt, j, k, m, n, n0, nw;
   float *a, *w;
 
@@ -2253,7 +2253,7 @@ void* cftrec2_th(void* p)
 {
   int cfttree(int n, int j, int k, float* a, int nw, float* w);
   void cftleaf(int n, int isplt, float* a, int nw, float* w);
-  void cftmdl2(int n, float* a, float* w);
+  void cftmdl2(int n, float* a, const float* w);
   int isplt, j, k, m, n, n0, nw;
   float *a, *w;
 
@@ -2284,7 +2284,7 @@ void cftrec4(int n, float* a, int nw, float* w)
 {
   int cfttree(int n, int j, int k, float* a, int nw, float* w);
   void cftleaf(int n, int isplt, float* a, int nw, float* w);
-  void cftmdl1(int n, float* a, float* w);
+  void cftmdl1(int n, float* a, const float* w);
   int isplt, j, k, m;
 
   m = n;
@@ -2303,8 +2303,8 @@ void cftrec4(int n, float* a, int nw, float* w)
 
 int cfttree(int n, int j, int k, float* a, int nw, float* w)
 {
-  void cftmdl1(int n, float* a, float* w);
-  void cftmdl2(int n, float* a, float* w);
+  void cftmdl1(int n, float* a, const float* w);
+  void cftmdl2(int n, float* a, const float* w);
   int i, isplt, m;
 
   if ((k & 3) != 0) {
@@ -2337,12 +2337,12 @@ int cfttree(int n, int j, int k, float* a, int nw, float* w)
 
 void cftleaf(int n, int isplt, float* a, int nw, float* w)
 {
-  void cftmdl1(int n, float* a, float* w);
-  void cftmdl2(int n, float* a, float* w);
-  void cftf161(float* a, float* w);
-  void cftf162(float* a, float* w);
-  void cftf081(float* a, float* w);
-  void cftf082(float* a, float* w);
+  void cftmdl1(int n, float* a, const float* w);
+  void cftmdl2(int n, float* a, const float* w);
+  void cftf161(float* a, const float* w);
+  void cftf162(float* a, const float* w);
+  void cftf081(float* a, const float* w);
+  void cftf082(float* a, const float* w);
 
   if (n == 512) {
     cftmdl1(128, a, &w[nw - 64]);
@@ -2399,7 +2399,7 @@ void cftleaf(int n, int isplt, float* a, int nw, float* w)
   }
 }
 
-void cftmdl1(int n, float* a, float* w)
+void cftmdl1(int n, float* a, const float* w)
 {
   int j, j0, j1, j2, j3, k, m, mh;
   float wn4r, wk1r, wk1i, wk3r, wk3i;
@@ -2508,7 +2508,7 @@ void cftmdl1(int n, float* a, float* w)
   a[j3 + 1] = -wn4r * (x0i - x0r);
 }
 
-void cftmdl2(int n, float* a, float* w)
+void cftmdl2(int n, float* a, const float* w)
 {
   int j, j0, j1, j2, j3, k, kr, m, mh;
   float wn4r, wk1r, wk1i, wk3r, wk3i, wd1r, wd1i, wd3r, wd3i;
@@ -2643,10 +2643,10 @@ void cftmdl2(int n, float* a, float* w)
 
 void cftfx41(int n, float* a, int nw, float* w)
 {
-  void cftf161(float* a, float* w);
-  void cftf162(float* a, float* w);
-  void cftf081(float* a, float* w);
-  void cftf082(float* a, float* w);
+  void cftf161(float* a, const float* w);
+  void cftf162(float* a, const float* w);
+  void cftf081(float* a, const float* w);
+  void cftf082(float* a, const float* w);
 
   if (n == 128) {
     cftf161(a, &w[nw - 8]);
@@ -2661,7 +2661,7 @@ void cftfx41(int n, float* a, int nw, float* w)
   }
 }
 
-void cftf161(float* a, float* w)
+void cftf161(float* a, const float* w)
 {
   float wn4r, wk1r, wk1i, x0r, x0i, x1r, x1i, x2r, x2i, x3r, x3i, y0r, y0i, y1r,
       y1i, y2r, y2i, y3r, y3i, y4r, y4i, y5r, y5i, y6r, y6i, y7r, y7i, y8r, y8i,
@@ -2817,7 +2817,7 @@ void cftf161(float* a, float* w)
   a[7] = x1i - x3r;
 }
 
-void cftf162(float* a, float* w)
+void cftf162(float* a, const float* w)
 {
   float wn4r, wk1r, wk1i, wk2r, wk2i, wk3r, wk3i, x0r, x0i, x1r, x1i, x2r, x2i,
       y0r, y0i, y1r, y1i, y2r, y2i, y3r, y3i, y4r, y4i, y5r, y5i, y6r, y6i, y7r,
@@ -2997,7 +2997,7 @@ void cftf162(float* a, float* w)
   a[31] = x1i - x2r;
 }
 
-void cftf081(float* a, float* w)
+void cftf081(float* a, const float* w)
 {
   float wn4r, x0r, x0i, x1r, x1i, x2r, x2i, x3r, x3i, y0r, y0i, y1r, y1i, y2r,
       y2i, y3r, y3i, y4r, y4i, y5r, y5i, y6r, y6i, y7r, y7i;
@@ -3057,7 +3057,7 @@ void cftf081(float* a, float* w)
   a[7] = y2i - y6r;
 }
 
-void cftf082(float* a, float* w)
+void cftf082(float* a, const float* w)
 {
   float wn4r, wk1r, wk1i, x0r, x0i, x1r, x1i, y0r, y0i, y1r, y1i, y2r, y2i, y3r,
       y3i, y4r, y4i, y5r, y5i, y6r, y6i, y7r, y7i;
@@ -3183,7 +3183,7 @@ void cftx020(float* a)
   a[3] = x0i;
 }
 
-void rftfsub(int n, float* a, int nc, float* c)
+void rftfsub(int n, float* a, int nc, const float* c)
 {
   int j, k, kk, ks, m;
   float wkr, wki, xr, xi, yr, yi;
@@ -3207,7 +3207,7 @@ void rftfsub(int n, float* a, int nc, float* c)
   }
 }
 
-void rftbsub(int n, float* a, int nc, float* c)
+void rftbsub(int n, float* a, int nc, const float* c)
 {
   int j, k, kk, ks, m;
   float wkr, wki, xr, xi, yr, yi;
@@ -3231,7 +3231,7 @@ void rftbsub(int n, float* a, int nc, float* c)
   }
 }
 
-void dctsub(int n, float* a, int nc, float* c)
+void dctsub(int n, float* a, int nc, const float* c)
 {
   int j, k, kk, ks, m;
   float wkr, wki, xr;
@@ -3251,7 +3251,7 @@ void dctsub(int n, float* a, int nc, float* c)
   a[m] *= c[0];
 }
 
-void dstsub(int n, float* a, int nc, float* c)
+void dstsub(int n, float* a, int nc, const float* c)
 {
   int j, k, kk, ks, m;
   float wkr, wki, xr;

src/odb/src/def/def/defrReader.cpp

@@ -1936,7 +1936,7 @@ void defrSetViaWarnings(int warn)
   defContext.settings->ViaWarnings = warn;
 }
 
-void defrDisableParserMsgs(int nMsg, int* msgs)
+void defrDisableParserMsgs(int nMsg, const int* msgs)
 {
   DEF_INIT;
   int i, j;
@@ -1974,7 +1974,7 @@ void defrDisableParserMsgs(int nMsg, int* msgs)
   }
 }
 
-void defrEnableParserMsgs(int nMsg, int* msgs)
+void defrEnableParserMsgs(int nMsg, const int* msgs)
 {
   DEF_INIT;
   int i, j;

src/odb/src/def/defdiff/diffDefRW.cpp

@@ -778,7 +778,7 @@ int netf(defrCallbackType_e c, defiNet* net, defiUserData ud)
 }
 
 // Special Net
-int snetf(defrCallbackType_e c, defiNet* net, defiUserData ud)
+int snetf(defrCallbackType_e c, const defiNet* net, defiUserData ud)
 {
   // For net and special net.
   int i, j, x, y, z;
@@ -1211,7 +1211,7 @@ int snetf(defrCallbackType_e c, defiNet* net, defiUserData ud)
   return 0;
 }
 
-int ndr(defrCallbackType_e c, defiNonDefault* nd, defiUserData ud)
+int ndr(defrCallbackType_e c, const defiNonDefault* nd, defiUserData ud)
 {
   // For nondefaultrule
   int i;
@@ -1295,7 +1295,7 @@ char* address(const char* in)
 }
 
 // Assertion or Constraints
-void operand(defrCallbackType_e c, defiAssertion* a, int ind)
+void operand(defrCallbackType_e c, const defiAssertion* a, int ind)
 {
   int i, first = 1;
   char* netName;
@@ -1343,7 +1343,7 @@ void operand(defrCallbackType_e c, defiAssertion* a, int ind)
 }
 
 // Assertion or Constraints
-int constraint(defrCallbackType_e c, defiAssertion* a, defiUserData ud)
+int constraint(defrCallbackType_e c, const defiAssertion* a, defiUserData ud)
 {
   // Handles both constraints and assertions
 
@@ -1382,7 +1382,7 @@ int constraint(defrCallbackType_e c, defiAssertion* a, defiUserData ud)
 }
 
 // Property definitions
-int prop(defrCallbackType_e c, defiProp* p, defiUserData ud)
+int prop(defrCallbackType_e c, const defiProp* p, defiUserData ud)
 {
   checkType(c);
   if (ud != userData) {