Merge pull request #9158 from The-OpenROAD-Project-staging/tidy2

Tidy2

Author: maliberty

etc/run-clang-tidy-cached.cc

@@ -152,7 +152,7 @@ inline bool IsOneOf(std::string_view s,
 // Files that look like relevant include files.
 inline bool IsIncludeExtension(std::string_view extension)
 {
-  return IsOneOf(extension, {".h", ".hpp", ".hxx", ".inl"});
+  return IsOneOf(extension, {".h", ".hh", ".hpp", ".hxx", ".inl"});
 }
 
 // Filter for source files to be considered.

src/Main.cc

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: BSD-3-Clause
 // Copyright (c) 2019-2025, The OpenROAD Authors
 
-#include <libgen.h>
 #include <stdlib.h>  // NOLINT(modernize-deprecated-headers): for setenv()
 #include <strings.h>
 
@@ -371,8 +370,7 @@ std::string findPathToTclreadlineInit(Tcl_Interp* interp)
     )";
 
   if (Tcl_Eval(interp, tcl_script) == TCL_ERROR) {
-    std::cerr << "Tcl_Eval failed: " << Tcl_GetStringResult(interp)
-              << std::endl;
+    std::cerr << "Tcl_Eval failed: " << Tcl_GetStringResult(interp) << '\n';
     return "";
   }
 

src/OpenRoad.cc

@@ -166,7 +166,7 @@ OpenRoad* OpenRoad::openRoad()
 void OpenRoad::setOpenRoad(OpenRoad* app, bool reinit_ok)
 {
   if (!reinit_ok && app_) {
-    std::cerr << "Attempt to reinitialize the application." << std::endl;
+    std::cerr << "Attempt to reinitialize the application.\n";
     exit(1);
   }
   app_ = app;

src/ant/src/Polygon.cc

@@ -15,6 +15,10 @@
 
 namespace ant {
 
+using gtl::operators::operator+=;
+using gtl::operators::operator-=;
+using gtl::operators::operator&;
+
 Polygon rectToPolygon(const odb::Rect& rect)
 {
   std::vector<Point> points{{gtl::construct<Point>(rect.xMin(), rect.yMin()),

src/ant/src/Polygon.hh

@@ -12,7 +12,6 @@
 namespace ant {
 
 namespace gtl = boost::polygon;
-using namespace gtl::operators;
 
 using Polygon = gtl::polygon_90_data<int>;
 using PolygonSet = std::vector<Polygon>;

src/cts/src/LatencyBalancer.h

@@ -67,8 +67,7 @@ class LatencyBalancer
         openSta_(sta),
         wireSegmentUnit_(scalingUnit),
         capPerDBU_(capPerDBU),
-        worseDelay_(std::numeric_limits<float>::min()),
-        delayBufIndex_(0)
+        worseDelay_(std::numeric_limits<float>::min())
   {
   }
 
@@ -120,9 +119,9 @@ class LatencyBalancer
   float bufferDelay_;
   double capPerDBU_;
   float worseDelay_;
-  int delayBufIndex_;
+  int delayBufIndex_{0};
   std::vector<GraphNode> graph_;
   std::map<std::string, TreeBuilder*> inst2builder_;
 };
 
-}  // namespace cts
+}  // namespace cts

src/cut/src/abc_library_factory.cpp

@@ -3,9 +3,8 @@
 
 #include "cut/abc_library_factory.h"
 
-#include <string.h>
-
 #include <cmath>
+#include <cstring>
 #include <optional>
 #include <unordered_set>
 #include <utility>

src/cut/src/blif.cpp

@@ -301,12 +301,12 @@ bool Blif::writeBlif(const char* file_name, bool write_arrival_requireds)
   if (write_arrival_requireds) {
     for (auto& arrival : arrivals_) {
       f << ".input_arrival " << arrival.first << " " << arrival.second.first
-        << " " << arrival.second.second << std::endl;
+        << " " << arrival.second.second << '\n';
     }
 
     for (auto& required : requireds_) {
       f << ".output_required " << required.first << " " << required.second.first
-        << " " << required.second.second << std::endl;
+        << " " << required.second.second << '\n';
     }
   }
 

src/cut/src/blifParser.cpp

@@ -134,8 +134,8 @@ void BlifParser::addClock(const std::string& clock)
 void BlifParser::addNewInstanceType(const std::string& type)
 {
   if (currentInstanceType_ != GateType::None) {
-    gates_.push_back(
-        Gate(currentInstanceType_, currentGate_, currentConnections_));
+    gates_.emplace_back(
+        currentInstanceType_, currentGate_, currentConnections_);
   }
   currentInstanceType_ = GateType::Mlatch;
   if (type != "mlatch") {
@@ -159,8 +159,8 @@ void BlifParser::addConnection(const std::string& connection)
 void BlifParser::endParser()
 {
   if (currentInstanceType_ != GateType::None) {
-    gates_.push_back(
-        Gate(currentInstanceType_, currentGate_, currentConnections_));
+    gates_.emplace_back(
+        currentInstanceType_, currentGate_, currentConnections_);
   }
 }
 

src/cut/src/logic_cut.cpp

@@ -3,10 +3,9 @@
 
 #include "cut/logic_cut.h"
 
-#include <string.h>
-
 #include <algorithm>
 #include <cstdlib>
+#include <cstring>
 #include <memory>
 #include <string>
 #include <unordered_map>