clang-tidy requested changes

Signed-off-by: Osama <osama21@aucegypt.edu>

Author: osamahammad21

src/odb/include/odb/dbTypes.h

@@ -102,11 +102,9 @@ class dbOrientType
 class dbOrientType3D
 {
  public:
-  static std::optional<dbOrientType3D> fromString(const std::string orient);
+  static std::optional<dbOrientType3D> fromString(const std::string& orient);
 
-  dbOrientType3D(const std::string orient);
-
-  dbOrientType3D(const char* orient);
+  dbOrientType3D(const std::string& orient);
 
   ///
   /// Create a dbOrientType3D instance with an explicit orientation.

src/odb/src/db/dbTypes.cpp

@@ -189,7 +189,7 @@ bool dbOrientType::isRightAngleRotation() const
 }
 
 std::optional<dbOrientType3D> dbOrientType3D::fromString(
-    const std::string orient)
+    const std::string& orient)
 {
   std::string orient_str = orient;
   bool mirror_z = false;
@@ -208,7 +208,7 @@ std::optional<dbOrientType3D> dbOrientType3D::fromString(
   return dbOrientType3D(opt.value(), mirror_z);
 }
 
-dbOrientType3D::dbOrientType3D(const char* orient)
+dbOrientType3D::dbOrientType3D(const std::string& orient)
 {
   auto opt = fromString(orient);
   if (opt.has_value()) {