Merge pull request #8063 from The-OpenROAD-Project-staging/gui-fix-selection-bug

maliberty · web-flow · commit 807b3d5c094c · 2025-08-19T19:29:51.000Z
gui: fix flipped logic bug in select -filter (introduced in #7977)
diff --git a/src/gui/src/gui.cpp b/src/gui/src/gui.cpp
@@ -517,7 +517,7 @@ int Gui::select(const std::string& type,
         bool is_valid_attribute = false;
         Descriptor::Properties properties
             = descriptor->getProperties(sel.getObject());
-        if (filterSelectionProperties(
+        if (!filterSelectionProperties(
                 properties, attribute, value, is_valid_attribute)) {
           return;  // doesn't match the attribute filter
         }

Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ int Gui::select(const std::string& type,`
`517`	`517`	`bool is_valid_attribute = false;`
`518`	`518`	`Descriptor::Properties properties`
`519`	`519`	`= descriptor->getProperties(sel.getObject());`
`520`		`- if (filterSelectionProperties(`
	`520`	`+ if (!filterSelectionProperties(`
`521`	`521`	`properties, attribute, value, is_valid_attribute)) {`
`522`	`522`	`return; // doesn't match the attribute filter`
`523`	`523`	`}`