fix performance-avoid-endl

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/Main.cc

@@ -371,7 +371,7 @@ std::string findPathToTclreadlineInit(Tcl_Interp* interp)
 
   if (Tcl_Eval(interp, tcl_script) == TCL_ERROR) {
     std::cerr << "Tcl_Eval failed: " << Tcl_GetStringResult(interp)
-              << std::endl;
+              << '\n';
     return "";
   }
 

src/OpenRoad.cc

@@ -166,7 +166,7 @@ OpenRoad* OpenRoad::openRoad()
 void OpenRoad::setOpenRoad(OpenRoad* app, bool reinit_ok)
 {
   if (!reinit_ok && app_) {
-    std::cerr << "Attempt to reinitialize the application." << std::endl;
+    std::cerr << "Attempt to reinitialize the application.\n";
     exit(1);
   }
   app_ = app;

src/cut/src/blif.cpp

@@ -301,12 +301,12 @@ bool Blif::writeBlif(const char* file_name, bool write_arrival_requireds)
   if (write_arrival_requireds) {
     for (auto& arrival : arrivals_) {
       f << ".input_arrival " << arrival.first << " " << arrival.second.first
-        << " " << arrival.second.second << std::endl;
+        << " " << arrival.second.second << '\n';
     }
 
     for (auto& required : requireds_) {
       f << ".output_required " << required.first << " " << required.second.first
-        << " " << required.second.second << std::endl;
+        << " " << required.second.second << '\n';
     }
   }
 

src/drt/src/db/obj/frRPin.cpp

@@ -30,7 +30,7 @@ odb::Rect frRPin::getBBox()
       pt = accessPoint_->getPoint();
       break;
     default:
-      std::cout << "ERROR: Invalid term type in frRPin." << std::endl;
+      std::cout << "ERROR: Invalid term type in frRPin.\n";
       break;
   }
 

src/drt/src/db/tech/frLookupTbl.h

@@ -170,20 +170,20 @@ class fr2DLookupTbl
   // debug
   void printTbl() const
   {
-    std::cout << "rowName: " << rowName_ << std::endl;
+    std::cout << "rowName: " << rowName_ << '\n';
     for (auto& m : rows_) {
       std::cout << m << " ";
     }
-    std::cout << "\n colName: " << colName_ << std::endl;
+    std::cout << "\n colName: " << colName_ << '\n';
     for (auto& m : cols_) {
       std::cout << m << " ";
     }
-    std::cout << "\n vals: " << std::endl;
+    std::cout << "\n vals: \n";
     for (auto& m : vals_) {
       for (auto& n : m) {
         std::cout << n << " ";
       }
-      std::cout << std::endl;
+      std::cout << '\n';
     }
   }
 

src/drt/src/db/tech/frViaDef.h

@@ -127,23 +127,23 @@ class frViaDef
     if (!layer1Figs_.empty()) {
       return (layer1Figs_.at(0))->getLayerNum();
     }
-    std::cout << "Error: via does not have shape on layer 1" << std::endl;
+    std::cout << "Error: via does not have shape on layer 1\n";
     exit(1);
   }
   frLayerNum getLayer2Num() const
   {
     if (!layer2Figs_.empty()) {
       return (layer2Figs_.at(0))->getLayerNum();
     }
-    std::cout << "Error: via does not have shape on layer 2" << std::endl;
+    std::cout << "Error: via does not have shape on layer 2\n";
     exit(1);
   }
   frLayerNum getCutLayerNum() const
   {
     if (!cutFigs_.empty()) {
       return (cutFigs_.at(0))->getLayerNum();
     }
-    std::cout << "Error: via does not have shape on layer cut" << std::endl;
+    std::cout << "Error: via does not have shape on layer cut\n";
     exit(1);
   }
   const std::vector<std::unique_ptr<frShape>>& getLayer1Figs() const

src/drt/src/dr/FlexDR_end.cpp

@@ -280,7 +280,7 @@ void FlexDRWorker::endRemoveNets(
           endRemoveNets_pathSeg(design, cptr, boundPts[cptr->getNet()]);
         }
       } else {
-        std::cout << "Error: endRemoveNet hasNet() empty" << std::endl;
+        std::cout << "Error: endRemoveNet hasNet() empty\n";
       }
     } else if (rptr->typeId() == frcVia) {
       auto cptr = static_cast<frVia*>(rptr);
@@ -289,7 +289,7 @@ void FlexDRWorker::endRemoveNets(
           endRemoveNets_via(design, cptr);
         }
       } else {
-        std::cout << "Error: endRemoveNet hasNet() empty" << std::endl;
+        std::cout << "Error: endRemoveNet hasNet() empty\n";
       }
     } else if (rptr->typeId() == frcPatchWire) {
       auto cptr = static_cast<frPatchWire*>(rptr);
@@ -298,10 +298,10 @@ void FlexDRWorker::endRemoveNets(
           endRemoveNets_patchWire(design, cptr);
         }
       } else {
-        std::cout << "Error: endRemoveNet hasNet() empty" << std::endl;
+        std::cout << "Error: endRemoveNet hasNet() empty\n";
       }
     } else {
-      std::cout << "Error: endRemoveNets unsupported type" << std::endl;
+      std::cout << "Error: endRemoveNets unsupported type\n";
     }
   }
 }
@@ -610,7 +610,7 @@ void FlexDRWorker::endAddNets(
       } else if (connFig->typeId() == drcPatchWire) {
         endAddNets_patchWire(design, static_cast<drPatchWire*>(connFig.get()));
       } else {
-        std::cout << "Error: endAddNets unsupported type" << std::endl;
+        std::cout << "Error: endAddNets unsupported type\n";
       }
     }
     if (net->hasExtFigUpdates()) {

src/drt/src/dr/FlexDR_init.cpp

@@ -237,25 +237,25 @@ void FlexDRWorker::initNetObjs(
       if (cptr->hasNet()) {
         initNetObjs_pathSeg(cptr, nets, netRouteObjs, netExtObjs);
       } else {
-        std::cout << "Error: initNetObjs hasNet() empty" << std::endl;
+        std::cout << "Error: initNetObjs hasNet() empty\n";
       }
     } else if (rptr->typeId() == frcVia) {
       auto cptr = static_cast<frVia*>(rptr);
       if (cptr->hasNet()) {
         initNetObjs_via(cptr, nets, netRouteObjs, netExtObjs);
       } else {
-        std::cout << "Error: initNetObjs hasNet() empty" << std::endl;
+        std::cout << "Error: initNetObjs hasNet() empty\n";
       }
     } else if (rptr->typeId() == frcPatchWire) {
       auto cptr = static_cast<frPatchWire*>(rptr);
       if (cptr->hasNet()) {
         initNetObjs_patchWire(cptr, nets, netRouteObjs, netExtObjs);
       } else {
-        std::cout << "Error: initNetObjs hasNet() empty" << std::endl;
+        std::cout << "Error: initNetObjs hasNet() empty\n";
       }
     } else {
       std::cout << rptr->typeId() << "\n";
-      std::cout << "Error: initCopyDRObjs unsupported type" << std::endl;
+      std::cout << "Error: initCopyDRObjs unsupported type\n";
     }
   }
   if (isInitDR()) {
@@ -813,8 +813,7 @@ void FlexDRWorker::initNets_searchRepair_pin2epMap(
       }
     } else if (connFig->typeId() == drcPatchWire) {
     } else {
-      std::cout << "Error: initNets_searchRepair_pin2epMap unsupported type"
-                << std::endl;
+      std::cout << "Error: initNets_searchRepair_pin2epMap unsupported type\n";
     }
   }
 }
@@ -845,8 +844,7 @@ void FlexDRWorker::initNets_searchRepair_nodeMap_routeObjEnd(
       const auto lNum = obj->getLayerNum();
       nodeMap[{bp, lNum}].insert(i);
     } else {
-      std::cout << "Error: initNets_searchRepair_nodeMap unsupported type"
-                << std::endl;
+      std::cout << "Error: initNets_searchRepair_nodeMap unsupported type\n";
     }
   }
 }
@@ -1678,7 +1676,7 @@ void FlexDRWorker::initTrackCoords_route(drNet* net,
       }
     } else if (uConnFig->typeId() == drcPatchWire) {
     } else {
-      std::cout << "Error: initTrackCoords unsupported type" << std::endl;
+      std::cout << "Error: initTrackCoords unsupported type\n";
     }
   }
 }
@@ -1779,7 +1777,7 @@ void FlexDRWorker::initMazeIdx_connFig(drConnFig* connFig)
     } else {
       std::cout << "Error: initMazeIdx_connFig pathseg no idx (" << bp.x()
                 << ", " << bp.y() << ") (" << ep.x() << ", " << ep.y() << ") "
-                << getTech()->getLayer(lNum)->getName() << std::endl;
+                << getTech()->getLayer(lNum)->getName() << '\n';
     }
   } else if (connFig->typeId() == drcVia) {
     auto obj = static_cast<drVia*>(connFig);
@@ -1796,11 +1794,11 @@ void FlexDRWorker::initMazeIdx_connFig(drConnFig* connFig)
     } else {
       std::cout << "Error: initMazeIdx_connFig via no idx (" << bp.x() << ", "
                 << bp.y() << ") "
-                << getTech()->getLayer(layer1Num + 1)->getName() << std::endl;
+                << getTech()->getLayer(layer1Num + 1)->getName() << '\n';
     }
   } else if (connFig->typeId() == drcPatchWire) {
   } else {
-    std::cout << "Error: initMazeIdx_connFig unsupported type" << std::endl;
+    std::cout << "Error: initMazeIdx_connFig unsupported type\n";
   }
 }
 
@@ -1826,7 +1824,7 @@ void FlexDRWorker::initMazeIdx_ap(drAccessPattern* ap)
     }
   } else {
     std::cout << "Error: initMazeIdx_ap no idx (" << bp.x() << ", " << bp.y()
-              << ") " << getTech()->getLayer(lNum)->getName() << std::endl;
+              << ") " << getTech()->getLayer(lNum)->getName() << '\n';
   }
 
   if (gridGraph_.hasMazeIdx(bp, lNum + 2)) {
@@ -2085,8 +2083,7 @@ void FlexDRWorker::initMazeCost_marker_route_queue_addHistoryCost(
         if (i == 4) {
           std::cout
               << "Warning: marker bloat 4x width but could not find two grids "
-                 "to add marker cost"
-              << std::endl;
+                 "to add marker cost\n";
           std::cout << "  marker -- src: ";
           for (auto src : marker.getSrcs()) {
             if (src) {
@@ -2563,7 +2560,8 @@ void FlexDRWorker::route_queue_update_from_marker(
               allowAvoidRipup = true;
               dNet->setNRipupAvoids(0);
             }
-            routes.emplace_back(dNet, dNet->getNumReroutes(), true, checkingObj);
+            routes.emplace_back(
+                dNet, dNet->getNumReroutes(), true, checkingObj);
           }
         }
       }

src/drt/src/dr/FlexDR_maze.cpp

@@ -1937,8 +1937,7 @@ void FlexDRWorker::route_queue_main(std::queue<RouteQueueEntry>& rerouteQueue)
           if (router_cfg_->VERBOSE > 0) {
             std::cout
                 << "Warning: no output maze log specified, skipped writing "
-                   "maze log"
-                << std::endl;
+                   "maze log\n";
           }
         } else {
           gridGraph_.print();
@@ -2458,7 +2457,7 @@ void FlexDRWorker::routeNet_postAstarUpdate(
       }
     }
   } else {
-    std::cout << "Error: routeNet_postAstarUpdate path is empty" << std::endl;
+    std::cout << "Error: routeNet_postAstarUpdate path is empty\n";
   }
   // must be before comment line ABC so that the used actual src is set in
   // gridgraph

src/drt/src/dr/FlexDR_rq.cpp

@@ -67,7 +67,7 @@ void FlexDRWorkerRegionQuery::add(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getLayer1Num())
             .insert(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getLayer2Figs()) {
@@ -78,7 +78,7 @@ void FlexDRWorkerRegionQuery::add(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getLayer2Num())
             .insert(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getCutFigs()) {
@@ -89,11 +89,11 @@ void FlexDRWorkerRegionQuery::add(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getCutLayerNum())
             .insert(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
   } else {
-    std::cout << "Error: unsupported region query add" << std::endl;
+    std::cout << "Error: unsupported region query add\n";
   }
 }
 
@@ -117,7 +117,7 @@ void FlexDRWorkerRegionQuery::Impl::add(
         allShapes.at(via->getViaDef()->getLayer1Num())
             .emplace_back(frb, via);
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getLayer2Figs()) {
@@ -128,7 +128,7 @@ void FlexDRWorkerRegionQuery::Impl::add(
         allShapes.at(via->getViaDef()->getLayer2Num())
             .emplace_back(frb, via);
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getCutFigs()) {
@@ -139,11 +139,11 @@ void FlexDRWorkerRegionQuery::Impl::add(
         allShapes.at(via->getViaDef()->getCutLayerNum())
             .emplace_back(frb, via);
       } else {
-        std::cout << "Error: unsupported region query add" << std::endl;
+        std::cout << "Error: unsupported region query add\n";
       }
     }
   } else {
-    std::cout << "Error: unsupported region query add" << std::endl;
+    std::cout << "Error: unsupported region query add\n";
   }
 }
 
@@ -165,7 +165,7 @@ void FlexDRWorkerRegionQuery::remove(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getLayer1Num())
             .remove(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query remove" << std::endl;
+        std::cout << "Error: unsupported region query remove\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getLayer2Figs()) {
@@ -176,7 +176,7 @@ void FlexDRWorkerRegionQuery::remove(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getLayer2Num())
             .remove(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query remove" << std::endl;
+        std::cout << "Error: unsupported region query remove\n";
       }
     }
     for (auto& uShape : via->getViaDef()->getCutFigs()) {
@@ -187,11 +187,11 @@ void FlexDRWorkerRegionQuery::remove(drConnFig* connFig)
         impl_->shapes.at(via->getViaDef()->getCutLayerNum())
             .remove(std::make_pair(frb, via));
       } else {
-        std::cout << "Error: unsupported region query remove" << std::endl;
+        std::cout << "Error: unsupported region query remove\n";
       }
     }
   } else {
-    std::cout << "Error: unsupported region query remove" << std::endl;
+    std::cout << "Error: unsupported region query remove\n";
   }
 }