Merge branch 'master' into mpl-new-blockages

Author: joaomai

.buildifier.json

@@ -2,103 +2,5 @@
     "type": "auto",
     "mode": "fix",
     "lint": "fix",
-    "warningsList": [
-        "attr-applicable_licenses",
-        "attr-cfg",
-        "attr-license",
-        "attr-licenses",
-        "attr-non-empty",
-        "attr-output-default",
-        "attr-single-file",
-        "build-args-kwargs",
-        "bzl-visibility",
-        "confusing-name",
-        "constant-glob",
-        "ctx-actions",
-        "ctx-args",
-        "deprecated-function",
-        "depset-items",
-        "depset-iteration",
-        "depset-union",
-        "dict-concatenation",
-        "dict-method-named-arg",
-        "duplicated-name",
-        "filetype",
-        "function-docstring",
-        "function-docstring-args",
-        "function-docstring-header",
-        "function-docstring-return",
-        "git-repository",
-        "http-archive",
-        "integer-division",
-        "keyword-positional-params",
-        "list-append",
-        "load",
-        "module-docstring",
-        "name-conventions",
-        "native-android",
-        "native-build",
-        "native-cc-binary",
-        "native-cc-common",
-        "native-cc-debug-package-info",
-        "native-cc-fdo-prefetch-hints",
-        "native-cc-fdo-profile",
-        "native-cc-import",
-        "native-cc-info",
-        "native-cc-library",
-        "native-cc-memprof-profile",
-        "native-cc-objc-import",
-        "native-cc-objc-library",
-        "native-cc-propeller-optimize",
-        "native-cc-proto",
-        "native-cc-shared-library",
-        "native-cc-shared-library-hint-info",
-        "native-cc-shared-library-info",
-        "native-cc-test",
-        "native-cc-toolchain",
-        "native-cc-toolchain-suite",
-        "native-java-binary",
-        "native-java-common",
-        "native-java-import",
-        "native-java-info",
-        "native-java-library",
-        "native-java-lite-proto",
-        "native-java-package-config",
-        "native-java-plugin",
-        "native-java-plugin-info",
-        "native-java-proto",
-        "native-java-runtime",
-        "native-java-test",
-        "native-java-toolchain",
-        "native-package",
-        "native-proto",
-        "native-proto-common",
-        "native-proto-info",
-        "native-proto-lang-toolchain",
-        "native-proto-lang-toolchain-info",
-        "native-py",
-        "native-sh-binary",
-        "native-sh-library",
-        "native-sh-test",
-        "no-effect",
-        "output-group",
-        "overly-nested-depset",
-        "package-name",
-        "package-on-top",
-        "positional-args",
-        "print",
-        "provider-params",
-        "redefined-variable",
-        "repository-name",
-        "return-value",
-        "rule-impl-return",
-        "skylark-comment",
-        "skylark-docstring",
-        "string-iteration",
-        "uninitialized",
-        "unnamed-macro",
-        "unreachable",
-        "unsorted-dict-items",
-        "unused-variable"
-    ]
+    "warnings": "all"
 }

.github/workflows/bazel-format-lint.yaml

@@ -0,0 +1,44 @@
+name: Lint Bazel
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  buildifier:
+    runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }}
+    strategy:
+      fail-fast: false
+      matrix:
+        check:
+          - name: Buildifier format
+            run: ./buildifier -r -mode=check -lint=off .
+          - name: Buildifier lint
+            run: ./buildifier -r -lint=warn .
+    name: ${{ matrix.check.name }}
+    env:
+      BUILDIFIER_VERSION: v8.2.1
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v5
+
+      - name: Cache buildifier
+        id: cache-buildifier
+        uses: actions/cache@v4
+        with:
+          path: ./buildifier
+          key: ${{ runner.os }}-buildifier-${{ env.BUILDIFIER_VERSION }}
+
+      - name: Download buildifier
+        if: steps.cache-buildifier.outputs.cache-hit != 'true'
+        run: |
+          wget https://github.com/bazelbuild/buildtools/releases/download/${BUILDIFIER_VERSION}/buildifier-linux-amd64 -O buildifier
+          chmod +x buildifier
+
+      - name: ${{ matrix.check.name }}
+        run: ${{ matrix.check.run }}

.github/workflows/buildifier.yaml

@@ -2,6 +2,9 @@
 # Copyright (c) 2025-2025, The OpenROAD Authors
 
 load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
+load("@openroad_rules_python//python:defs.bzl", "py_library")
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("//bazel:python_wrap_cc.bzl", "PYTHON_STABLE_API_DEFINE", "python_wrap_cc")
 load("//bazel:tcl_encode_or.bzl", "tcl_encode")
 load("//bazel:tcl_wrap_cc.bzl", "tcl_wrap_cc")
@@ -104,8 +107,8 @@ OPENROAD_LIBRARY_DEPS = [
     "@edu_berkeley_abc//:abc-lib",
 ] + select(
     {
-        ":platform_gui": ["//src/gui:gui_qt"],
         ":platform_cli": ["//src/gui"],
+        ":platform_gui": ["//src/gui:gui_qt"],
     },
 )
 
@@ -161,8 +164,8 @@ cc_binary(
 
 GUI_BUILD_FLAGS = select(
     {
-        ":platform_gui": ["BUILD_GUI=true"],
         ":platform_cli": ["BUILD_GUI=false"],
+        ":platform_gui": ["BUILD_GUI=true"],
     },
 )
 

BUILD.bazel

@@ -173,8 +173,6 @@ use_repo(orfs, "docker_orfs")
 
 SCALA_VERSION = "2.13.16"
 
-SCALA_VERSION_SHORT = SCALA_VERSION.rpartition(".")[0]
-
 scala_config = use_extension(
     "@rules_scala//scala/extensions:config.bzl",
     "scala_config",

MODULE.bazel

@@ -1,4 +1,5 @@
 load("@openroad_rules_python//python:pip.bzl", "compile_pip_requirements")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
 compile_pip_requirements(
     name = "requirements",

bazel/BUILD

@@ -43,13 +43,13 @@ tcl_encode = rule(
             doc = "The name of the extern string array value in the generated file.",
             mandatory = True,
         ),
-        "out": attr.string(
-            doc = "The name of the C++ source file generated by these rules.",
-        ),
         "namespace": attr.string(
             doc = "The namespace in the C++ source file generated.",
             mandatory = True,
         ),
+        "out": attr.string(
+            doc = "The name of the C++ source file generated by these rules.",
+        ),
         "srcs": attr.label_list(
             allow_empty = False,
             allow_files = [".tcl", ".py"],

bazel/tcl_encode_or.bzl

@@ -136,6 +136,7 @@ tcl_wrap_cc = rule(
             The root file must be explicitly provided. This is the file which will be passed to
             swig for generation.""",
         ),
+        "runtime_header": attr.string(),
         "srcs": attr.label_list(
             allow_empty = False,
             allow_files = [".i", ".swig", ".h", ".hpp", ".hh"],
@@ -147,7 +148,6 @@ tcl_wrap_cc = rule(
         "swig_options": attr.string_list(
             doc = "args to pass directly to the swig binary",
         ),
-        "runtime_header": attr.string(),
         "_swig": attr.label(
             default = "@org_swig//:swig_stable",
             allow_files = True,

bazel/tcl_wrap_cc.bzl

@@ -1,3 +1,5 @@
+load("@openroad_rules_python//python:defs.bzl", "py_binary")
+
 py_binary(
     name = "file_to_string",
     srcs = [

etc/BUILD

@@ -1,3 +1,5 @@
+load("@openroad_rules_python//python:defs.bzl", "py_library")
+
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2025-2025, The OpenROAD Authors
 load("@openroad_rules_python//python:packaging.bzl", "py_package", "py_wheel")