Merge pull request #8935 from The-OpenROAD-Project-staging/odb-fix-region-rm

odb: Fix group removal in region destroy

Author: maliberty

src/odb/src/db/dbRegion.cpp

@@ -350,10 +350,8 @@ void dbRegion::destroy(dbRegion* region_)
   dbSet<dbGroup>::iterator gitr;
 
   for (gitr = groups.begin(); gitr != groups.end(); gitr = groups.begin()) {
-    _dbGroup* _group = (_dbGroup*) *gitr;
-    _group->region_ = 0;
-    _group->region_next_ = 0;
-    _group->region_prev_ = 0;
+    dbGroup* group = *gitr;
+    region_->removeGroup(group);
   }
 
   dbProperty::destroyProperties(region);

src/odb/test/test_group.tcl

@@ -79,7 +79,21 @@ proc test_destroy { } {
   tearDown $db
 }
 
+proc test_region_w_groups_destroy { } {
+  lassign [createSimpleDB] db lib
+  set block [create1LevelBlock $db $lib [$db getChip]]
+
+  # create region
+  set foo_region [odb::dbRegion_create $block foo_region]
+  # and a group
+  set foo_group [odb::dbGroup_create $foo_region foo_group]
+  # destroy region while it has group
+  odb::dbRegion_destroy $foo_region
+  tearDown $db
+}
+
 test_default
 test_destroy
+test_region_w_groups_destroy
 puts "pass"
 exit 0