Skip to content

Commit 916a10c

Browse files
committed
address review
Signed-off-by: LucasYuki <[email protected]>
1 parent 7c40684 commit 916a10c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/odb/include/odb/dbBlockCallBackObj.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ class dbWire;
4646
class dbBlockCallBackObj
4747
{
4848
public:
49+
dbBlockCallBackObj() { owner_ = nullptr; }
50+
virtual ~dbBlockCallBackObj() { removeOwner(); }
51+
4952
// dbInst Start
5053
virtual void inDbInstCreate(dbInst*) {}
5154
virtual void inDbInstCreate(dbInst*, dbRegion*) {}
@@ -194,9 +197,6 @@ class dbBlockCallBackObj
194197
bool hasOwner() const { return (owner_ != nullptr); }
195198
void removeOwner();
196199

197-
dbBlockCallBackObj() { owner_ = nullptr; }
198-
virtual ~dbBlockCallBackObj() { removeOwner(); }
199-
200200
private:
201201
dbBlock* owner_;
202202
};

src/odb/include/odb/dbChipCallBackObj.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ class dbMarkerCategory;
2121
class dbChipCallBackObj
2222
{
2323
public:
24+
dbChipCallBackObj() { _owner = nullptr; }
25+
virtual ~dbChipCallBackObj() { removeOwner(); }
26+
2427
// dbMarkerCategory Start
2528
virtual void inDbMarkerCategoryCreate(dbMarkerCategory*) {}
2629
virtual void inDbMarkerCategoryDestroy(dbMarkerCategory*) {}
@@ -39,9 +42,6 @@ class dbChipCallBackObj
3942
bool hasOwner() const { return (_owner != nullptr); }
4043
void removeOwner();
4144

42-
dbChipCallBackObj() { _owner = nullptr; }
43-
virtual ~dbChipCallBackObj() { removeOwner(); }
44-
4545
private:
4646
dbChip* _owner = nullptr;
4747
};

0 commit comments

Comments
 (0)